Moodle
  1. Moodle
  2. MDL-30150

page type stuff ignores frankenstyle rules

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.3
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      For devs:
      1/ fix some plugin that is not using frankenstyle function names for page type callback
      2/ verify the localised page types are still there when editing block on the plugin page

      Show
      For devs: 1/ fix some plugin that is not using frankenstyle function names for page type callback 2/ verify the localised page types are still there when editing block on the plugin page
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w44_MDL-30150_m22_pagetypefrankenstyle

      Description

      the trouble is that *_page_type_list do not use full component name as prefix which is not acceptable, the short plugin name can be used only for 'mod' and BC...

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            To integrators: please cherry pick to 2.1 stable

            Show
            Petr Skoda added a comment - To integrators: please cherry pick to 2.1 stable
            Hide
            Sam Hemelryk added a comment -

            Just noting that this looks perfect however I am holding off it's integration presently and will integrate this at the same time as MDL-29030.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Just noting that this looks perfect however I am holding off it's integration presently and will integrate this at the same time as MDL-29030 . Cheers Sam
            Hide
            Sam Hemelryk added a comment -

            This has been integrated now (merged to master, cherry-picked to 21).
            Thanks Petr.

            Show
            Sam Hemelryk added a comment - This has been integrated now (merged to master, cherry-picked to 21). Thanks Petr.
            Hide
            Rajesh Taneja added a comment -

            Works Great
            Thanks for fixing this Petr.

            Show
            Rajesh Taneja added a comment - Works Great Thanks for fixing this Petr.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: