Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30150

page type stuff ignores frankenstyle rules

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Critical
          • Resolution: Fixed
          • Affects Version/s: 2.1
          • Fix Version/s: 2.1.3
          • Component/s: Blocks
          • Labels:
          • Testing Instructions:
            Hide

            For devs:
            1/ fix some plugin that is not using frankenstyle function names for page type callback
            2/ verify the localised page types are still there when editing block on the plugin page

            Show
            For devs: 1/ fix some plugin that is not using frankenstyle function names for page type callback 2/ verify the localised page types are still there when editing block on the plugin page
          • Affected Branches:
            MOODLE_21_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            w44_MDL-30150_m22_pagetypefrankenstyle
          • Pull Master Diff URL:

            Description

            the trouble is that *_page_type_list do not use full component name as prefix which is not acceptable, the short plugin name can be used only for 'mod' and BC...

              Gliffy Diagrams

                Attachments

                  Issue Links

                  blocks

                  Improvement - An enhancement to an existing Moodle feature. MDL-29030 New general /report/ plugin type

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    skodak Petr Skoda added a comment -

                    To integrators: please cherry pick to 2.1 stable

                    Show
                    skodak Petr Skoda added a comment - To integrators: please cherry pick to 2.1 stable
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Just noting that this looks perfect however I am holding off it's integration presently and will integrate this at the same time as MDL-29030.

                    Cheers
                    Sam

                    Show
                    samhemelryk Sam Hemelryk added a comment - Just noting that this looks perfect however I am holding off it's integration presently and will integrate this at the same time as MDL-29030 . Cheers Sam
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    This has been integrated now (merged to master, cherry-picked to 21).
                    Thanks Petr.

                    Show
                    samhemelryk Sam Hemelryk added a comment - This has been integrated now (merged to master, cherry-picked to 21). Thanks Petr.
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Works Great
                    Thanks for fixing this Petr.

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Works Great Thanks for fixing this Petr.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

                    Ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        0 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          28/Nov/11