Moodle
  1. Moodle
  2. MDL-30154

WebDAV-Repository fails on some WebDAV-Server

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      You need a free account on mydrive.ch.

      1. create a webdav-repository instance to mydrive with
        • WebDAV type: http,
        • WebDAV server: webdav.mydrive.ch
        • WebDAV path: /
        • Authentication: WebDAV basic auth
        • WebDAV server port: 80
      2. create a ressource file and connect to the repository. Folder and files should be shown and can be loaded into the file api.
      Show
      You need a free account on mydrive.ch. create a webdav-repository instance to mydrive with WebDAV type: http, WebDAV server: webdav.mydrive.ch WebDAV path: / Authentication: WebDAV basic auth WebDAV server port: 80 create a ressource file and connect to the repository. Folder and files should be shown and can be loaded into the file api.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30154_master_wip

      Description

      On some WebDAV-Server like MyDrive.ch the functions get_respond() and ls() in lib/webdavlib.php do not work properly.
      One problem is the content-type in ls(). At MyDrive.ch it is application/xml and not text/xml.
      Next problem is the max_chunk_size in get_respond(). It seams the server from MyDrive does allow only a lower size than the defined max_chunk_size of 8192. So not the full chunk is loaded and the file is cropped.
      In the file repository/webdav/lib.php the directory listing fails on MyDrive.ch.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Andreas Grabs added a comment -

            Thank you for the great repository! I am hoping I can help a bit with this fix.
            Andreas

            Show
            Andreas Grabs added a comment - Thank you for the great repository! I am hoping I can help a bit with this fix. Andreas
            Hide
            Dongsheng Cai added a comment -

            Looks good, thanks Andreas!

            Show
            Dongsheng Cai added a comment - Looks good, thanks Andreas!
            Hide
            Aparup Banerjee added a comment -

            Thanks! this has been integrated and is up for testing.

            Show
            Aparup Banerjee added a comment - Thanks! this has been integrated and is up for testing.
            Hide
            Rajesh Taneja added a comment -

            Works Great
            Thanks for fixing this Andreas.

            Show
            Rajesh Taneja added a comment - Works Great Thanks for fixing this Andreas.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: