Moodle

Remove irrelevant code from question\format\blackboard\format.php

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.5, 2.1.2, 2.2
  • Fix Version/s: 2.0.6, 2.1.3
  • Component/s: Questions
  • Labels:
  • Testing Instructions:
    Hide

    No testing should be needed.
    If you have blackboard backups, just make sure they work as before during restore!

    (Acutally, Blackboard import is been broken since 2.0, so this is impossible to test. Anyway, this is a good clean-up that should be integrated.)

    Show
    No testing should be needed. If you have blackboard backups, just make sure they work as before during restore! (Acutally, Blackboard import is been broken since 2.0, so this is impossible to test. Anyway, this is a good clean-up that should be integrated.)
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-30158-master
  • Pull Master Diff URL:

Description

Just found that in master we have something like

$question->questiontext = $question->questiontext;

which should be removed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ankit Agarwal added a comment -

This can be cherry-picked to 20 and 21
Thanks!

Show
Ankit Agarwal added a comment - This can be cherry-picked to 20 and 21 Thanks!
Hide
Permalink
Tim Hunt added a comment -

Submitting for integration. Thanks Ankit.

Show
Tim Hunt added a comment - Submitting for integration. Thanks Ankit.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Ankit,

This does not cherry-pick cleanly to 2.0, could you please produce proper branches.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Ankit, This does not cherry-pick cleanly to 2.0, could you please produce proper branches. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Stopping review presently

Show
Sam Hemelryk added a comment - Stopping review presently
Hide
Permalink
Ankit Agarwal added a comment -

Hi Sam,
Sorry for the troubles. Branches are up.
Thanks!

Show
Ankit Agarwal added a comment - Hi Sam, Sorry for the troubles. Branches are up. Thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Jason Fowler added a comment -

No testing possible

Show
Jason Fowler added a comment - No testing possible
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: