Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30165

Repository Filter performs case sensitive search on file extensions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Repositories
    • Labels:
    • Environment:
      Debian Squeeze
    • Database:
      Any
    • Testing Instructions:
      Hide

      Requirements

      On your local filesystem, create two files:

      • lowercase.mp3
      • uppercase.MP3

      These don't need to have any content. I used touch to create two empty files.

      Instructions

      • Navigate to My Profile -> My private files
      • Click 'Manage my private files'
      • Select 'Add' and upload both of your prepared files
      • Navigate to a course and turn on editing mode
      • Add a new page
      • In the Description, use the 'Moodle Media' button to insert some media
      • Select 'Find or upload a sound, video or applet...'
      • Choose 'Private files'

      Expected result

      Both uppercase.MP3 and lowercase.mp3 are listed

      Actual result

      Only lowercase.mp3 is listed

      Show
      Requirements On your local filesystem, create two files: lowercase.mp3 uppercase.MP3 These don't need to have any content. I used touch to create two empty files. Instructions Navigate to My Profile -> My private files Click 'Manage my private files' Select 'Add' and upload both of your prepared files Navigate to a course and turn on editing mode Add a new page In the Description, use the 'Moodle Media' button to insert some media Select 'Find or upload a sound, video or applet...' Choose 'Private files' Expected result Both uppercase.MP3 and lowercase.mp3 are listed Actual result Only lowercase.mp3 is listed
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30165-master-1
    • Pull Master Diff URL:

      Description

      When using a repository plugin which restricts based on the supported_filetypes() function and uses the repository->filter() function, the filter function uses a case sensitive regular expression to check the file extension type.

      E.g. example.mp3 is shown; example.MP3 is not.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25923 Uppercase extensions make files invisible to File Picker

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29495 Inconstant display of files in file picker (once again)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29955 f4v extension not recognised as web_video filetype

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11