Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30166

Deprecated %fullname% uses still present in core

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Goto a course>Forum (View.php not discussion.php)
      2. Make sure there are some discussion with posts in the forum.
      3. Make sure you have rss feeds enabled for server, site, and at activity level (for each module that we will be testing)
      4. View the source of the page and make sure you can see an <link rel="alternate" type="application/rss+xml" in the page header
      5. Make sure the title attribute for this is "course : Activityname"
      6. Now go to a discussion page and verify the above holds true for it as well
      7. Goto a glossary view page and verify the above holds true for it as well
      8. view.php for a database with a few entries, and verify the same.
      9. Goto add a DB entry page (edit.php) and verify title as before.
      Show
      Goto a course>Forum (View.php not discussion.php) Make sure there are some discussion with posts in the forum. Make sure you have rss feeds enabled for server, site, and at activity level (for each module that we will be testing) View the source of the page and make sure you can see an <link rel="alternate" type="application/rss+xml" in the page header Make sure the title attribute for this is "course : Activityname" Now go to a discussion page and verify the above holds true for it as well Goto a glossary view page and verify the above holds true for it as well view.php for a database with a few entries, and verify the same. Goto add a DB entry page (edit.php) and verify title as before.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-30166-master

      Description

      I was looking the html of one page and saw this:

      <link rel="alternate" type="application/rss+xml" title="Using Moodle: %fullname%" .... />

      Looking for %fullname% in code base I got that it is still being used by:

      • lang/en/moodle.php
      • mod/data/edit.php
      • mod/data/view.php
      • mod/forum/discuss.php
      • mod/forum/view.php
      • mod/glossary/view.php

      And the code @ lib/pagelib.php says it's deprecated (so the "template replacement" does not happen anymore), so all uses in the files above should be changed to don't use %fullname% at all.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ankit_frenz Ankit Agarwal
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Peer reviewer:
                Rossiani Wijaya
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Jason Fowler
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, cameron1729, David Mudrák (@mudrd8mz), Helen Foster, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Mar/13