Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30173

The assignment submissions() function doesn't pass the filter param when $mode = 'next' or 'saveandnext'

    Details

    • Testing Instructions:
      Hide
      • Create a new submittable assignment
      • enrol six users on the course (the more the better)
      • submit assignments for users one, two, four, and six

      As the teacher

      • open the submissions page
      • confirm all six users are displayed
      • note the order of those users
      • Under 'Optional Settings', set Show to 'Require grading' and save preferenecs
      • Verify you only have users 1, 2, 4, and 6 displayed
      • Select 'Grade' on user 1
      • Select 'Next'
      • Verify that the grade screen for user 2 is displayed
      • Select 'Next'

      Expected Result

      The grade screen for User 4 is displayed

      Actual Result

      The grade screen for User 3 is displayed

      Show
      Create a new submittable assignment enrol six users on the course (the more the better) submit assignments for users one, two, four, and six As the teacher open the submissions page confirm all six users are displayed note the order of those users Under 'Optional Settings', set Show to 'Require grading' and save preferenecs Verify you only have users 1, 2, 4, and 6 displayed Select 'Grade' on user 1 Select 'Next' Verify that the grade screen for user 2 is displayed Select 'Next' Expected Result The grade screen for User 4 is displayed Actual Result The grade screen for User 3 is displayed
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30173-master-2

      Description

      submissions() doesn't check whether a filter is in use and therefore returns results which aren't within that result set when moving to consecutive results within the result set

      Cause

      The filter param is missing in the redirect() for the 'next' (and 'saveandnext') case of submissions().
      As a result, when the grade screen for the second user is displayed, and the URL for the 'next' button is calculated, the wrong user is calculated

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    28/Nov/11