Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30174

Offset not adjusted when using 'saveandnext'

XMLWordPrintable

    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • MDL-30174-master-2
    • Hide

      Working with my patch for MDL-30173 applied and using the same base instructions:

      Users 1,2,4,6 have submitted work. It's not yet graded. As a teacher:

      • Click the 'Grade' link for user 1
      • write a comment, give a grade (be generous), and choose 'Save and Next'
      • Verify that the page for User 2 is displayed.
      • write a comment, give a grade (be generous), and choose 'Save and Next'

      Expected Result

      The grading page for user 4 should be displayed

      Actual result

      The grading page for user 6 is displayed

      Cause

      The offset was not reduced after marking in mod/assignment/lib.php::assignment_base->submission(). As a result when display_submission() is called and the offset retrieved, the wrong user is calculated for the next page.

      Show
      Working with my patch for MDL-30173 applied and using the same base instructions: Users 1,2,4,6 have submitted work. It's not yet graded. As a teacher: Click the 'Grade' link for user 1 write a comment, give a grade (be generous), and choose 'Save and Next' Verify that the page for User 2 is displayed. write a comment, give a grade (be generous), and choose 'Save and Next' Expected Result The grading page for user 4 should be displayed Actual result The grading page for user 6 is displayed Cause The offset was not reduced after marking in mod/assignment/lib.php::assignment_base->submission(). As a result when display_submission() is called and the offset retrieved, the wrong user is calculated for the next page.

      When using the "Save and Next" during assignment grading, and after my patch to get filter results to apply in MDL-30173 is applied; a bug with offset calculation becomes apparent.

      When Saving grade information, the offset should be decreased when calculating the URL for the 'next' button.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Ankit Agarwal Ankit Agarwal
            Aparup Banerjee Aparup Banerjee
            Sam Hemelryk Sam Hemelryk
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.