Moodle
  1. Moodle
  2. MDL-30179

User report and Grader report are inconsistent for the grade that is hidden

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1.2
    • Fix Version/s: DEV backlog
    • Component/s: Gradebook
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      26068

      Description

      If I am a grader and I decided to hide the grade for one student for an assignment, I can still see it in the Grader report (but the font is gray).
      If I (again as a grader) go to the user report for this user I:

      • CAN see the assignment
      • CAN NOT see any grade, not even gray, in the columns 'Grade', 'Percentage', 'Rank'
      • CAN see the grade in the column 'Letter grade' (I enabled it in settings)
        As a student I don't see this assignment in the user report at all.

      There should be a clear policy, what User report shows if it is viewed by a grader:
      1) it shows the same as Grader report but for a particular user
      or
      2) it shows the same as what this user would see in his User report

      Depending on this policy the hidden grades should be shown or the whole line with module should not be shown at all.


      Regarding 'Rank': there should be also a policy whether to include the hidden grades in rank or not. At the moment they are included, so for other students the rank is calculated as if hidden grades were normal grades. But for student whose grade is hidden, rank is not displayed (although exists)

      The column 'Average' displays the average only for grades that are not hidden. So for other users it looks strange: "Rank 2/4, Average 30.00 (3)"

      So I would suggest that Rank should not include hidden grades

        Activity

        Hide
        Martin Dougiamas added a comment -

        Adam and Robert: should we change the default assignee for newly reported gradebook bugs (like this one) to be one of you guys? If not, let's work out what to do.

        Show
        Martin Dougiamas added a comment - Adam and Robert: should we change the default assignee for newly reported gradebook bugs (like this one) to be one of you guys? If not, let's work out what to do.
        Hide
        Marina Glancy added a comment -

        Just noticed:

        in Grader report the 'Average' for the module DOES include hidden grades. The same field in User report DOES NOT include them. One more inconsistent thing

        Show
        Marina Glancy added a comment - Just noticed: in Grader report the 'Average' for the module DOES include hidden grades. The same field in User report DOES NOT include them. One more inconsistent thing
        Hide
        Marina Glancy added a comment -

        Sorry, can't keep commenting:

        There is actually a setting for Grader report "Grades selected for column averages" (grade_report_meanselection), but it does not say how it considers hidden grades

        There is a setting for user report grade_report_user_showhiddenitems. If set the student can see module on which his grade was hidden, and luckily no grades there, even 'Letter grade' is empty.

        And there is another setting for User report grade_report_user_showtotalsifcontainhidden, which can be set to 'Show totals including hidden items' which is absolutely crazy. In this case student can not see the hidden grade, he sees this module as if it has not been graded, but his total looks completely random for him (because it includes grades he can not see).

        Show
        Marina Glancy added a comment - Sorry, can't keep commenting: There is actually a setting for Grader report "Grades selected for column averages" ( grade_report_meanselection ), but it does not say how it considers hidden grades There is a setting for user report grade_report_user_showhiddenitems . If set the student can see module on which his grade was hidden, and luckily no grades there, even 'Letter grade' is empty. And there is another setting for User report grade_report_user_showtotalsifcontainhidden, which can be set to 'Show totals including hidden items' which is absolutely crazy. In this case student can not see the hidden grade, he sees this module as if it has not been graded, but his total looks completely random for him (because it includes grades he can not see).
        Hide
        Robert Russo added a comment -

        Please assign Adam Zapletal (azaple1), Robert Russo (rrusso), and Philip Cali (pcali1) to Moodle 2 Gradebook Bugs.

        Show
        Robert Russo added a comment - Please assign Adam Zapletal (azaple1), Robert Russo (rrusso), and Philip Cali (pcali1) to Moodle 2 Gradebook Bugs.
        Hide
        Jean-Daniel Descoteaux added a comment -

        And there is another setting for User report grade_report_user_showtotalsifcontainhidden, which can be set to 'Show totals including hidden items' which is absolutely crazy. In this case student can not see the hidden grade, he sees this module as if it has not been graded, but his total looks completely random for him (because it includes grades he can not see).

        We have exactly this behavior using latest version 2.4.3. It would be nice to clean this eventually.

        Thanks.

        Show
        Jean-Daniel Descoteaux added a comment - And there is another setting for User report grade_report_user_showtotalsifcontainhidden, which can be set to 'Show totals including hidden items' which is absolutely crazy. In this case student can not see the hidden grade, he sees this module as if it has not been graded, but his total looks completely random for him (because it includes grades he can not see). We have exactly this behavior using latest version 2.4.3. It would be nice to clean this eventually. Thanks.
        Hide
        Andrew Davis added a comment -

        This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

        For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        Andrew Davis added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          People

          • Votes:
            4 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated: