Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30179

User report and Grader report are inconsistent for the grade that is hidden. Allow teacher to toggle to/from "user view"

    Details

    • Testing Instructions:
      Hide

      Run behat tests (@gradereport_user)

      1. Create a course, enroll student and a teacher
      2. In that course, create several grade items and categories, hide various ones. We want at least one hidden category, and one hidden item in a visible category.
      3. Give the student a grade in each grade item
      4. In two separate browsers, login as the student and the teacher
      5. As the teacher go to the Course grade settings
      6. Make sure Hide totals if they contain hidden items under User report (very bottom) is set to Hide
      7. Navigate to the user grade report for the course in both courses
      8. In the teacher browser, set the report user to the student
      9. Set View report as to Myself
      10. Confirm all items and totals are visible
      11. Set View report as to User
      12. Compare the student and teacher windows of the user report
      13. Confirm that the same items are visible and not visible between the two, and that the same totals are shown.
      14. Repeat steps 4-13, but with the settings Show totals including hidden and Show totals excluding hidden

      Student permission

      1. Login as an admin
      2. Change the student role to allow the moodle/grade:viewhidden permission
      3. Repeat steps 4-14 of the section above

      Confirm sticky setting

      1. Login as a teacher
      2. Go to a course, then to the user report
      3. Set View user as to Myself
      4. Log out
      5. Log back in as the teacher
      6. Go to a course, then to the user report
      7. Confirm View user as is set to Myself
      Show
      Run behat tests (@gradereport_user) Create a course, enroll student and a teacher In that course, create several grade items and categories, hide various ones. We want at least one hidden category, and one hidden item in a visible category. Give the student a grade in each grade item In two separate browsers, login as the student and the teacher As the teacher go to the Course grade settings Make sure Hide totals if they contain hidden items under User report (very bottom) is set to Hide Navigate to the user grade report for the course in both courses In the teacher browser, set the report user to the student Set View report as to Myself Confirm all items and totals are visible Set View report as to User Compare the student and teacher windows of the user report Confirm that the same items are visible and not visible between the two, and that the same totals are shown. Repeat steps 4-13, but with the settings Show totals including hidden and Show totals excluding hidden Student permission Login as an admin Change the student role to allow the moodle/grade:viewhidden permission Repeat steps 4-14 of the section above Confirm sticky setting Login as a teacher Go to a course, then to the user report Set View user as to Myself Log out Log back in as the teacher Go to a course, then to the user report Confirm View user as is set to Myself
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-30179-master

      Description

      If I am a grader and I decided to hide the grade for one student for an assignment, I can still see it in the Grader report (but the font is gray).
      If I (again as a grader) go to the user report for this user I:

      • CAN see the assignment
      • CAN NOT see any grade, not even gray, in the columns 'Grade', 'Percentage', 'Rank'
      • CAN see the grade in the column 'Letter grade' (I enabled it in settings)
        As a student I don't see this assignment in the user report at all.

      There should be a clear policy, what User report shows if it is viewed by a grader:
      1) it shows the same as Grader report but for a particular user
      or
      2) it shows the same as what this user would see in his User report

      Depending on this policy the hidden grades should be shown or the whole line with module should not be shown at all.


      Regarding 'Rank': there should be also a policy whether to include the hidden grades in rank or not. At the moment they are included, so for other students the rank is calculated as if hidden grades were normal grades. But for student whose grade is hidden, rank is not displayed (although exists)

      The column 'Average' displays the average only for grades that are not hidden. So for other users it looks strange: "Rank 2/4, Average 30.00 (3)"

      So I would suggest that Rank should not include hidden grades

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  24 Vote for this issue
                  Watchers:
                  33 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/16