Moodle
  1. Moodle
  2. MDL-30180

META: Grade-able activity modules should have grade.php and support parameter userid

    Details

    • Type: Task Task
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2
    • Fix Version/s: BACKEND
    • Component/s: Gradebook
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      26069

      Description

      In 2.2 the Gradebook has links under near grade in Grader report and User report.
      Activity modules are strongly encouraged to add file grade.php that has mandatory argument id (module id) and optional arguments userid and itemnumber. File should redirect to the grading page for the whole module or to grading/reviewing of a particular user in this module.

      Some modules add several columns in Grader report (=rows in User report). The different itemnumber is used for each column (row).

      If user does not have grading permission for this module, the parameter userid is ignored and grading of the current user is displayed (this happens when student views User report)

      See implementation for assignments as an example (although itemnumber is not applicable for assignments)

      See attached screenshots (in the bottom of the screenshot you can see a formed link). Note that Grader report may add &gradeid=XXX to the link, where XXX may be empty if no grade exists yet. User report does not have gradeid, but it can be calculated by module if necessary knowing the other arguments

      1. graderreport.png
        42 kB
      2. graderreport2.png
        37 kB
      3. userreport.png
        47 kB

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Looks OK, Marina. Other modules like Forum which do make grades do not have grading pages to link to.

          Show
          Martin Dougiamas added a comment - Looks OK, Marina. Other modules like Forum which do make grades do not have grading pages to link to.
          Hide
          Tim Hunt added a comment -

          I am not sure that you description is really correct:

          "File should redirect to the grading page for the whole module or to grading of a particular user in this module."

          This does not really apply to the quiz. The quiz has already been automatically graded. The reason for clicking on the link in the gradebook is to drill down and see the details of what the student did, not to edit the grades.

          "If user does not have grading permission for this module, the parameter userid is ignored and grading of the current user is displayed" is also not a good description. In the quiz, the logic is "If you can see the quiz reports (of all users) then show that, otherwise go to the quiz view.php page.

          Show
          Tim Hunt added a comment - I am not sure that you description is really correct: "File should redirect to the grading page for the whole module or to grading of a particular user in this module." This does not really apply to the quiz. The quiz has already been automatically graded. The reason for clicking on the link in the gradebook is to drill down and see the details of what the student did, not to edit the grades. "If user does not have grading permission for this module, the parameter userid is ignored and grading of the current user is displayed" is also not a good description. In the quiz, the logic is "If you can see the quiz reports (of all users) then show that, otherwise go to the quiz view.php page.
          Hide
          Tim Hunt added a comment -

          What I would really like to see, by way of documentation, is:

          1. Two annotated screen-grabs of the grader report and user report, showing which links go to which URLs.

          2. Some updated sentences/paragraphs of text, which explain what sort of things those links should go to, that work for all activity modules, not just assignment.

          Show
          Tim Hunt added a comment - What I would really like to see, by way of documentation, is: 1. Two annotated screen-grabs of the grader report and user report, showing which links go to which URLs. 2. Some updated sentences/paragraphs of text, which explain what sort of things those links should go to, that work for all activity modules, not just assignment.
          Hide
          Marina Glancy added a comment -

          Tim, thanks for feedback. I added screenshots and updated description

          Show
          Marina Glancy added a comment - Tim, thanks for feedback. I added screenshots and updated description
          Hide
          Marina Glancy added a comment -

          Before rubric branch (implementing the links from gradebook) is integrated into master it can be found at https://github.com/mudrd8mz/moodle/tree/rubric

          Show
          Marina Glancy added a comment - Before rubric branch (implementing the links from gradebook) is integrated into master it can be found at https://github.com/mudrd8mz/moodle/tree/rubric
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          Michael de Raadt added a comment -

          I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          This is being done as part of a bulk annual clean-up of issues.

          If you still believe this is an issue in supported versions, please create a new issue.

          Show
          Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.
          Hide
          Tim Hunt added a comment -

          This is a META bug with open subtasks, and it is still work doing, so reopening.

          Show
          Tim Hunt added a comment - This is a META bug with open subtasks, and it is still work doing, so reopening.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: