Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Logged in as a student:

      1. Go to the gradebook, click on the link that is the name of a quiz. You should end up at the view.php page for that quiz, which shows you what attempts (if any) you have made.

      Logged in as teacher.

      2. Go to the grader report. Click on the name of a quiz. You should end up at the overview (grades) report for that quiz.

      3. Go to the user report for a user who has attempted the quiz. Click on the name of the quiz. You should be taken to the review page for the quiz attempt that lead to the user getting that score.

      4. Go to the user report for a user who has not attempted the quiz. Click on the name of the quiz. You should be taken to the overview (grades) report for that quiz. (This is not ideal, but there is no better page we could send users too.)

      5. Edit the permissions for the teacher role, so that they do not have mod/quiz:viewreports (but do still have quiz/statistics:view). Repeat 2. and 4. The teacher should now be redirected from the gradebook to the quiz statistics report.

      6. Edit the permissions for the teacher role, and remove all three quiz report capabilities (mod/quiz:viewreports, mod/quiz:grade and quiz/statistics:view). Repeat 2. and 4. and verify the teacher is now redirected to the quiz view.php page.

      7. Repeat 3., for four different quizzes, one set to each of the four different grading methods (first/last/highest/average), and for a user who has multiple quiz attempts. (Or, just change then setting on one quiz). Verify that you are redirected to the 'right' attempt review based on this setting.

      Show
      Logged in as a student: 1. Go to the gradebook, click on the link that is the name of a quiz. You should end up at the view.php page for that quiz, which shows you what attempts (if any) you have made. Logged in as teacher. 2. Go to the grader report. Click on the name of a quiz. You should end up at the overview (grades) report for that quiz. 3. Go to the user report for a user who has attempted the quiz. Click on the name of the quiz. You should be taken to the review page for the quiz attempt that lead to the user getting that score. 4. Go to the user report for a user who has not attempted the quiz. Click on the name of the quiz. You should be taken to the overview (grades) report for that quiz. (This is not ideal, but there is no better page we could send users too.) 5. Edit the permissions for the teacher role, so that they do not have mod/quiz:viewreports (but do still have quiz/statistics:view). Repeat 2. and 4. The teacher should now be redirected from the gradebook to the quiz statistics report. 6. Edit the permissions for the teacher role, and remove all three quiz report capabilities (mod/quiz:viewreports, mod/quiz:grade and quiz/statistics:view). Repeat 2. and 4. and verify the teacher is now redirected to the quiz view.php page. 7. Repeat 3., for four different quizzes, one set to each of the four different grading methods (first/last/highest/average), and for a user who has multiple quiz attempts. (Or, just change then setting on one quiz). Verify that you are redirected to the 'right' attempt review based on this setting.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      26071

      Description

      see parent

        Activity

        Hide
        Tim Hunt added a comment -

        By the way, Marina, are there any docs for the updated grade.php API yet?

        Show
        Tim Hunt added a comment - By the way, Marina, are there any docs for the updated grade.php API yet?
        Hide
        Tim Hunt added a comment -

        The natural thing would be, when you click on a specific grade, to go to the review page for that attempt.

        Except that that does not work, because there may be multiple attempts for each student (or they may not be).

        I suppose the really good logic is:

        1. If userid is set,
        1.1 Look at the quiz grading method (first, last, max or average) and work out which attempt gave them their grade. (In the case of ambiguity - average, or max with two equal marks, choose the later)
        1.2 If they are allowed to see that review at this time, redirect them to it.
        1.3 Otherwise ignore userid and go to 2.
        2. If the user can see the quiz reports, send them to the quiz reports.
        3. Otherwise send them to the view.php page.

        Does that sound like good logic?

        Hopefully, this can be done without duplicating too much code from existing bits of the quiz.

        Show
        Tim Hunt added a comment - The natural thing would be, when you click on a specific grade, to go to the review page for that attempt. Except that that does not work, because there may be multiple attempts for each student (or they may not be). I suppose the really good logic is: 1. If userid is set, 1.1 Look at the quiz grading method (first, last, max or average) and work out which attempt gave them their grade. (In the case of ambiguity - average, or max with two equal marks, choose the later) 1.2 If they are allowed to see that review at this time, redirect them to it. 1.3 Otherwise ignore userid and go to 2. 2. If the user can see the quiz reports, send them to the quiz reports. 3. Otherwise send them to the view.php page. Does that sound like good logic? Hopefully, this can be done without duplicating too much code from existing bits of the quiz.
        Hide
        Marina Glancy added a comment -

        Tim, I think you understood everything perfectly even with my very draft issue description

        I would add to your logic one item

        0. If userid is not set and person has grading permission, view all the grades for this quiz (I guess that is what grade.php already does at the moment). The link without userid appears in the column header in Grader report

        There is absolutely no need to duplicate code, in most cases it is probably just redirection to the correct place within activity module. But really saves time for teachers

        Show
        Marina Glancy added a comment - Tim, I think you understood everything perfectly even with my very draft issue description I would add to your logic one item 0. If userid is not set and person has grading permission, view all the grades for this quiz (I guess that is what grade.php already does at the moment). The link without userid appears in the column header in Grader report There is absolutely no need to duplicate code, in most cases it is probably just redirection to the correct place within activity module. But really saves time for teachers
        Hide
        Tim Hunt added a comment -

        No, that logic should not be 0. It should be 2. where I put it. The teacher can go and look at any user's user report in the gradebook. When they are looking at that, shouldn't the link take them to the same place that the student would go?

        Also, if you read my steps, for example 1.2, that requires complex logic to know whether to do that, or to go on to options 2.

        Show
        Tim Hunt added a comment - No, that logic should not be 0. It should be 2. where I put it. The teacher can go and look at any user's user report in the gradebook. When they are looking at that, shouldn't the link take them to the same place that the student would go? Also, if you read my steps, for example 1.2, that requires complex logic to know whether to do that, or to go on to options 2.
        Hide
        Tim Hunt added a comment -

        OK, ready for peer review. Comments please.

        Show
        Tim Hunt added a comment - OK, ready for peer review. Comments please.
        Hide
        David Mudrak added a comment -
        $userid = required_param('userid', PARAM_INT);
        

        I am not sure about the recent Marina's changes. But my last changes in this area just introduced userid, itemnumber, gradeid and itemid as optional params. When the grade item HEADER was clicked, it still linked to the grade.php with just id (cmid) passed. So, if Marina did not change this (and I hope she didn't), the API for grade.php is something like this:

        • params 'id' and 'itemnumber' are always provided, containing the course module id and the grade itemnumber (the quiz uses itemnumber=0 only as it registers just one grade item per quiz instance)
        • params 'userid' and others are provided only if a particular grade's analysis is requested (the icon next to a grade links there)
        • no other params are passed when grade.php is referenced from the grader report headers
        Show
        David Mudrak added a comment - $userid = required_param('userid', PARAM_INT); I am not sure about the recent Marina's changes. But my last changes in this area just introduced userid, itemnumber, gradeid and itemid as optional params. When the grade item HEADER was clicked, it still linked to the grade.php with just id (cmid) passed. So, if Marina did not change this (and I hope she didn't), the API for grade.php is something like this: params 'id' and 'itemnumber' are always provided, containing the course module id and the grade itemnumber (the quiz uses itemnumber=0 only as it registers just one grade item per quiz instance) params 'userid' and others are provided only if a particular grade's analysis is requested (the icon next to a grade links there) no other params are passed when grade.php is referenced from the grader report headers
        Hide
        Tim Hunt added a comment -

        Oops. Yes, that should be optional_param. I'm glad you are awake.

        Show
        Tim Hunt added a comment - Oops. Yes, that should be optional_param. I'm glad you are awake.
        Hide
        Tim Hunt added a comment -

        Commit amended.

        Show
        Tim Hunt added a comment - Commit amended.
        Hide
        David Mudrak added a comment - - edited

        https://github.com/timhunt/moodle/compare/master...MDL-30182#L1R44 should read

        $attempts = quiz_get_user_attempts($quiz->id, $userid, 'finished', true);
        

        The rest of the patch looks OK to me from the code point of view (I did not test it in action). Thanks Tim.

        Show
        David Mudrak added a comment - - edited https://github.com/timhunt/moodle/compare/master...MDL-30182#L1R44 should read $attempts = quiz_get_user_attempts($quiz->id, $userid, 'finished', true ); The rest of the patch looks OK to me from the code point of view (I did not test it in action). Thanks Tim.
        Hide
        Tim Hunt added a comment -

        You obviously aren't looking very carefully. It says that already (I amended again while you were way.)

        Should I submit this for integration now?

        Show
        Tim Hunt added a comment - You obviously aren't looking very carefully. It says that already (I amended again while you were way.) Should I submit this for integration now?
        Hide
        David Mudrak added a comment -

        Ooops I would swear I reloaded before the comment

        Well, the change is backward compatible so there is no problem with the integration request. However, the changes in gradebook that actually generate these new links were not accepted to the master yet. It might have sense to wait for the rubric branch to land - at least to give testers a chance to test this.

        Show
        David Mudrak added a comment - Ooops I would swear I reloaded before the comment Well, the change is backward compatible so there is no problem with the integration request. However, the changes in gradebook that actually generate these new links were not accepted to the master yet. It might have sense to wait for the rubric branch to land - at least to give testers a chance to test this.
        Hide
        Marina Glancy added a comment - - edited

        Tim, I checked out your patch and tested it over rubric branch.

        1) Coding error detected, it must be fixed by a programmer: optional_param() requires $parname, $default and $type to be specified (parameter: userid)
        More information about this error
        Stack trace:
        line 568 of /lib/moodlelib.php: coding_exception thrown
        line 33 of /mod/quiz/grade.php: call to optional_param()
        Output buffer: Warning: Missing argument 3 for optional_param(), called in /var/www/repositories/rubric/moodle/mod/quiz/grade.php on line 33 and defined in /var/www/repositories/rubric/moodle/lib/moodlelib.php on line 566

        (that's easy to fix)

        2) after I fixed #1:
        Fatal error: Class 'quiz_attempt' not found in /var/www/repositories/rubric/moodle/mod/quiz/grade.php on line 69

        3) So, I added require_once and run it again.

        • Looks ok if userid is specified for user who has already attempted the quiz
        • if userid is specified but there were no attempts from this student, we are redirected to page /mod/quiz/report.php?id=11&mode=overview,
          can there be added a message something like "This student has not made (completed or whatever) any attempts yet"? Because the link is displayed always in the gradebook.
        • the link without userid works fine

        (sorry I accidentally saved comment before I finished typing)

        Show
        Marina Glancy added a comment - - edited Tim, I checked out your patch and tested it over rubric branch. 1) Coding error detected, it must be fixed by a programmer: optional_param() requires $parname, $default and $type to be specified (parameter: userid) More information about this error Stack trace: line 568 of /lib/moodlelib.php: coding_exception thrown line 33 of /mod/quiz/grade.php: call to optional_param() Output buffer: Warning: Missing argument 3 for optional_param(), called in /var/www/repositories/rubric/moodle/mod/quiz/grade.php on line 33 and defined in /var/www/repositories/rubric/moodle/lib/moodlelib.php on line 566 (that's easy to fix) 2) after I fixed #1: Fatal error: Class 'quiz_attempt' not found in /var/www/repositories/rubric/moodle/mod/quiz/grade.php on line 69 3) So, I added require_once and run it again. Looks ok if userid is specified for user who has already attempted the quiz if userid is specified but there were no attempts from this student, we are redirected to page /mod/quiz/report.php?id=11&mode=overview, can there be added a message something like "This student has not made (completed or whatever) any attempts yet"? Because the link is displayed always in the gradebook. the link without userid works fine (sorry I accidentally saved comment before I finished typing)
        Hide
        Marina Glancy added a comment - - edited

        Tim, one more thing. I logged in as a student who has already performed several attempts and looked at his gradebook (which actually is User report).

        • /mod/quiz/grade.php?id=11&userid=1 redirects me to review of one attempt
        • /mod/quiz/grade.php?id=11 redirects me to /mod/quiz/view.php?id=11

        So, there are two comments:

        • New parameter userid should not have changed anything from student's perspective (and after your commit it has changed)
        • view.php?id=XX (if viewed by a student) is an excellent page, it shows the summary of all attempts. It also says what grading method is used and what grade is actually pushed to the gradebook. I think this is the best page to show to both student and grader when they follow the link from gradebook. Is it possible to have the same page shown to a grader, maybe add a userid parameter to view.php?
          Besides, review of one attempt is not good in case of QUIZ_GRADEAVERAGE

        If I logged in as a student who did not perform any attempts yet, the gradebook redirects me to view.php which is fine

        Actually it's very easy to test your changes even without rubric - just add &userid to the link from gradebook and see what happens. Here are all the cases:

        • Grader clicks on the link for the student who already has grade (made attempts)
        • Grader clicks on the link for the student who does not have grade
        • Student who has made an attempt clicks on the link from gradebook
        • Student who has not made any attempts clicks on the link from gradebook
        Show
        Marina Glancy added a comment - - edited Tim, one more thing. I logged in as a student who has already performed several attempts and looked at his gradebook (which actually is User report). /mod/quiz/grade.php?id=11&userid=1 redirects me to review of one attempt /mod/quiz/grade.php?id=11 redirects me to /mod/quiz/view.php?id=11 So, there are two comments: New parameter userid should not have changed anything from student's perspective (and after your commit it has changed) view.php?id=XX (if viewed by a student) is an excellent page, it shows the summary of all attempts. It also says what grading method is used and what grade is actually pushed to the gradebook. I think this is the best page to show to both student and grader when they follow the link from gradebook. Is it possible to have the same page shown to a grader, maybe add a userid parameter to view.php? Besides, review of one attempt is not good in case of QUIZ_GRADEAVERAGE If I logged in as a student who did not perform any attempts yet, the gradebook redirects me to view.php which is fine Actually it's very easy to test your changes even without rubric - just add &userid to the link from gradebook and see what happens. Here are all the cases: Grader clicks on the link for the student who already has grade (made attempts) Grader clicks on the link for the student who does not have grade Student who has made an attempt clicks on the link from gradebook Student who has not made any attempts clicks on the link from gradebook
        Hide
        Marina Glancy added a comment -

        one more use case:

        • Grader clicks on the link under the column header in the Grader report (grade.php without userid). Nothing should change comparing to the current behaviour
        Show
        Marina Glancy added a comment - one more use case: Grader clicks on the link under the column header in the Grader report (grade.php without userid). Nothing should change comparing to the current behaviour
        Hide
        Tim Hunt added a comment -

        Grrr! So, I describe exactly what I am planning to implement, and you say OK, and then I spend time coding that, and you now tell me it is all wrong. That is not helpful.

        (I don't know why I should even be doing thin. You are the ones who are supposed ot be implementing the advanced grading stuff. Well I do know really. You are having to get the advanced grading stuff finished at the last minute, and I was trying to be helpful.)

        Adding a userid argument to the quiz/view.php does not work at all from the point of view of the quiz UI. There would be no way to get at that page (other than from an obscure link in the gradebook). That makes no sense. Note that the review.php UI already includes, at the top, a list of all this students other attempts. You are right that there is no review.php page for students who have not attempted the quiz. I suspect there will be a similar problem in the wiki.

        So, the way it looks right now, there is not way to nicely implement the userid link in the quiz without major changes in the quiz UI (http://docs.moodle.org/dev/Quiz_user_interface_overview), and none of us have time to contemplate that now. Perhaps you should have thought this through in detail before thinking "we need a userid link for our advanced grading stuff in assignment".

        Show
        Tim Hunt added a comment - Grrr! So, I describe exactly what I am planning to implement, and you say OK, and then I spend time coding that, and you now tell me it is all wrong. That is not helpful. (I don't know why I should even be doing thin. You are the ones who are supposed ot be implementing the advanced grading stuff. Well I do know really. You are having to get the advanced grading stuff finished at the last minute, and I was trying to be helpful.) Adding a userid argument to the quiz/view.php does not work at all from the point of view of the quiz UI. There would be no way to get at that page (other than from an obscure link in the gradebook). That makes no sense. Note that the review.php UI already includes, at the top, a list of all this students other attempts. You are right that there is no review.php page for students who have not attempted the quiz. I suspect there will be a similar problem in the wiki. So, the way it looks right now, there is not way to nicely implement the userid link in the quiz without major changes in the quiz UI ( http://docs.moodle.org/dev/Quiz_user_interface_overview ), and none of us have time to contemplate that now. Perhaps you should have thought this through in detail before thinking "we need a userid link for our advanced grading stuff in assignment".
        Hide
        David Mudrak added a comment -

        add a userid parameter to view.php

        My -1 against this anywhere, that would change the whole concept of view.php imho

        Show
        David Mudrak added a comment - add a userid parameter to view.php My -1 against this anywhere, that would change the whole concept of view.php imho
        Hide
        Marina Glancy added a comment -

        Hi, Tim.
        Believe me I have spent a lot of time too trying to make your code work and testing it. And I also could say that I'm not supposed to do it.
        I did't know exactly how the quiz work and what would be the best page to review the student's grade. When I agreed with your algorithm I agreed with logic how to process the userid parameter.

        And again: this change is not part of advanced grading. It is just an improvement of Gradebook and yes, we came out with it very recently. I added Martin as a watcher, so he can say when this issue is due.

        My suggestion to add parameter userid to view.php was prefixed with word "maybe" as you may noticed. Also you (maybe!) could move the code generating that all-attempts-summary page to some other place and call it from both view.php and grade.php. You definitely know better how to do it.

        All I'm trying to say is:

        • the code should be working
        • nothing should be changed if logged in as a student
        • grader shall be able to see where did the grade of particular student come from.
          (And then I added after I looked at it more carefully Since you already have code that displays all attempts summary for a student why not re-using it to show the same to the grader.
        Show
        Marina Glancy added a comment - Hi, Tim. Believe me I have spent a lot of time too trying to make your code work and testing it. And I also could say that I'm not supposed to do it. I did't know exactly how the quiz work and what would be the best page to review the student's grade. When I agreed with your algorithm I agreed with logic how to process the userid parameter. And again: this change is not part of advanced grading. It is just an improvement of Gradebook and yes, we came out with it very recently. I added Martin as a watcher, so he can say when this issue is due. My suggestion to add parameter userid to view.php was prefixed with word "maybe" as you may noticed. Also you (maybe!) could move the code generating that all-attempts-summary page to some other place and call it from both view.php and grade.php. You definitely know better how to do it. All I'm trying to say is: the code should be working nothing should be changed if logged in as a student grader shall be able to see where did the grade of particular student come from. (And then I added after I looked at it more carefully Since you already have code that displays all attempts summary for a student why not re-using it to show the same to the grader.
        Hide
        Martin Dougiamas added a comment -

        OK, there seems to be some miscommunication here. It should be pretty simple.

        mod/xxx/grade.php just needs to redirect users to the best current page for a grader or student. Development of new reports is not in scope here.

        So, all quiz/grade.php needs to do is:

        1) Redirect students to view.php as it is. They'll see the nice summary, yay!

        2) Redirect graders to the best attempt in the quiz reports as Tim has done, and they can always navigate to other attempts from there if they need to.

        That's it!

        If Tim later adds a nice overview of individual users within the reports pages, then he (as the quiz maintainer) can also change the teacher redirect to that (that's why we have grade.php in the module after all), but it's not necessary for now.

        Thanks all!

        Show
        Martin Dougiamas added a comment - OK, there seems to be some miscommunication here. It should be pretty simple. mod/xxx/grade.php just needs to redirect users to the best current page for a grader or student. Development of new reports is not in scope here. So, all quiz/grade.php needs to do is: 1) Redirect students to view.php as it is. They'll see the nice summary, yay! 2) Redirect graders to the best attempt in the quiz reports as Tim has done, and they can always navigate to other attempts from there if they need to. That's it! If Tim later adds a nice overview of individual users within the reports pages, then he (as the quiz maintainer) can also change the teacher redirect to that (that's why we have grade.php in the module after all), but it's not necessary for now. Thanks all!
        Hide
        Tim Hunt added a comment -

        Marina, first, sorry. I was having a bad day, and should not have taken it out on you.

        Martin, that seems about right. Of course, student and grader are not necessarily distinct, if you come from a social-constructivist world, and have edited roles and permissions a lot, but I think the proposed change handles that case.

        https://github.com/timhunt/moodle/compare/master...MDL-30182 has been updated with new logic. I think that works OK. The one case that is not handled very well is the situation when a grade clicks on the link for a specific user who has not attempted the quiz. There is no good page to send the teacher to in this case, so they just end up at the quiz reports. That will have to do for now.

        Show
        Tim Hunt added a comment - Marina, first, sorry. I was having a bad day, and should not have taken it out on you. Martin, that seems about right. Of course, student and grader are not necessarily distinct, if you come from a social-constructivist world, and have edited roles and permissions a lot, but I think the proposed change handles that case. https://github.com/timhunt/moodle/compare/master...MDL-30182 has been updated with new logic. I think that works OK. The one case that is not handled very well is the situation when a grade clicks on the link for a specific user who has not attempted the quiz. There is no good page to send the teacher to in this case, so they just end up at the quiz reports. That will have to do for now.
        Hide
        Tim Hunt added a comment -

        Just amended once more to fix the optional_param snafu that david spotted. I think this is ready for integration now.

        Show
        Tim Hunt added a comment - Just amended once more to fix the optional_param snafu that david spotted. I think this is ready for integration now.
        Hide
        David Mudrak added a comment -

        Looks OK from the code perspective. I did not test it but the overall logic has +1 from me. Thanks Tim.

        Show
        David Mudrak added a comment - Looks OK from the code perspective. I did not test it but the overall logic has +1 from me. Thanks Tim.
        Hide
        Tim Hunt added a comment -

        Submitting for integration then.

        Show
        Tim Hunt added a comment - Submitting for integration then.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Looks ok, hope it works too, integrated!

        Show
        Eloy Lafuente (stronk7) added a comment - Looks ok, hope it works too, integrated!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Really we should start joining these:

        +$cm = get_coursemodule_from_id('quiz', $id, 0, false, MUST_EXIST);
        +$course = $DB->get_record('course', array('id' => $cm->course), '*', MUST_EXIST);
        +$quiz = $DB->get_record('quiz', array('id' => $cm->instance), '*', MUST_EXIST);
        +require_login($course, false, $cm);

        (repeated in thousands of pages, each time more)

        into some:

        list($cm, $course, $activity) = get_all_the_bloody_info_and_require_login('quiz', $id, $autologinguest)

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Really we should start joining these: +$cm = get_coursemodule_from_id('quiz', $id, 0, false, MUST_EXIST); +$course = $DB->get_record('course', array('id' => $cm->course), '*', MUST_EXIST); +$quiz = $DB->get_record('quiz', array('id' => $cm->instance), '*', MUST_EXIST); +require_login($course, false, $cm); (repeated in thousands of pages, each time more) into some: list($cm, $course, $activity) = get_all_the_bloody_info_and_require_login('quiz', $id, $autologinguest) Ciao
        Hide
        Marina Glancy added a comment -

        Tim, I told you already about fatal error in grade.php:
        Fatal error: Class 'quiz_attempt' not found in /var/www/repositories/master/moodle/mod/quiz/grade.php on line 81
        It is still not fixed.

        Why do you keep committing code you did not even execute once?

        Show
        Marina Glancy added a comment - Tim, I told you already about fatal error in grade.php: Fatal error: Class 'quiz_attempt' not found in /var/www/repositories/master/moodle/mod/quiz/grade.php on line 81 It is still not fixed. Why do you keep committing code you did not even execute once?
        Hide
        Marina Glancy added a comment -

        Eloy, I guess there is already a function get_context_info_array()

        $context = get_context_instance(CONTEXT_MODULE, $id);
        list($context, $course, $cm) = get_context_info_array($context->id);
        require_login($course, false, $cm);
        
        Show
        Marina Glancy added a comment - Eloy, I guess there is already a function get_context_info_array() $context = get_context_instance(CONTEXT_MODULE, $id); list($context, $course, $cm) = get_context_info_array($context->id); require_login($course, false , $cm);
        Hide
        Tim Hunt added a comment -

        New commit https://github.com/timhunt/moodle/commit/0850e6301a7abb9b9f2a72cffdb9cc39eeb0e8b6 added to the MDL-30182 branch to fix this.

        Sorry for missing this.

        Show
        Tim Hunt added a comment - New commit https://github.com/timhunt/moodle/commit/0850e6301a7abb9b9f2a72cffdb9cc39eeb0e8b6 added to the MDL-30182 branch to fix this. Sorry for missing this.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        re-integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - re-integrated, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        getting on this (is the last blocking me to push upstream)

        Show
        Eloy Lafuente (stronk7) added a comment - getting on this (is the last blocking me to push upstream)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Passed, all points working as expected, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Passed, all points working as expected, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        U P S T R E A M I Z E D !

        Thanks! Closing...

        Show
        Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Thanks! Closing...

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: