Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37417 Question editing forms improvements
  3. MDL-30185

Reduce height of true/false question true and false feedback edit boxes

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Create or find a true/false question type
      The attribute rows=10 has been added to the textarea of the fields 'feedback for the response true' and 'feedback for the response false'.
      Check id id_feedbacktrue and id_feedbackfalse have rows=10 applied.
      The fields should be the same size as the general feedback field.

      Show
      Create or find a true/false question type The attribute rows=10 has been added to the textarea of the fields 'feedback for the response true' and 'feedback for the response false'. Check id id_feedbacktrue and id_feedbackfalse have rows=10 applied. The fields should be the same size as the general feedback field.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:

      Description

      Make the fields the same size as the general feedback editor. OU bug #1920

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            colchambers Colin Chambers added a comment -

            Fixed for 2.2

            Show
            colchambers Colin Chambers added a comment - Fixed for 2.2
            Hide
            timhunt Tim Hunt added a comment -

            Nice little usability improvement. +1 from me. Thanks Colin.

            Show
            timhunt Tim Hunt added a comment - Nice little usability improvement. +1 from me. Thanks Colin.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks Colin, thats been integrated and is ready for testing.

            Show
            nebgor Aparup Banerjee added a comment - Thanks Colin, thats been integrated and is ready for testing.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks good.

            Thanks Colin

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks good. Thanks Colin Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11