Moodle
  1. Moodle
  2. MDL-30186

Various fields on the question editing forms should be advcheckbox, not checkbox

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.1.3
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      To test this, you need to
      1. create a question with the check-box turned on,
      2. edit the question, and turn off the checkbox.
      3. re-edit the question, to see whether the fact that the checkbox was off has been saved correctly.

      It is sufficient to test this with a matching question. You need to test these three checkboxes:
      a. "Show the number of correct responses" under Feedback "For any partially correct response".
      b. "Clear incorrect responses" under any hint.
      c. "Show the number of correct responses" under any hint.

      Show
      To test this, you need to 1. create a question with the check-box turned on, 2. edit the question, and turn off the checkbox. 3. re-edit the question, to see whether the fact that the checkbox was off has been saved correctly. It is sufficient to test this with a matching question. You need to test these three checkboxes: a. "Show the number of correct responses" under Feedback "For any partially correct response". b. "Clear incorrect responses" under any hint. c. "Show the number of correct responses" under any hint.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      26079

      Description

      Otherwise, there is no way to clear the setting.

        Activity

        Hide
        Tim Hunt added a comment -

        I reviewed all the uses of 'checkbox' in the question types, and am pretty sure I caught all problems.

        Show
        Tim Hunt added a comment - I reviewed all the uses of 'checkbox' in the question types, and am pretty sure I caught all problems.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        aha, so normal ones are not sent if disabled, while the advanced have one "backup hidden" field setting it to off, correct?

        Show
        Eloy Lafuente (stronk7) added a comment - aha, so normal ones are not sent if disabled, while the advanced have one "backup hidden" field setting it to off, correct?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Adrian Greeve added a comment -

        Tested and working.

        Show
        Adrian Greeve added a comment - Tested and working.
        Hide
        Tim Hunt added a comment -

        aha, so normal ones are not sent if disabled, while the advanced have one "backup hidden" field setting it to off, correct?

        Yes.

        Show
        Tim Hunt added a comment - aha, so normal ones are not sent if disabled, while the advanced have one "backup hidden" field setting it to off, correct? Yes.
        Hide
        Tim Hunt added a comment -

        Note that this is causing problems for the calc* qtypes. That is, with these changes, MDL-27045 is now having an effect on the calculated qtype forms

        Show
        Tim Hunt added a comment - Note that this is causing problems for the calc* qtypes. That is, with these changes, MDL-27045 is now having an effect on the calculated qtype forms
        Hide
        Eloy Lafuente (stronk7) added a comment -

        U P S T R E A M I Z E D !

        Thanks! Closing...

        Show
        Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Thanks! Closing...

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: