Moodle

PHPDoc block for clean_param has the wrong varible type for the $type param (moodlelib)

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.5, 2.1.2
  • Fix Version/s: 2.0.6, 2.1.3
  • Component/s: Libraries
  • Labels:

Description

It should be listed as a string, not an integer

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rajesh Taneja added a comment -

Nice pick Jason
Looks Good to me.

Show
Rajesh Taneja added a comment - Nice pick Jason Looks Good to me.
Hide
Permalink
Tim Hunt added a comment -

Obviously, you need a master branch!

Show
Tim Hunt added a comment - Obviously, you need a master branch!
Hide
Permalink
Jason Fowler added a comment -

actually, the master branch is already fixed, there for it doesn't need the master at all ...

Show
Jason Fowler added a comment - actually, the master branch is already fixed, there for it doesn't need the master at all ...
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
Hide
Permalink
Aparup Banerjee added a comment -

Thanks! That's been integrated. passing it too.

Show
Aparup Banerjee added a comment - Thanks! That's been integrated. passing it too.
Hide
Permalink
Aparup Banerjee added a comment -

passing. unless someone wants to hook up phpxref or something to test the phpdoc! (go ahead)

Show
Aparup Banerjee added a comment - passing. unless someone wants to hook up phpxref or something to test the phpdoc! (go ahead)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: