Moodle
  1. Moodle
  2. MDL-30201

Improve delete confirmation when ajax enabled a bit more

    Details

    • Database:
      MySQL
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      26126

      Description

      MDL-14790 has improved the deletion message, but we would like it improved a little bit more?

      We have tweaked our 1.9 code so that it appends the following warning to activities (not resources):

      'NOTE: This will delete all student submissions and any feedback/grades you may have given to them'

      We identify the activities by excluding elements with a class 'resource' or 'label'.

      However Moodle 2 now has different class names for each type of resource (folder, url etc). So it is harder to identify them as new ones could be added in future or with plugins.

      Could we therefore have a similar message for all deletions explaining that if there is associated student data, it will also be lost?

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          That is possible. There are still mechanisms for differentiating modules. Another option could be to create a callback in modules, with a fallback, so that each module could specify its own delete message, if needs be.

          Could you share the change you made in 1.9. As a starting point it could still be useful.

          Show
          Michael de Raadt added a comment - That is possible. There are still mechanisms for differentiating modules. Another option could be to create a callback in modules, with a fallback, so that each module could specify its own delete message, if needs be. Could you share the change you made in 1.9. As a starting point it could still be useful.
          Hide
          Amanda Doughty added a comment -

          I have tested this in 2.3 Dev and the message is still the same

          Show
          Amanda Doughty added a comment - I have tested this in 2.3 Dev and the message is still the same

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: