Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30225

Creating new web service tokens create error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Add a new web service in the admin, and add all functions to this service. Create a token for a user non admin. Check that the error message is not displayed on the token admin page.

      Show
      Add a new web service in the admin, and add all functions to this service. Create a token for a user non admin. Check that the error message is not displayed on the token admin page.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Noticed the following error while testing MDL-30045, to create new token for a student:

      Did you remember to make the first column something unique in your call to get_records? Duplicate value '766' found in column 'id'.
      		 
       
      		 
          line 818 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
      		 
          line 364 of /webservice/lib.php: call to mysqli_native_moodle_database->get_records_sql()
      		 
          line 391 of /webservice/lib.php: call to webservice->get_user_capabilities()
      		 
          line 7550 of /lib/adminlib.php: call to webservice->get_missing_capabilities_by_users()
      		 
          line 1343 of /lib/adminlib.php: call to admin_setting_managewebservicetokens->output_html()
      		 
          line 126 of /admin/settings.php: call to admin_settingpage->output_html()

        Attachments

          Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-31253 META - web service improvements for 2.3

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32458 Verify all the capabilities specified in services.php definitions are checked in code

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-29962 Informing administrator about "required" capabilities to run a web service function

          • Minor - Minor loss of function where workaround is possible
          • Development in progress
          Testing discovered

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-30045 Backport 2.2 changes for login/token.php in 2.1

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jerome Jérôme Mouneyrac
              Reporter:
              rwijaya Rossiani Wijaya
              Peer reviewer:
              Rossiani Wijaya Rossiani Wijaya
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Andrew Davis Andrew Davis
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12