Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29601 AfterburnerTheme Logo Exchange Problem
  3. MDL-30243

Afterburner: Add custom settings for Logo, Footnote and Custom CSS

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      NB: Prior to testing ensure that Theme Designer Mode is enabled.
      1. Select Afterburner theme from Theme selector
      2. Select Afterburner settings page from the list of custom settings pages listed under Themes from the Site Administration/Appearance menu
      3. Check that the title inside the settings page itself says "Afterburner Custom Settings"
      4. Add a URL to a logo image (eg. http://moodlestudio.co.uk/images/testlogo.jpg)
      5. Add some text to the footnote textarea. (eg. Copyright 2011)
      6. Add some CSS to the custom css textarea (eg. .block .header .title h2

      { color: red}

      7. Save settings
      8. Check to see that the Afterburner original logo has been replaced by the image from the URL entered in the settings page.
      9. Check to see that the footnote is present in the left-hand side of the footer.
      10. Check that whatever CSS entered has taken effect.

      Show
      NB: Prior to testing ensure that Theme Designer Mode is enabled. 1. Select Afterburner theme from Theme selector 2. Select Afterburner settings page from the list of custom settings pages listed under Themes from the Site Administration/Appearance menu 3. Check that the title inside the settings page itself says "Afterburner Custom Settings" 4. Add a URL to a logo image (eg. http://moodlestudio.co.uk/images/testlogo.jpg ) 5. Add some text to the footnote textarea. (eg. Copyright 2011) 6. Add some CSS to the custom css textarea (eg. .block .header .title h2 { color: red} 7. Save settings 8. Check to see that the Afterburner original logo has been replaced by the image from the URL entered in the settings page. 9. Check to see that the footnote is present in the left-hand side of the footer. 10. Check that whatever CSS entered has taken effect.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This is Phase 1 of a two phase task to add custom settings to Afterburner

        Gliffy Diagrams

          Activity

          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
          Hide
          lazydaisy Mary Evans added a comment -

          Ciao Eloy,

          After re-basing this I noticed that I had missed off $string['configtitle'= 'Afterburner Custom Settings'; from theme/afterburner/lang/en/theme_afterburner.php.

          Can you tell me the easiest way I can 'edit' this without causing too many problems for myself in GIT?
          Or should I just create a new sub-task and do it as a separate commit?

          Cheers
          Mary

          Show
          lazydaisy Mary Evans added a comment - Ciao Eloy, After re-basing this I noticed that I had missed off $string['configtitle'= 'Afterburner Custom Settings'; from theme/afterburner/lang/en/theme_afterburner.php. Can you tell me the easiest way I can 'edit' this without causing too many problems for myself in GIT? Or should I just create a new sub-task and do it as a separate commit? Cheers Mary
          Hide
          lazydaisy Mary Evans added a comment -

          Just added one more commit to fix the missing configtitle.
          Thanks
          Mary

          Show
          lazydaisy Mary Evans added a comment - Just added one more commit to fix the missing configtitle. Thanks Mary
          Hide
          nebgor Aparup Banerjee added a comment -

          Hi Mary,
          I realise i'm not the best person to review this but SamH is away

          I've one concern bugging me which i don't fully understand, theme/afterburner/settings.php has $settings->add() code block outside of the If ($ADMIN->fulltree) block. is there any specific reason for this? i've seen other themes and other settings have this inside the 'if' block.

          Show
          nebgor Aparup Banerjee added a comment - Hi Mary, I realise i'm not the best person to review this but SamH is away I've one concern bugging me which i don't fully understand, theme/afterburner/settings.php has $settings->add() code block outside of the If ($ADMIN->fulltree) block. is there any specific reason for this? i've seen other themes and other settings have this inside the 'if' block.
          Hide
          lazydaisy Mary Evans added a comment -

          Thanks for spotting that Aparup,

          I had added the last section (Custom CSS) after I had finished the page and forgot to include it within the Admin Tree!!!

          I'll fix and re-submit.
          Thanks!
          Mary

          Show
          lazydaisy Mary Evans added a comment - Thanks for spotting that Aparup, I had added the last section (Custom CSS) after I had finished the page and forgot to include it within the Admin Tree!!! I'll fix and re-submit. Thanks! Mary
          Hide
          nebgor Aparup Banerjee added a comment -

          Thanks Mary, re-opening this now then.

          Show
          nebgor Aparup Banerjee added a comment - Thanks Mary, re-opening this now then.
          Hide
          nebgor Aparup Banerjee added a comment -

          Thank you Mary, this has been integrated into master.

          Show
          nebgor Aparup Banerjee added a comment - Thank you Mary, this has been integrated into master.
          Hide
          nebgor Aparup Banerjee added a comment -

          custom css works! thanks!

          Show
          nebgor Aparup Banerjee added a comment - custom css works! thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days.

          Thanks for the hard work! Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days. Thanks for the hard work! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11