ob_flush is now required: http://php.net/manual/en/function.flush.php

Hi Jerome,

I received the following notice with your patch:
Notice: ob_flush() [ref.outcontrol]: failed to flush buffer. No buffer to flush. in /blocks/community/communitycourse.php on line 113

Without the patch, I didn't receive any notice error.

Attaching screenshot after applying patch.

Fixed and retested on Rosie machine. It works well Sending for integration review.

Hi Jerome,

Could you please add a description to this issue about why you are making this change?
Also have you confirmed that in some circumstances there is output buffering in effect when that code is called, I've had a quick look but could not spot anything.

Cheers
Sam

Adding this to my pile, just waiting on your reply Jerome

Without the change some people don't see a message saying to wait, with it they see it. It depends of your apache configuration.

OK thanks Jerome, I'm not entirely sure what is loading a output buffer however as this is checking the buffer count I don't see any harm in it going in.

Cheers
Sam

Thanks Sam

Works Fine,
Although while searching for download course following error was encountered.

Notice: Undefined property: stdClass::$backupsize in /usr/local/www/moodleintegration/blocks/community/renderer.php on line 273 Call Stack: 0.0033 820464 1. {main}() /usr/local/www/moodleintegration/blocks/community/communitycourse.php:0 4.8348 75246528 2. block_community_renderer->course_list() /usr/local/www/moodleintegration/blocks/community/communitycourse.php:236 

Seems to be related to MDL-28093.

Some changes to Moodle should be milestones in the project by themselves.

This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

Closing as fixed, ciao