Moodle
  1. Moodle
  2. MDL-30259

Add the ability to customize the languages available to the tinymce spellchecker

    Details

    • Testing Instructions:
      Hide

      If the setting is not set, you should see the normally long list of language options if you select the spellchecker from the tinymce menu,

      if you set the admin setting to '+English=en' you should see only 'English' in the spellchecker language list.

      Show
      If the setting is not set, you should see the normally long list of language options if you select the spellchecker from the tinymce menu, if you set the admin setting to '+English=en' you should see only 'English' in the spellchecker language list.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30259-master
    • Rank:
      27415

      Description

      Currently the tinymce spellchecker has a defined list of languages that cannot be easily changed.

      The tinymce list of langugages to spell check could use a settings variable if set.

      Can we add an option to the editor admin settings page to set the list of available languages.

      Using this does not actually install or check that the language is installed!

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for putting that forward, Sam.

        I think we need another setting to disable the TinyMCE spellchecker, which I think should be off by default.

        Show
        Michael de Raadt added a comment - Thanks for putting that forward, Sam. I think we need another setting to disable the TinyMCE spellchecker, which I think should be off by default.
        Hide
        Sam Marshall added a comment -

        Thanks Michael. I reviewed this and am submitting it for integration now we have all the details in place. This may not be the type of minor enhancement/bugfix suitable for 2.2 at this stage, but if not then it could go into 2.3.

        Regarding the option to turn off spellchecker entirely - Rod and I discussed it. We definitely agree but we think that is separate and a larger task, as it should be part of an overall screen to control TinyMCE plugins/buttons (like there used to be in Moodle 1.9 with all the checkboxes). We might be interested in working on that at some point in the future (not currently sure when that might be).

        Show
        Sam Marshall added a comment - Thanks Michael. I reviewed this and am submitting it for integration now we have all the details in place. This may not be the type of minor enhancement/bugfix suitable for 2.2 at this stage, but if not then it could go into 2.3. Regarding the option to turn off spellchecker entirely - Rod and I discussed it. We definitely agree but we think that is separate and a larger task, as it should be part of an overall screen to control TinyMCE plugins/buttons (like there used to be in Moodle 1.9 with all the checkboxes). We might be interested in working on that at some point in the future (not currently sure when that might be).
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks, I think this does not hurt the rest at all, so done.

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks, I think this does not hurt the rest at all, so done.
        Hide
        Rajesh Taneja added a comment -

        Works Great
        Thanks for implementing this, Rod.

        Show
        Rajesh Taneja added a comment - Works Great Thanks for implementing this, Rod.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: