Moodle
  1. Moodle
  2. MDL-30274

mymobile theme - Typo in loginpage variable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
    • Rank:
      32604

      Description

      theme/mymobile/renderer.php has a typo in the loginpage variable.

      I know that the functionality doesn't change by fixing this and that it doesn't actually cause any bugs, but correcting this now should prevent future frustrations

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for working on that.

          Show
          Michael de Raadt added a comment - Thanks for working on that.
          Hide
          Rossiani Wijaya added a comment -

          The patch looks fine.

          The typo occurs on all 2.x version and should probably applied to all versions. I will let the integrator decide on that.

          Also, I find the typo occurs on lib/outputrenderers.php and created new issue (MDL-30291) to fix that.

          Show
          Rossiani Wijaya added a comment - The patch looks fine. The typo occurs on all 2.x version and should probably applied to all versions. I will let the integrator decide on that. Also, I find the typo occurs on lib/outputrenderers.php and created new issue ( MDL-30291 ) to fix that.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Integrated, thanks! (master only)

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Integrated, thanks! (master only)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          passing!

          Show
          Eloy Lafuente (stronk7) added a comment - passing!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Thanks! Closing...

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Thanks! Closing...

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: