Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 2.0.5, 2.1.2, 2.2
-
Component/s: Forum
-
Environment:qa.moodle.net
-
Database:Any
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-30289-master -
Pull Master Diff URL:
Description
This was discovered in MDLQA-1191. When splitting a discussion the following error is displayed:
Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result
line 345 of /lib/pagelib.php: call to debugging()
line 617 of /lib/pagelib.php: call to moodle_page->magic_get_context()
line 1216 of /lib/weblib.php: call to moodle_page->__get()
line 463 of /mod/forum/post.php: call to format_string()
This patch seems to fix it (I'm not totally clear on the mechanics of $PAGE): https://github.com/mackensen/moodle/compare/master...MDL-30289
Gliffy Diagrams
Issue Links
- blocks
-
MDLQA-1191
CLONE - Teachers can split discussions and move discussions between forums in the same course
-
- Passed
-
Activity
Tested in 1.9, 2.0, 2.1
This doesn't effect version 1.9
Code looks good
Thanks this has been integrated. Please test the 2.x STABLE branches. I'm resetting MDLQA-1191 now too (edit : or not resetting, theres still one more issue for that QA test).
tested on all three branches, working as expected
Thanks
Closing as fixed, many thanks for your effort!
Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.
Ciao 
Thanks for being involved in testing and reporting that.
We should be able to clear that up swiftly.