Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30289

Page display issue when splitting a discussion

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Forum
    • Labels:
    • Environment:
      qa.moodle.net

      Description

      This was discovered in MDLQA-1191. When splitting a discussion the following error is displayed:
      Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result
      line 345 of /lib/pagelib.php: call to debugging()
      line 617 of /lib/pagelib.php: call to moodle_page->magic_get_context()
      line 1216 of /lib/weblib.php: call to moodle_page->__get()
      line 463 of /mod/forum/post.php: call to format_string()

      This patch seems to fix it (I'm not totally clear on the mechanics of $PAGE): https://github.com/mackensen/moodle/compare/master...MDL-30289

        Gliffy Diagrams

          Issue Links

            Activity

            cfulton Charles Fulton created issue -
            cfulton Charles Fulton made changes -
            Field Original Value New Value
            Link This issue blocks MDLQA-1191 [ MDLQA-1191 ]
            cfulton Charles Fulton made changes -
            Description This was discovered in MDLQA-1191. When splitting a discussion the following error is displayed:
            Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result
            line 345 of /lib/pagelib.php: call to debugging()
            line 617 of /lib/pagelib.php: call to moodle_page->magic_get_context()
            line 1216 of /lib/weblib.php: call to moodle_page->__get()
            line 463 of /mod/forum/post.php: call to format_string()
            This was discovered in MDLQA-1191. When splitting a discussion the following error is displayed:
            Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result
            line 345 of /lib/pagelib.php: call to debugging()
            line 617 of /lib/pagelib.php: call to moodle_page->magic_get_context()
            line 1216 of /lib/weblib.php: call to moodle_page->__get()
            line 463 of /mod/forum/post.php: call to format_string()

            This patch seems to fix it (I'm not totally clear on the mechanics of $PAGE): https://github.com/mackensen/moodle/compare/master...MDL-30289
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for being involved in testing and reporting that.

            We should be able to clear that up swiftly.

            Show
            salvetore Michael de Raadt added a comment - Thanks for being involved in testing and reporting that. We should be able to clear that up swiftly.
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Priority Minor [ 4 ] Blocker [ 1 ]
            Labels mdlqa triaged
            Assignee Martin Dougiamas [ dougiamas ] moodle.com [ moodle.com ]
            moodle.com moodle.com made changes -
            Labels mdlqa triaged mdlqa patch triaged
            moodle.com moodle.com made changes -
            Assignee moodle.com [ moodle.com ] Adrian Greeve [ abgreeve ]
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested in 1.9, 2.0, 2.1
            This doesn't effect version 1.9

            Show
            abgreeve Adrian Greeve added a comment - Tested in 1.9, 2.0, 2.1 This doesn't effect version 1.9
            abgreeve Adrian Greeve made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            phalacee Jason Fowler made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer phalacee
            Hide
            phalacee Jason Fowler added a comment -

            Code looks good

            Show
            phalacee Jason Fowler added a comment - Code looks good
            phalacee Jason Fowler made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            abgreeve Adrian Greeve made changes -
            Status Development in progress [ 3 ] Open [ 1 ]
            abgreeve Adrian Greeve made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            nebgor Aparup Banerjee made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator nebgor
            Currently in integration Yes [ 10041 ]
            Hide
            nebgor Aparup Banerjee added a comment - - edited

            Thanks this has been integrated. Please test the 2.x STABLE branches. I'm resetting MDLQA-1191 now too (edit : or not resetting, theres still one more issue for that QA test).

            Show
            nebgor Aparup Banerjee added a comment - - edited Thanks this has been integrated. Please test the 2.x STABLE branches. I'm resetting MDLQA-1191 now too (edit : or not resetting, theres still one more issue for that QA test).
            nebgor Aparup Banerjee made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.1.2 [ 10851 ]
            Affects Version/s 2.0.5 [ 10950 ]
            Fix Version/s 2.0.6 [ 11250 ]
            Fix Version/s 2.1.3 [ 11251 ]
            Fix Version/s STABLE backlog [ 10463 ]
            ankit_frenz Ankit Agarwal made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester ankit_frenz
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            tested on all three branches, working as expected
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - tested on all three branches, working as expected Thanks
            ankit_frenz Ankit Agarwal made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Closing as fixed, many thanks for your effort!

            Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 21/Nov/11
            stronk7 Eloy Lafuente (stronk7) made changes -
            Labels mdlqa patch triaged patch triaged

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11