Moodle

../admin/health.php code not working with zlib

Details

  • Testing Instructions:
    1. Turn zlib compression on, on the server your moodle is installed on
    2. Attempt to access ../admin/health.php
  • Workaround:
    Hide

    Disabling zlib on your server through the config.php will allow for the health.php page to be viewed but with errors present.

    Show
    Disabling zlib on your server through the config.php will allow for the health.php page to be viewed but with errors present.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    w51_MDL-30292_m23_health
  • Pull Master Diff URL:

Description

We have confirmed that with zlib file compression turned on that the health.php page is not viewable in Moodle 2.x.x. When zlib compression is turned off the health.php page is accessible.

Here is the list of PHP streams present on sites hosted on our CentOS/Apache/MySQL systems.

Registered PHP Streams: https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this.

I've put it on our backlog and we'll try to get to it as soon as we can.

In the meantime adding more information, such as screenshots even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.

Show
Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can. In the meantime adding more information, such as screenshots even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.
Hide
Permalink
Michael de Raadt added a comment - - edited

Hi, Joseph.

If you think this requires prioritised attention, please add a partner tag.

Show
Michael de Raadt added a comment - - edited Hi, Joseph. If you think this requires prioritised attention, please add a partner tag.
Hide
Permalink
Joseph Jacelone added a comment - - edited

Partner tag added. I thank you, and the rest of the team, for all you help!

Show
Joseph Jacelone added a comment - - edited Partner tag added. I thank you, and the rest of the team, for all you help!
Hide
Permalink
Petr Škoda added a comment -

Thanks a lot for the report!

Show
Petr Škoda added a comment - Thanks a lot for the report!
Hide
Permalink
Sam Hemelryk added a comment -

Hi Petr,

Changes look good and have been integrated on MOODLE_22_STABLE and master.
However by the looks of it this also needs to be fixed in MOODLE_21_STABLE, is that correct?

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Petr, Changes look good and have been integrated on MOODLE_22_STABLE and master. However by the looks of it this also needs to be fixed in MOODLE_21_STABLE, is that correct? Cheers Sam
Hide
Permalink
Petr Škoda added a comment -

Hello, I thought that now with the short release cycle we backport only major things to 2.1.x and only critical+security things to 2.0.x. Ciao

Show
Petr Škoda added a comment - Hello, I thought that now with the short release cycle we backport only major things to 2.1.x and only critical+security things to 2.0.x. Ciao
Hide
Permalink
Petr Škoda added a comment -

In any case feel free to cherry pick it to 2.1.x if you think it is necessary, there should not be any problems apart from the discontinued cookieless mode that is already broken/unsupported.

Show
Petr Škoda added a comment - In any case feel free to cherry pick it to 2.1.x if you think it is necessary, there should not be any problems apart from the discontinued cookieless mode that is already broken/unsupported.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Petr,

I've just been chatting to Eloy about where/when things should be backported.
Presently all issues should be backported to all 2.x branches. When January arrives 20_STABLE is done and we will only be backporting to 21_STABLE, and 22_STABLE.
Of course it always at our own discretion and there may be situations where we choose not to backport.
In this case I have chosen to backport to 21 as well.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Petr, I've just been chatting to Eloy about where/when things should be backported. Presently all issues should be backported to all 2.x branches. When January arrives 20_STABLE is done and we will only be backporting to 21_STABLE, and 22_STABLE. Of course it always at our own discretion and there may be situations where we choose not to backport. In this case I have chosen to backport to 21 as well. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Petr - integrated now

Show
Sam Hemelryk added a comment - Thanks Petr - integrated now
Hide
Permalink
Michael de Raadt added a comment -

Test result: passed. In 2.2 I ran /admin/tool/health/index.php

Show
Michael de Raadt added a comment - Test result: passed. In 2.2 I ran /admin/tool/health/index.php
Hide
Permalink
Joseph Jacelone added a comment -

Going to test this on our machines today. I will let you know the results.

Show
Joseph Jacelone added a comment - Going to test this on our machines today. I will let you know the results.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

Now... disconnect, relax and enjoy the next days, yay!

Closing...ciao

Show
Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: