Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.5, 2.1.2
-
Component/s: Administration, Performance
-
Labels:
-
Testing Instructions:
- Turn zlib compression on, on the server your moodle is installed on
- Attempt to access ../admin/health.php
-
Workaround:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:w51_
MDL-30292_m23_health -
Pull Master Diff URL:
Description
We have confirmed that with zlib file compression turned on that the health.php page is not viewable in Moodle 2.x.x. When zlib compression is turned off the health.php page is accessible.
Here is the list of PHP streams present on sites hosted on our CentOS/Apache/MySQL systems.
Registered PHP Streams: https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip
Gliffy Diagrams
Activity
Hi, Joseph.
If you think this requires prioritised attention, please add a partner tag.
Partner tag added. I thank you, and the rest of the team, for all you help!
Thanks a lot for the report!
Hi Petr,
Changes look good and have been integrated on MOODLE_22_STABLE and master.
However by the looks of it this also needs to be fixed in MOODLE_21_STABLE, is that correct?
Cheers
Sam
Hello, I thought that now with the short release cycle we backport only major things to 2.1.x and only critical+security things to 2.0.x. Ciao
In any case feel free to cherry pick it to 2.1.x if you think it is necessary, there should not be any problems apart from the discontinued cookieless mode that is already broken/unsupported.
Hi Petr,
I've just been chatting to Eloy about where/when things should be backported.
Presently all issues should be backported to all 2.x branches. When January arrives 20_STABLE is done and we will only be backporting to 21_STABLE, and 22_STABLE.
Of course it always at our own discretion and there may be situations where we choose not to backport.
In this case I have chosen to backport to 21 as well.
Cheers
Sam
Thanks Petr - integrated now 
Test result: passed. In 2.2 I ran /admin/tool/health/index.php
Going to test this on our machines today. I will let you know the results.
Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!
Now... disconnect, relax and enjoy the next days, yay!
Closing...ciao
Thanks for reporting this.
I've put it on our backlog and we'll try to get to it as soon as we can.
In the meantime adding more information, such as screenshots even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.