Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30292

../admin/health.php code not working with zlib

    Details

    • Testing Instructions:
      1. Turn zlib compression on, on the server your moodle is installed on
      2. Attempt to access ../admin/health.php
    • Workaround:
      Hide

      Disabling zlib on your server through the config.php will allow for the health.php page to be viewed but with errors present.

      Show
      Disabling zlib on your server through the config.php will allow for the health.php page to be viewed but with errors present.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w51_MDL-30292_m23_health

      Description

      We have confirmed that with zlib file compression turned on that the health.php page is not viewable in Moodle 2.x.x. When zlib compression is turned off the health.php page is accessible.

      Here is the list of PHP streams present on sites hosted on our CentOS/Apache/MySQL systems.

      Registered PHP Streams: https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          In the meantime adding more information, such as screenshots even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can. In the meantime adding more information, such as screenshots even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.
          Hide
          salvetore Michael de Raadt added a comment - - edited

          Hi, Joseph.

          If you think this requires prioritised attention, please add a partner tag.

          Show
          salvetore Michael de Raadt added a comment - - edited Hi, Joseph. If you think this requires prioritised attention, please add a partner tag.
          Hide
          joseph.jacelone Joseph Jacelone added a comment - - edited

          Partner tag added. I thank you, and the rest of the team, for all you help!

          Show
          joseph.jacelone Joseph Jacelone added a comment - - edited Partner tag added. I thank you, and the rest of the team, for all you help!
          Hide
          skodak Petr Skoda added a comment -

          Thanks a lot for the report!

          Show
          skodak Petr Skoda added a comment - Thanks a lot for the report!
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Petr,

          Changes look good and have been integrated on MOODLE_22_STABLE and master.
          However by the looks of it this also needs to be fixed in MOODLE_21_STABLE, is that correct?

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Petr, Changes look good and have been integrated on MOODLE_22_STABLE and master. However by the looks of it this also needs to be fixed in MOODLE_21_STABLE, is that correct? Cheers Sam
          Hide
          skodak Petr Skoda added a comment -

          Hello, I thought that now with the short release cycle we backport only major things to 2.1.x and only critical+security things to 2.0.x. Ciao

          Show
          skodak Petr Skoda added a comment - Hello, I thought that now with the short release cycle we backport only major things to 2.1.x and only critical+security things to 2.0.x. Ciao
          Hide
          skodak Petr Skoda added a comment -

          In any case feel free to cherry pick it to 2.1.x if you think it is necessary, there should not be any problems apart from the discontinued cookieless mode that is already broken/unsupported.

          Show
          skodak Petr Skoda added a comment - In any case feel free to cherry pick it to 2.1.x if you think it is necessary, there should not be any problems apart from the discontinued cookieless mode that is already broken/unsupported.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Petr,

          I've just been chatting to Eloy about where/when things should be backported.
          Presently all issues should be backported to all 2.x branches. When January arrives 20_STABLE is done and we will only be backporting to 21_STABLE, and 22_STABLE.
          Of course it always at our own discretion and there may be situations where we choose not to backport.
          In this case I have chosen to backport to 21 as well.

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Petr, I've just been chatting to Eloy about where/when things should be backported. Presently all issues should be backported to all 2.x branches. When January arrives 20_STABLE is done and we will only be backporting to 21_STABLE, and 22_STABLE. Of course it always at our own discretion and there may be situations where we choose not to backport. In this case I have chosen to backport to 21 as well. Cheers Sam
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Petr - integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Petr - integrated now
          Hide
          salvetore Michael de Raadt added a comment -

          Test result: passed. In 2.2 I ran /admin/tool/health/index.php

          Show
          salvetore Michael de Raadt added a comment - Test result: passed. In 2.2 I ran /admin/tool/health/index.php
          Hide
          joseph.jacelone Joseph Jacelone added a comment -

          Going to test this on our machines today. I will let you know the results.

          Show
          joseph.jacelone Joseph Jacelone added a comment - Going to test this on our machines today. I will let you know the results.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12