Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30305

Selecting a date in the date selector should hide the JS date selector

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.3
    • Component/s: Usability
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Add a new Quiz
      • Under Timing:
        • Enable the Open the quiz date
        • Select the day, month, or year to bring up the calendar selector
      • Choose a date from the selector
        • Confirm that the date selector disappears after the date was selected
      Show
      Open a course Turn editing on Add a new Quiz Under Timing: Enable the Open the quiz date Select the day, month, or year to bring up the calendar selector Choose a date from the selector Confirm that the date selector disappears after the date was selected
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30305-master-1

      Description

      When using the date selector, selecting a date should make the javascript date selector disappear.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for suggesting that.

            Show
            salvetore Michael de Raadt added a comment - Thanks for suggesting that.
            Hide
            amanda.doughty Amanda Doughty added a comment -

            We are finding that you have to click outside of the date selector several times to close it.

            Show
            amanda.doughty Amanda Doughty added a comment - We are finding that you have to click outside of the date selector several times to close it.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            The supplied patch will hide the date selector after selecting a date.

            This won't fix the focus issues I'm afraid but it should make life a little easier.
            In the long run, we need to convert this to use the YUI3 calendar module instead.

            Show
            dobedobedoh Andrew Nicols added a comment - The supplied patch will hide the date selector after selecting a date. This won't fix the focus issues I'm afraid but it should make life a little easier. In the long run, we need to convert this to use the YUI3 calendar module instead.
            Hide
            amanda.doughty Amanda Doughty added a comment -

            Speedy response! Thanks Andrew

            Show
            amanda.doughty Amanda Doughty added a comment - Speedy response! Thanks Andrew
            Hide
            poltawski Dan Poltawski added a comment -

            Third diff url i've fixed!

            Show
            poltawski Dan Poltawski added a comment - Third diff url i've fixed!
            Hide
            poltawski Dan Poltawski added a comment -

            Looks fine, but actually how much work is it going to be to switch to the YUI3 module?

            Show
            poltawski Dan Poltawski added a comment - Looks fine, but actually how much work is it going to be to switch to the YUI3 module?
            Hide
            poltawski Dan Poltawski added a comment -

            Ah, I see you created an issue for that but didn't link it.

            MDL-32917

            Show
            poltawski Dan Poltawski added a comment - Ah, I see you created an issue for that but didn't link it. MDL-32917
            Hide
            poltawski Dan Poltawski added a comment -

            Submitting for integration since we have the 'proper fix' tracked in that other issue.

            Show
            poltawski Dan Poltawski added a comment - Submitting for integration since we have the 'proper fix' tracked in that other issue.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Changes look good thanks guys, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Changes look good thanks guys, this has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            I tested this using Firefox, IE8, Chrome and Safari. I did notice that making the selection from the drop down box doesn't make the date selector disappear, but clicking on the day in the date selector does which is an improvement over what it did before.
            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - I tested this using Firefox, IE8, Chrome and Safari. I did notice that making the selection from the drop down box doesn't make the date selector disappear, but clicking on the day in the date selector does which is an improvement over what it did before. Thanks.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12