Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.2
-
Fix Version/s: 2.1.3
-
Component/s: Accessibility
-
Testing Instructions:
-
Difficulty:Easy
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:w46_
MDL-30308_m22_reqstrict -
Pull Master Diff URL:
-
Rank:32656
Description
type is not specified on lines 981 & 983
...
if (debugging('', DEBUG_DEVELOPER)) {
$code .= '<script src="'.$this->yui3loader->base.'yui/yui-debug.js"></script>';
} else {
$code .= '<script src="'.$this->yui3loader->base.'yui/yui-min.js"></script>';
}
should be...
...
if (debugging('', DEBUG_DEVELOPER)) {
$code .= '<script type="text/javascript" src="'.$this->yui3loader->base.'yui/yui-debug.js"></script>';
} else {
$code .= '<script type="text/javascript" src="'.$this->yui3loader->base.'yui/yui-min.js"></script>';
}
Activity
Thanks for the report and patch!
Show
Petr Škoda
added a comment - Thanks for the report and patch!
To integrators: please cherry pick to 2.1 stable.
Show
Petr Škoda
added a comment - To integrators: please cherry pick to 2.1 stable.
Thanks Petr - this has been integrated now 
Show
Sam Hemelryk
added a comment - Thanks Petr - this has been integrated now
Test passed. Verified in source
Show
Sam Hemelryk
added a comment - Test passed. Verified in source
Closing as fixed, many thanks for your effort!
Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.
Ciao
Show
Eloy Lafuente (stronk7)
added a comment - Closing as fixed, many thanks for your effort!
Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.
Ciao
Thanks for spotting that and suggesting a solution.