Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30308

outputrequirementslib.php breaks xhtml validation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.3
    • Component/s: Accessibility
    • Labels:

      Description

      type is not specified on lines 981 & 983

      ...
              if (debugging('', DEBUG_DEVELOPER)) {
                  $code .= '<script src="'.$this->yui3loader->base.'yui/yui-debug.js"></script>';
              } else {
                  $code .= '<script src="'.$this->yui3loader->base.'yui/yui-min.js"></script>';
              }

      should be...

      ...
              if (debugging('', DEBUG_DEVELOPER)) {
                  $code .= '<script type="text/javascript" src="'.$this->yui3loader->base.'yui/yui-debug.js"></script>';
              } else {
                  $code .= '<script type="text/javascript" src="'.$this->yui3loader->base.'yui/yui-min.js"></script>';
              }

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for spotting that and suggesting a solution.

          Show
          salvetore Michael de Raadt added a comment - Thanks for spotting that and suggesting a solution.
          Hide
          skodak Petr Skoda added a comment -

          Thanks for the report and patch!

          Show
          skodak Petr Skoda added a comment - Thanks for the report and patch!
          Hide
          skodak Petr Skoda added a comment -

          To integrators: please cherry pick to 2.1 stable.

          Show
          skodak Petr Skoda added a comment - To integrators: please cherry pick to 2.1 stable.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Test passed. Verified in source

          Show
          samhemelryk Sam Hemelryk added a comment - Test passed. Verified in source
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Closing as fixed, many thanks for your effort!

          Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11