Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30313

Plagiarism API - add function to display unformatted results

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Plagiarism
    • Labels:
    • Testing Instructions:
      Hide

      This can't easily be tested as the plagiarism plugins don't exist in core and nothing "public" calls these functions yet - this should get tested/viewed by a developer to make sure it looks correct and doesn't cause any CORE regressions.

      Show
      This can't easily be tested as the plagiarism plugins don't exist in core and nothing "public" calls these functions yet - this should get tested/viewed by a developer to make sure it looks correct and doesn't cause any CORE regressions.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      plagiarismbranch

      Description

      support for obtaining plagiarism detection results without
      html formatting - allows better management of results inside custom modules.

        Gliffy Diagrams

          Activity

          Hide
          danmarsden Dan Marsden added a comment -

          single commit.

          Show
          danmarsden Dan Marsden added a comment - single commit.
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for taking care of that, Dan.

          I've assigned you as the Component Lead for Plagiarism, so that no one else can claim your work as their own

          Show
          salvetore Michael de Raadt added a comment - Thanks for taking care of that, Dan. I've assigned you as the Component Lead for Plagiarism, so that no one else can claim your work as their own
          Hide
          danmarsden Dan Marsden added a comment -

          Thanks Michael.

          Show
          danmarsden Dan Marsden added a comment - Thanks Michael.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Dan,

          The changes here look good, however given it is a new feature/improvement of the plaigarism API and we have already entered code freeze I'm not sure if this can go in.
          I've added Eloy here, Eloy can this go in or does it now have to wait until after the release (meaning it has to wait till 2.3?)

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Dan, The changes here look good, however given it is a new feature/improvement of the plaigarism API and we have already entered code freeze I'm not sure if this can go in. I've added Eloy here, Eloy can this go in or does it now have to wait until after the release (meaning it has to wait till 2.3?) Cheers Sam
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited

          It's new and isolated so I don't think this can introduce any regression, but only its own bugs once it begins to be used... so this gets my +0.5.

          requires another +0.5,

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - - edited It's new and isolated so I don't think this can introduce any regression, but only its own bugs once it begins to be used... so this gets my +0.5. requires another +0.5,
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Cool thanks Eloy - I'll give it the other +0.5 (will give it a second look over first still)

          Show
          samhemelryk Sam Hemelryk added a comment - Cool thanks Eloy - I'll give it the other +0.5 (will give it a second look over first still)
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Has been integrated now thanks Dan. Just needs testing

          Show
          samhemelryk Sam Hemelryk added a comment - Has been integrated now thanks Dan. Just needs testing
          Hide
          danmarsden Dan Marsden added a comment -

          thanks Sam/Eloy - it would be useful for us to get this into 2.2 but if we have to wait till 2.3 we'll make a few mods to the existing plugins instead.

          Show
          danmarsden Dan Marsden added a comment - thanks Sam/Eloy - it would be useful for us to get this into 2.2 but if we have to wait till 2.3 we'll make a few mods to the existing plugins instead.
          Hide
          danmarsden Dan Marsden added a comment -

          I wouldn't usually test something I've submitted for integration, but I didn't write the initial patch and this isn't easy for developers to test unless they have a plugin that uses this new function and a plagiarism plugin that implements it.

          Show
          danmarsden Dan Marsden added a comment - I wouldn't usually test something I've submitted for integration, but I didn't write the initial patch and this isn't easy for developers to test unless they have a plugin that uses this new function and a plagiarism plugin that implements it.
          Hide
          danmarsden Dan Marsden added a comment -

          test passes fine - thanks Sam/Eloy

          Show
          danmarsden Dan Marsden added a comment - test passes fine - thanks Sam/Eloy
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Closing as fixed, many thanks for your effort!

          Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11