Moodle
  1. Moodle
  2. MDL-30319

A string is not coherent with its environment (TRIVIAL)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Open the MyMobile settings page from the list of theme names below Themes in Site Administration/Appearance menu.
      2. Check that Mobile theme color swatch drop-down menu options are "Light/Blue" and "Grey" and that Default: is "Light/Blue"

      Show
      1. Open the MyMobile settings page from the list of theme names below Themes in Site Administration/Appearance menu. 2. Check that Mobile theme color swatch drop-down menu options are "Light/Blue" and "Grey" and that Default: is "Light/Blue"
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      32669

      Description

      in mymobile setting I read:

      Mobile theme color swatcht:
      Toggle the color swatch of the theme between grey and light/blue.

      but within the select the only available colors are: light and grey.

      To fix it, simply change $string['colourswatch_desc']
      from
      'Toggle the color swatch of the theme between grey and light/blue.';
      to
      'Toggle the color swatch of the theme between grey and light.';

      in theme/mymobile/lang/en/theme_mymobile.php)

      OR

      $string['light'] = 'Light';
      to
      $string['light'] = 'Light/blue';

      in the same file.

        Activity

        Hide
        Daniele Cordella added a comment -

        I assigned this to you, Helen, thinking you are the right person. If this is not true, please, feel free to re-assign it. Cheers.

        Show
        Daniele Cordella added a comment - I assigned this to you, Helen, thinking you are the right person. If this is not true, please, feel free to re-assign it. Cheers.
        Hide
        Mary Evans added a comment -

        Danielle,

        If you are talking about the $string in lang/en/theme_mymobile.php then this is a THEME issue and I can fix it.

        I'll assign it to me and do this now!
        Cheers
        Mary

        Show
        Mary Evans added a comment - Danielle, If you are talking about the $string in lang/en/theme_mymobile.php then this is a THEME issue and I can fix it. I'll assign it to me and do this now! Cheers Mary
        Hide
        Daniele Cordella added a comment -

        Thanks Mary!
        I didn't know.
        I apologise.

        Show
        Daniele Cordella added a comment - Thanks Mary! I didn't know. I apologise.
        Hide
        Mary Evans added a comment - - edited

        Ecco!

        Anything to do with Themes is either myself or John Stabinger. Actually John could have done this as it his Theme. But he is pretty busy, so I did it.

        Mary

        Show
        Mary Evans added a comment - - edited Ecco! Anything to do with Themes is either myself or John Stabinger. Actually John could have done this as it his Theme. But he is pretty busy, so I did it. Mary
        Hide
        Michael de Raadt added a comment -

        Thanks for working on that, Mary.

        I've added John as a watcher for this issue so he knows what has changed.

        Show
        Michael de Raadt added a comment - Thanks for working on that, Mary. I've added John as a watcher for this issue so he knows what has changed.
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary - this has been integrated now
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary - passed testing

        Show
        Sam Hemelryk added a comment - Thanks Mary - passed testing
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Closing as fixed, many thanks for your effort!

        Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: