Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30327

Block removal should have automatically remove 'config_plugins' settings

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.2
    • 2.2
    • Blocks
    • Any
    • MOODLE_21_STABLE
    • MOODLE_22_STABLE
    • w46_MDL-30327_m22_blockconfig
    • Hide

      Blocks must be coded with specific 'before_delete' function to remove this data themselves.

      Show
      Blocks must be coded with specific 'before_delete' function to remove this data themselves.
    • Hide

      Install a block that uses the config_plugins method of storing global configuration.
      Set some global config data.
      Verify the data is in the config_plugins table.
      Uninstall the block.
      Verify that the data is / is not removed from the config_plugins.

      Note - some blocks may have already installed a 'before_delete' function to avoid this problem. Test should be done with a block that does not explicitly remove its own settings.

      Show
      Install a block that uses the config_plugins method of storing global configuration. Set some global config data. Verify the data is in the config_plugins table. Uninstall the block. Verify that the data is / is not removed from the config_plugins. Note - some blocks may have already installed a 'before_delete' function to avoid this problem. Test should be done with a block that does not explicitly remove its own settings.

    Description

      If a block is using the plugins config method for storing its global configuration values, they are left in the 'config_plugins' table unless code has been specifically provided in the 'before_delete' method to remove them. These should be remove automatically when the block is uninstalled, using the Moodle 'unset_all_config_for_plugin' function. It appears that blocks do not use the same 'uninstall_plugin' function that modules and other plugins do, or this would happen.

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda
              mchurch Mike Churchward
              Sam Hemelryk Sam Hemelryk
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/11