Details

      Description

      Changes made by Chuck to make the LTI module better align with spec.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Chris Scribner added a comment -
            Show
            Chris Scribner added a comment - Code branch is at: https://github.com/scriby/moodle/tree/MDL-30328
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Perhaps we should be passing the imslti conformance tests again (integration.git version).

            Also, did we agree about point B1 and do we have any QA tests for this? I'm adding the qa_tests_required here. Not sure about current status of the associated tests.

            Show
            Eloy Lafuente (stronk7) added a comment - Perhaps we should be passing the imslti conformance tests again (integration.git version). Also, did we agree about point B1 and do we have any QA tests for this? I'm adding the qa_tests_required here. Not sure about current status of the associated tests.
            Hide
            Eloy Lafuente (stronk7) added a comment - - edited

            Hi, just FYI, I've been running the tests available at http://173... with current codebase (I've called the tests "software=Moodle 2.2beta+1w") and everything is passing, yay, but 4.6, 4.7 and 4.8.

            Those tests are about to configure the privacy settings to send only the name (4.6), only the email (4.7) and none of them (4.8).

            I did all the tests with one activity, without relying/inheriting any course/site tool.

            And, after looking, it seems that, the privacy settings at activity are not being saved anymore, so they stay checked always. I think it's a recent regression introduced by this or by MDL-30344.

            Surely that needs review. I've created MDL-30384 to sort it out.

            Finally, I was not able to test section 8 in the test suite because I was running them from private site. But the tests really seem to rock!

            Ciao

            PS: I'm passing this as tested as the tests passed ok and basic usage seems ok too (but the created followup above).

            Show
            Eloy Lafuente (stronk7) added a comment - - edited Hi, just FYI, I've been running the tests available at http://173 ... with current codebase (I've called the tests "software=Moodle 2.2beta+1w") and everything is passing, yay, but 4.6, 4.7 and 4.8. Those tests are about to configure the privacy settings to send only the name (4.6), only the email (4.7) and none of them (4.8). I did all the tests with one activity, without relying/inheriting any course/site tool. And, after looking, it seems that, the privacy settings at activity are not being saved anymore, so they stay checked always. I think it's a recent regression introduced by this or by MDL-30344 . Surely that needs review. I've created MDL-30384 to sort it out. Finally, I was not able to test section 8 in the test suite because I was running them from private site. But the tests really seem to rock! Ciao PS: I'm passing this as tested as the tests passed ok and basic usage seems ok too (but the created followup above).
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Closing as fixed, many thanks for your effort!

            Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao
            Hide
            Tim Barker added a comment -

            LTI regression tests already exist in MDLQA!

            Show
            Tim Barker added a comment - LTI regression tests already exist in MDLQA!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: