Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2, 2.3
    • Fix Version/s: 2.3, Future Dev
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      use filepicker in LTR and RTL (append & lang=he after installthe hebrew lang pack)

      use tinymce in RTL mode too.

      generally test themes in RTL mode and (besides custom menus) report here for further future action.

      Show
      use filepicker in LTR and RTL (append & lang=he after installthe hebrew lang pack) use tinymce in RTL mode too. generally test themes in RTL mode and (besides custom menus) report here for further future action.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      theme_rtl
    • Rank:
      32696

      Description

      Updating ALL themes for RTL languages including swapping sides plus

        Issue Links

          Activity

          Mary Evans created issue -
          Mary Evans made changes -
          Field Original Value New Value
          Assignee Patrick Malley [ ptrkmkl ] Mary Evans [ lazydaisy ]
          Mary Evans made changes -
          Summary RTL Theme changes in Moodle 2.x.x RTL Theme fixes for Moodle 2.x.x
          Hide
          Mary Evans added a comment -

          @Nadav I have added you as a watcher so you can bookmark this page

          @Sam I have just added you as a watcher to offer guidance when you have time

          Thanks
          Mary

          Show
          Mary Evans added a comment - @Nadav I have added you as a watcher so you can bookmark this page @Sam I have just added you as a watcher to offer guidance when you have time Thanks Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          I Think MDL-27516 should also be included as sub-task.
          And there are some useful Moodle 2 rtl pathches on this issue : MDL-22952

          Show
          Nadav Kavalerchik added a comment - @Mary I Think MDL-27516 should also be included as sub-task. And there are some useful Moodle 2 rtl pathches on this issue : MDL-22952
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Labels triaged
          Mary Evans made changes -
          Link This issue has a non-specific relationship to MDL-22952 [ MDL-22952 ]
          Mary Evans made changes -
          Link This issue will be resolved by MDL-29226 [ MDL-29226 ]
          Mary Evans made changes -
          Link This issue will be resolved by MDL-30359 [ MDL-30359 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-21135 [ MDL-21135 ]
          Hide
          Nadav Kavalerchik added a comment -

          Switch block columns when course is in RTL Mode (Hebrew, Arabic, Farsi... languages)

          Show
          Nadav Kavalerchik added a comment - Switch block columns when course is in RTL Mode (Hebrew, Arabic, Farsi... languages)
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-31777 [ MDL-31777 ]
          Mary Evans made changes -
          Assignee Mary Evans [ lazydaisy ] Nadav Kavalerchik [ nadavkav ]
          Nadav Kavalerchik made changes -
          Link This issue is blocked by MDL-32479 [ MDL-32479 ]
          Nadav Kavalerchik made changes -
          Link This issue is blocked by MDL-32479 [ MDL-32479 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32479 [ MDL-32479 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32481 [ MDL-32481 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32488 [ MDL-32488 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32530 [ MDL-32530 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32531 [ MDL-32531 ]
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          I found the following link:http://stackoverflow.com/questions/700802/yui-support-of-rtl-languages
          Do you have any idea if this can be helpful in our case?
          (Since, I am not sure where to apply this in the code)

          Show
          Nadav Kavalerchik added a comment - @Mary I found the following link: http://stackoverflow.com/questions/700802/yui-support-of-rtl-languages Do you have any idea if this can be helpful in our case? (Since, I am not sure where to apply this in the code)
          Hide
          Mary Evans added a comment - - edited

          The only way you can get the menu to work nicely is add renderers.php like the menu in Afterburner. This changes the way the menu is styled, so basically you can add your own id and class selectors. The menu works perfectly in Afterburner when RTL is enabled.

          The function used in Afterburner/renderers.php is from moodle/lib/outputrenderers.php

          Here is that section of code from lib/outputrenderers.php which you may want to experiment with.

           /**
               * Returns the custom menu if one has been set
               *
               * A custom menu can be configured by browsing to
               *    Settings: Administration > Appearance > Themes > Theme settings
               * and then configuring the custommenu config setting as described.
               *
               * @param string $custommenuitems - custom menuitems set by theme instead of global theme settings
               * @return string
               */
              public function custom_menu($custommenuitems = '') {
                  global $CFG;
                  if (empty($custommenuitems) && !empty($CFG->custommenuitems)) {
                      $custommenuitems = $CFG->custommenuitems;
                  }
                  if (empty($custommenuitems)) {
                      return '';
                  }
                  $custommenu = new custom_menu($custommenuitems, current_language());
                  return $this->render_custom_menu($custommenu);
              }
          
              /**
               * Renders a custom menu object (located in outputcomponents.php)
               *
               * The custom menu this method produces makes use of the YUI3 menunav widget
               * and requires very specific html elements and classes.
               *
               * @staticvar int $menucount
               * @param custom_menu $menu
               * @return string
               */
              protected function render_custom_menu(custom_menu $menu) {
                  static $menucount = 0;
                  // If the menu has no children return an empty string
                  if (!$menu->has_children()) {
                      return '';
                  }
                  // Increment the menu count. This is used for ID's that get worked with
                  // in JavaScript as is essential
                  $menucount++;
                  // Initialise this custom menu (the custom menu object is contained in javascript-static
                  $jscode = js_writer::function_call_with_Y('M.core_custom_menu.init', array('custom_menu_'.$menucount));
                  $jscode = "(function(){{$jscode}})";
                  $this->page->requires->yui_module('node-menunav', $jscode);
                  // Build the root nodes as required by YUI
                  $content = html_writer::start_tag('div', array('id'=>'custom_menu_'.$menucount, 'class'=>'yui3-menu yui3-menu-horizontal javascript-disabled'));
                  $content .= html_writer::start_tag('div', array('class'=>'yui3-menu-content'));
                  $content .= html_writer::start_tag('ul');
                  // Render each child
                  foreach ($menu->get_children() as $item) {
                      $content .= $this->render_custom_menu_item($item);
                  }
                  // Close the open tags
                  $content .= html_writer::end_tag('ul');
                  $content .= html_writer::end_tag('div');
                  $content .= html_writer::end_tag('div');
                  // Return the custom menu
                  return $content;
              }
          
              /**
               * Renders a custom menu node as part of a submenu
               *
               * The custom menu this method produces makes use of the YUI3 menunav widget
               * and requires very specific html elements and classes.
               *
               * @see core:renderer::render_custom_menu()
               *
               * @staticvar int $submenucount
               * @param custom_menu_item $menunode
               * @return string
               */
              protected function render_custom_menu_item(custom_menu_item $menunode) {
                  // Required to ensure we get unique trackable id's
                  static $submenucount = 0;
                  if ($menunode->has_children()) {
                      // If the child has menus render it as a sub menu
                      $submenucount++;
                      $content = html_writer::start_tag('li');
                      if ($menunode->get_url() !== null) {
                          $url = $menunode->get_url();
                      } else {
                          $url = '#cm_submenu_'.$submenucount;
                      }
                      $content .= html_writer::link($url, $menunode->get_text(), array('class'=>'yui3-menu-label', 'title'=>$menunode->get_title()));
                      $content .= html_writer::start_tag('div', array('id'=>'cm_submenu_'.$submenucount, 'class'=>'yui3-menu custom_menu_submenu'));
                      $content .= html_writer::start_tag('div', array('class'=>'yui3-menu-content'));
                      $content .= html_writer::start_tag('ul');
                      foreach ($menunode->get_children() as $menunode) {
                          $content .= $this->render_custom_menu_item($menunode);
                      }
                      $content .= html_writer::end_tag('ul');
                      $content .= html_writer::end_tag('div');
                      $content .= html_writer::end_tag('div');
                      $content .= html_writer::end_tag('li');
                  } else {
                      // The node doesn't have children so produce a final menuitem
                      $content = html_writer::start_tag('li', array('class'=>'yui3-menuitem'));
                      if ($menunode->get_url() !== null) {
                          $url = $menunode->get_url();
                      } else {
                          $url = '#';
                      }
                      $content .= html_writer::link($url, $menunode->get_text(), array('class'=>'yui3-menuitem-content', 'title'=>$menunode->get_title()));
                      $content .= html_writer::end_tag('li');
                  }
                  // Return the sub menu
                  return $content;
              }
          
          
          Show
          Mary Evans added a comment - - edited The only way you can get the menu to work nicely is add renderers.php like the menu in Afterburner. This changes the way the menu is styled, so basically you can add your own id and class selectors. The menu works perfectly in Afterburner when RTL is enabled. The function used in Afterburner/renderers.php is from moodle/lib/outputrenderers.php Here is that section of code from lib/outputrenderers.php which you may want to experiment with. /** * Returns the custom menu if one has been set * * A custom menu can be configured by browsing to * Settings: Administration > Appearance > Themes > Theme settings * and then configuring the custommenu config setting as described. * * @param string $custommenuitems - custom menuitems set by theme instead of global theme settings * @ return string */ public function custom_menu($custommenuitems = '') { global $CFG; if (empty($custommenuitems) && !empty($CFG->custommenuitems)) { $custommenuitems = $CFG->custommenuitems; } if (empty($custommenuitems)) { return ''; } $custommenu = new custom_menu($custommenuitems, current_language()); return $ this ->render_custom_menu($custommenu); } /** * Renders a custom menu object (located in outputcomponents.php) * * The custom menu this method produces makes use of the YUI3 menunav widget * and requires very specific html elements and classes. * * @staticvar int $menucount * @param custom_menu $menu * @ return string */ protected function render_custom_menu(custom_menu $menu) { static $menucount = 0; // If the menu has no children return an empty string if (!$menu->has_children()) { return ''; } // Increment the menu count. This is used for ID's that get worked with // in JavaScript as is essential $menucount++; // Initialise this custom menu (the custom menu object is contained in javascript- static $jscode = js_writer::function_call_with_Y('M.core_custom_menu.init', array('custom_menu_'.$menucount)); $jscode = "(function(){{$jscode}})" ; $ this ->page->requires->yui_module('node-menunav', $jscode); // Build the root nodes as required by YUI $content = html_writer::start_tag('div', array('id'=>'custom_menu_'.$menucount, 'class'=>'yui3-menu yui3-menu-horizontal javascript-disabled')); $content .= html_writer::start_tag('div', array('class'=>'yui3-menu-content')); $content .= html_writer::start_tag('ul'); // Render each child foreach ($menu->get_children() as $item) { $content .= $ this ->render_custom_menu_item($item); } // Close the open tags $content .= html_writer::end_tag('ul'); $content .= html_writer::end_tag('div'); $content .= html_writer::end_tag('div'); // Return the custom menu return $content; } /** * Renders a custom menu node as part of a submenu * * The custom menu this method produces makes use of the YUI3 menunav widget * and requires very specific html elements and classes. * * @see core:renderer::render_custom_menu() * * @staticvar int $submenucount * @param custom_menu_item $menunode * @ return string */ protected function render_custom_menu_item(custom_menu_item $menunode) { // Required to ensure we get unique trackable id's static $submenucount = 0; if ($menunode->has_children()) { // If the child has menus render it as a sub menu $submenucount++; $content = html_writer::start_tag('li'); if ($menunode->get_url() !== null ) { $url = $menunode->get_url(); } else { $url = '#cm_submenu_'.$submenucount; } $content .= html_writer::link($url, $menunode->get_text(), array('class'=>'yui3-menu-label', 'title'=>$menunode->get_title())); $content .= html_writer::start_tag('div', array('id'=>'cm_submenu_'.$submenucount, 'class'=>'yui3-menu custom_menu_submenu')); $content .= html_writer::start_tag('div', array('class'=>'yui3-menu-content')); $content .= html_writer::start_tag('ul'); foreach ($menunode->get_children() as $menunode) { $content .= $ this ->render_custom_menu_item($menunode); } $content .= html_writer::end_tag('ul'); $content .= html_writer::end_tag('div'); $content .= html_writer::end_tag('div'); $content .= html_writer::end_tag('li'); } else { // The node doesn't have children so produce a final menuitem $content = html_writer::start_tag('li', array('class'=>'yui3-menuitem')); if ($menunode->get_url() !== null ) { $url = $menunode->get_url(); } else { $url = '#'; } $content .= html_writer::link($url, $menunode->get_text(), array('class'=>'yui3-menuitem-content', 'title'=>$menunode->get_title())); $content .= html_writer::end_tag('li'); } // Return the sub menu return $content; }
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          Thank you for pointing me to the afterburner theme, though i can not figure out what makes the menu work their and not in boxxie (after a copied it into boxxie, as far as i can tell)

          I would like you advise on some other issues:
          I am trying to justify the File Picker's elements to the right and i can not seem to control it by using CSS rules in any of the themes. It only works when i change core YUI files:

          /lib/editor/tinymce/tiny_mce/3.4.9/plugins/advimage/css/advimage.css
          I have added rtl CSS rules that work as i need them to work, but only when placed inside the above file

          body#advimage td[align=left] {text-align: right;}
          .tabs li {float: right;}
          

          /lib/editor/tinymce/tiny_mce/3.4.9/plugins/advimage/image.htm
          Has some hard coded

          <td align="left">

          Which i can override with:

          body#advimage td[align=left] {text-align: right;}

          But i am not sure it is the right way

          Any suggestions?

          Show
          Nadav Kavalerchik added a comment - @Mary Thank you for pointing me to the afterburner theme, though i can not figure out what makes the menu work their and not in boxxie (after a copied it into boxxie, as far as i can tell) I would like you advise on some other issues: I am trying to justify the File Picker's elements to the right and i can not seem to control it by using CSS rules in any of the themes. It only works when i change core YUI files: /lib/editor/tinymce/tiny_mce/3.4.9/plugins/advimage/css/advimage.css I have added rtl CSS rules that work as i need them to work, but only when placed inside the above file body#advimage td[align=left] {text-align: right;} .tabs li { float : right;} /lib/editor/tinymce/tiny_mce/3.4.9/plugins/advimage/image.htm Has some hard coded <td align= "left" > Which i can override with: body#advimage td[align=left] {text-align: right;} But i am not sure it is the right way Any suggestions?
          Hide
          Mary Evans added a comment - - edited

          Hi Nadav,

          If that CSS works like that I don't see any problem with using it, however I think you would need to make this .dir-rtl specific as the code as you have it now would change the way the file picker works in LTR wouldn't it?

          As for the Afterburner menu, that was built into the theme, you can't import that into all the themes as it changes the style of the menu.

          To get it to work in Boxxie you would need to copy over the renderers.php from afterburner and change this line...from this...

          class theme_afterburner_core_renderer extends core_renderer {
          

          to this...

          class theme_boxxie_core_renderer extends core_renderer {
          

          also copy the the custommenu CSS and menu images, and also make the following change to Boxxie/config.php like so...

          $THEME->rendererfactory = 'theme_overridden_renderer_factory';
          

          HTH
          Mary

          Show
          Mary Evans added a comment - - edited Hi Nadav, If that CSS works like that I don't see any problem with using it, however I think you would need to make this .dir-rtl specific as the code as you have it now would change the way the file picker works in LTR wouldn't it? As for the Afterburner menu, that was built into the theme, you can't import that into all the themes as it changes the style of the menu. To get it to work in Boxxie you would need to copy over the renderers.php from afterburner and change this line...from this... class theme_afterburner_core_renderer extends core_renderer { to this... class theme_boxxie_core_renderer extends core_renderer { also copy the the custommenu CSS and menu images, and also make the following change to Boxxie/config.php like so... $THEME->rendererfactory = 'theme_overridden_renderer_factory'; HTH Mary
          Hide
          Nadav Kavalerchik added a comment -

          since there was no .dir-rtl available i used:

          body[dir=rtl]

          in:
          /lib/editor/tinymce/tiny_mce/3.4.9/themes/advanced/skins/o2k7/dialog.css
          Still, i would like to find a better place for the CSS rule since we'll have to re apply it when ever we change tiny_mce version ( which happens all the time )
          Should the editor.css CSS rules be applied over the tiny_mce css files?
          (I have tried to move the CSS there and nothing happens)

          I have extended the core_render and used the rendererfactory override, but still, i can not get the sub menus to show up.

          Show
          Nadav Kavalerchik added a comment - since there was no .dir-rtl available i used: body[dir=rtl] in: /lib/editor/tinymce/tiny_mce/3.4.9/themes/advanced/skins/o2k7/dialog.css Still, i would like to find a better place for the CSS rule since we'll have to re apply it when ever we change tiny_mce version ( which happens all the time ) Should the editor.css CSS rules be applied over the tiny_mce css files? (I have tried to move the CSS there and nothing happens) — I have extended the core_render and used the rendererfactory override, but still, i can not get the sub menus to show up.
          Hide
          Mary Evans added a comment - - edited

          OK...in that case I will look at Boxxie and let you know how I get on. Sounds like you are missing some vital element, unless there is a bug in the system?

          As for the CSS for TinyMCE that you are applying direct to...
          /lib/editor/tinymce/tiny_mce/3.4.9/themes/advanced/skins/o2k7/dialog.css
          have you tried adding this rule in a theme's css file? You can create a new CSS file, call it tinymce.css and add it to the end of the list in the theme config.php and then see if it has any effect? If it works this would be a better way of dealing with the problem.

          Remember always to have Theme Designer Mode enabled in Theme settings page (this stops Moodle caching files) otherwise you will not see any changes with these new css rules or other things like menu renderers etc.

          I'll get back to you later with my findings with Boxxie menu problem.

          Show
          Mary Evans added a comment - - edited OK...in that case I will look at Boxxie and let you know how I get on. Sounds like you are missing some vital element, unless there is a bug in the system? As for the CSS for TinyMCE that you are applying direct to... /lib/editor/tinymce/tiny_mce/3.4.9/themes/advanced/skins/o2k7/dialog.css have you tried adding this rule in a theme's css file? You can create a new CSS file, call it tinymce.css and add it to the end of the list in the theme config.php and then see if it has any effect? If it works this would be a better way of dealing with the problem. Remember always to have Theme Designer Mode enabled in Theme settings page (this stops Moodle caching files) otherwise you will not see any changes with these new css rules or other things like menu renderers etc. I'll get back to you later with my findings with Boxxie menu problem.
          Hide
          Mary Evans added a comment - - edited

          Hi Nadav,

          I tested this yesterday evening and it worked OK in Boxxie theme, so I am not sure what you have done wrong. It was all pretty simple. Did you remove the old CSS for the menu in Boxxie and replace it with the Afterburner menu CSS?

          If you do not remove the old menu CSS that will break the menu.

          I am just wondering now if it might be a good reason to change the menu on some of the themes, this way the RTL menu will also work.

          If you think this is worth a try I could change the menus now and then the fixes for RTL will be easier for you?

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited Hi Nadav, I tested this yesterday evening and it worked OK in Boxxie theme, so I am not sure what you have done wrong. It was all pretty simple. Did you remove the old CSS for the menu in Boxxie and replace it with the Afterburner menu CSS? If you do not remove the old menu CSS that will break the menu. I am just wondering now if it might be a good reason to change the menu on some of the themes, this way the RTL menu will also work. If you think this is worth a try I could change the menus now and then the fixes for RTL will be easier for you? Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary,

          You are right. I messed up the theme with too many changes.
          When i started over from scratch, it worked just fine
          I also managed to make the same changes on other themes as well.
          So it seems a very useful solution to the menu issue.

          The menu overrides are actually disabling the yui3 menu in favor of a simple menu.
          I am considering applying those changes to all themes, only when user switches to RTL mode.
          What do you think?

          Show
          Nadav Kavalerchik added a comment - Hi Mary, You are right. I messed up the theme with too many changes. When i started over from scratch, it worked just fine I also managed to make the same changes on other themes as well. So it seems a very useful solution to the menu issue. The menu overrides are actually disabling the yui3 menu in favor of a simple menu. I am considering applying those changes to all themes, only when user switches to RTL mode. What do you think?
          Hide
          Mary Evans added a comment -

          Well done! You have my +1 for that as this would be the best solution.

          Show
          Mary Evans added a comment - Well done! You have my +1 for that as this would be the best solution.
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32801 [ MDL-32801 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32802 [ MDL-32802 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32803 [ MDL-32803 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32805 [ MDL-32805 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32806 [ MDL-32806 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32808 [ MDL-32808 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32809 [ MDL-32809 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32810 [ MDL-32810 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32811 [ MDL-32811 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32812 [ MDL-32812 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32814 [ MDL-32814 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32815 [ MDL-32815 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32816 [ MDL-32816 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32817 [ MDL-32817 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32818 [ MDL-32818 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32819 [ MDL-32819 ]
          Nadav Kavalerchik made changes -
          Link This issue will be resolved by MDL-32820 [ MDL-32820 ]
          Hide
          Nadav Kavalerchik added a comment -

          OK

          I have created and MDL for each theme with the relevant RTL changes. And linked it here.
          I have tested them, a little bit, on my local development system. They seem ok. but maybe... deep... inside there is some missing tweak that needs to be address as well. So, I separated them into different MDLs. please report any feedback to the relevant MDL.

          All themes can be applied together by using the (diff) branch [theme_rtl]:
          https://github.com/nadavkav/moodle/compare/theme_rtl

          If you are an RTL user and you are anxious to try the themes independently, you can download the themes packed into separate zip file from:
          https://github.com/nadavkav/Moodle2-Hebrew-plugins/tree/master/theme
          (Plus, some more 3rd party RTL themes)

          Enjoy

          Show
          Nadav Kavalerchik added a comment - OK I have created and MDL for each theme with the relevant RTL changes. And linked it here. I have tested them, a little bit, on my local development system. They seem ok. but maybe... deep... inside there is some missing tweak that needs to be address as well. So, I separated them into different MDLs. please report any feedback to the relevant MDL. All themes can be applied together by using the (diff) branch [theme_rtl] : https://github.com/nadavkav/moodle/compare/theme_rtl If you are an RTL user and you are anxious to try the themes independently, you can download the themes packed into separate zip file from: https://github.com/nadavkav/Moodle2-Hebrew-plugins/tree/master/theme (Plus, some more 3rd party RTL themes) Enjoy
          Hide
          Nadav Kavalerchik added a comment -

          Just pushed a new update (based on moodle/master 31-5-2012)
          and merged all those changes on top of it with a new branch named : "wip-MDL-30337-master-rtl_all_themes"
          https://github.com/nadavkav/moodle/tree/wip-MDL-30337-master-rtl_all_themes

          Show
          Nadav Kavalerchik added a comment - Just pushed a new update (based on moodle/master 31-5-2012) and merged all those changes on top of it with a new branch named : "wip- MDL-30337 -master-rtl_all_themes" https://github.com/nadavkav/moodle/tree/wip-MDL-30337-master-rtl_all_themes
          Mary Evans made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/nadavkav/moodle.compare/master...wip-MDL-30337
          Pull from Repository git://github.com/nadavkav/moodle.git
          Fix Version/s MUST FIX FOR 2.3 [ 12158 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Mary Evans made changes -
          Pull Master Diff URL https://github.com/nadavkav/moodle.compare/master...wip-MDL-30337 https://github.com/nadavkav/moodle/compare/master...wip-MDL-30337-master-rtl_all_themes
          Pull Master Branch wip-MDL-30337-master-rtl_all_themes
          Description Updating ALL themes for RTL languages including swapping sides plus
          Priority Minor [ 4 ] Major [ 3 ]
          Mary Evans made changes -
          Link This issue will help resolve MDL-32821 [ MDL-32821 ]
          Aparup Banerjee made changes -
          Integrator nebgor
          Hide
          Aparup Banerjee added a comment -

          Hi Nadav,
          i'm seeing merges @ https://github.com/nadavkav/moodle/compare/wip-MDL-30337-master-rtl_all_themes...master (note the reversed comparison order).

          We need to use git rebase (please do not use git merges or git pulls from moodle.git for development of any patch). you can read how to rebase @ http://docs.moodle.org/dev/Git_for_developers#Rebasing_a_branch

          Show
          Aparup Banerjee added a comment - Hi Nadav, i'm seeing merges @ https://github.com/nadavkav/moodle/compare/wip-MDL-30337-master-rtl_all_themes...master (note the reversed comparison order). We need to use git rebase (please do not use git merges or git pulls from moodle.git for development of any patch). you can read how to rebase @ http://docs.moodle.org/dev/Git_for_developers#Rebasing_a_branch
          Hide
          Nadav Kavalerchik added a comment -

          I actually cherry picked my previous commits into the new branch.
          and got 4 conflicts. so i merged them.

          Can you ignore the merges and accept what you can?
          (And i will start from scratch with all the rest of the changes after you release 2.3)

          Show
          Nadav Kavalerchik added a comment - I actually cherry picked my previous commits into the new branch. and got 4 conflicts. so i merged them. Can you ignore the merges and accept what you can? (And i will start from scratch with all the rest of the changes after you release 2.3)
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Nadav Kavalerchik added a comment -

          Aparup, let's hold the integration a little bit (sorry for the "last minute" request)
          Just saw you integrated some major changes to the file picker and the activity YUI selector which requires major RTL changes in the CSS code of theme/base
          And I found out that the MyMobile theme needs some more tweaking too

          Show
          Nadav Kavalerchik added a comment - Aparup, let's hold the integration a little bit (sorry for the "last minute" request) Just saw you integrated some major changes to the file picker and the activity YUI selector which requires major RTL changes in the CSS code of theme/base And I found out that the MyMobile theme needs some more tweaking too
          Hide
          Mary Evans added a comment - - edited

          @Nadav

          How about we fix each theme separately not as one bit pull.
          I can help with this if you agree.

          First we get Base theme fixed for CSS then we do each theme separately.

          As I see it, it is in the THEME that the major part of the change for RTL occurs, regardless of whether or not Base has the swap side-block regions fix. This way we can pick which themes get done and into Moodle 2.3 we have time, even if only a couple make it.

          This way I can start making changes to Afterburner to percentage layout which will mean at least ONE theme would work in IE7 in Moodle 2.3

          What do you think of this Nadav?

          Show
          Mary Evans added a comment - - edited @Nadav How about we fix each theme separately not as one bit pull. I can help with this if you agree. First we get Base theme fixed for CSS then we do each theme separately. As I see it, it is in the THEME that the major part of the change for RTL occurs, regardless of whether or not Base has the swap side-block regions fix. This way we can pick which themes get done and into Moodle 2.3 we have time, even if only a couple make it. This way I can start making changes to Afterburner to percentage layout which will mean at least ONE theme would work in IE7 in Moodle 2.3 What do you think of this Nadav?
          Hide
          Nadav Kavalerchik added a comment -

          @Mary

          I am considering waiting until 2.3 is out.
          There are too many (major) last minute changes I need to fix.

          If you can take all the RTL fixes related to theme/base and push them into Moodle 2.3 ... that could be great.

          Show
          Nadav Kavalerchik added a comment - @Mary I am considering waiting until 2.3 is out. There are too many (major) last minute changes I need to fix. If you can take all the RTL fixes related to theme/base and push them into Moodle 2.3 ... that could be great.
          Mary Evans made changes -
          Assignee Nadav Kavalerchik [ nadavkav ] Mary Evans [ lazydaisy ]
          Mary Evans made changes -
          Status Waiting for integration review [ 10010 ] Closed [ 6 ]
          Resolution Deferred [ 6 ]
          Mary Evans made changes -
          Resolution Deferred [ 6 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Fix Version/s Future Dev [ 12153 ]
          Hide
          Mary Evans added a comment -

          @Aparup

          I have closed this as differed and now reopened it so that I can get base fixed ready for 2.3 and worry about the others after 2.3 is out and more stable.

          @Nadav

          I'll take on Base theme and apply the changes you have done and get it ready for 2.3
          We can work on the rest later.

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Aparup I have closed this as differed and now reopened it so that I can get base fixed ready for 2.3 and worry about the others after 2.3 is out and more stable. @Nadav I'll take on Base theme and apply the changes you have done and get it ready for 2.3 We can work on the rest later. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Thank you

          Show
          Nadav Kavalerchik added a comment - Thank you
          Hide
          Nadav Kavalerchik added a comment -

          @Mary

          It seems i messed up my "wip-MDL-30337-master-rtl_all_themes" branch on my github account. (It's late, 23:59)
          So please see if you can only merge the last 4 commits (with my penguin icon) from here:
          https://github.com/nadavkav/moodle/commits/wip-MDL-30337-master-rtl_all_themes

          Or just run a diff of what you have locally against my updated branch tree files:
          theme/base/style/core.css
          theme/base/style/filemanager.css

          Show
          Nadav Kavalerchik added a comment - @Mary It seems i messed up my "wip- MDL-30337 -master-rtl_all_themes" branch on my github account. (It's late, 23:59) So please see if you can only merge the last 4 commits (with my penguin icon) from here: https://github.com/nadavkav/moodle/commits/wip-MDL-30337-master-rtl_all_themes Or just run a diff of what you have locally against my updated branch tree files: theme/base/style/core.css theme/base/style/filemanager.css
          Hide
          Mary Evans added a comment -

          Hi,

          Your Moodle.git is older than mine and likely to cause conflicts so I am not going to chance it. However, I have retrieved the files from your github and will look at this again in the morning.

          Show
          Mary Evans added a comment - Hi, Your Moodle.git is older than mine and likely to cause conflicts so I am not going to chance it. However, I have retrieved the files from your github and will look at this again in the morning.
          Hide
          Aparup Banerjee added a comment -

          Thanks for the work here guys.

          @Nadav, i'd suggest rebasing rather than cherry-picking. Its a lot easier when dealing with a large set of commits. The rebase can be continued once conflicts are resolved. Rebasing often (weekly)
          In any case, yes, integrators can cherry-pick the commits if needed.

          Show
          Aparup Banerjee added a comment - Thanks for the work here guys. @Nadav, i'd suggest rebasing rather than cherry-picking. Its a lot easier when dealing with a large set of commits. The rebase can be continued once conflicts are resolved. Rebasing often (weekly) In any case, yes, integrators can cherry-pick the commits if needed.
          Hide
          Nadav Kavalerchik added a comment -

          @Aparup,
          Ok. I will.

          Show
          Nadav Kavalerchik added a comment - @Aparup, Ok. I will.
          Hide
          moodle.com added a comment -

          Apu this has to be in rather soon ...

          Show
          moodle.com added a comment - Apu this has to be in rather soon ...
          Hide
          Nadav Kavalerchik added a comment -

          I have decided to wait until 2.3 is out and only then rebase.

          As far as i know Mary is trying to get the RTL fixes into theme/base, just in time to be integrated into 2.3
          Hope that goes well. which will be my starting point when i rebase all the needed changes i find after 2.3 is out.

          Show
          Nadav Kavalerchik added a comment - I have decided to wait until 2.3 is out and only then rebase. As far as i know Mary is trying to get the RTL fixes into theme/base, just in time to be integrated into 2.3 Hope that goes well. which will be my starting point when i rebase all the needed changes i find after 2.3 is out.
          Hide
          Mary Evans added a comment -

          Nadav

          I am going to set this for Integration and just hope for the best.

          Let HQ decide what they want you to do with it all.

          The BASE theme has not been looked at so I don't know what's happening.

          Show
          Mary Evans added a comment - Nadav I am going to set this for Integration and just hope for the best. Let HQ decide what they want you to do with it all. The BASE theme has not been looked at so I don't know what's happening.
          Hide
          Mary Evans added a comment - - edited

          @Nadav,

          please can you UPDATE your GITHUB and then REBASE this NOW?

          Thanks

          Mary

          Show
          Mary Evans added a comment - - edited @Nadav, please can you UPDATE your GITHUB and then REBASE this NOW? Thanks Mary
          Hide
          Aparup Banerjee added a comment -

          Hi Mary, Hi Nadav,
          i'm a bit confused. MDL-32479 seems to be about the base theme and it is up for integration but it does not contain the commits i'm seeing below.

          looking at https://github.com/nadavkav/moodle/commits/wip-MDL-30337-master-rtl_all_themes , i see commits for MDL-32479 (x3 for theme/base) and MDL-32802 (rtl css fixes for tinymce).

          It seems like you want these commits to get into 2.3 and are having problems with git.
          That can be sorted out, just providing a list of commits would be enough even.

          so say for example :
          https://github.com/nadavkav/moodle/commit/7558d6954f74f0c8567475897a4402be26027b50
          is a url to a commit (note the commit hash), i can reference that commit and pull that into integration if needed.

          At this point i just need to know what are the commit(s) that you want to get into integration from this issue and i can do the rest and help you land it.

          Show
          Aparup Banerjee added a comment - Hi Mary, Hi Nadav, i'm a bit confused. MDL-32479 seems to be about the base theme and it is up for integration but it does not contain the commits i'm seeing below. looking at https://github.com/nadavkav/moodle/commits/wip-MDL-30337-master-rtl_all_themes , i see commits for MDL-32479 (x3 for theme/base) and MDL-32802 (rtl css fixes for tinymce). It seems like you want these commits to get into 2.3 and are having problems with git. That can be sorted out, just providing a list of commits would be enough even. so say for example : https://github.com/nadavkav/moodle/commit/7558d6954f74f0c8567475897a4402be26027b50 is a url to a commit (note the commit hash), i can reference that commit and pull that into integration if needed. At this point i just need to know what are the commit(s) that you want to get into integration from this issue and i can do the rest and help you land it.
          Hide
          Mary Evans added a comment - - edited

          @Aparup

          I have just closed MDL-32479 as I think it is confusing matters, if you think otherwise then reopen it.

          The COMMITS Nadav is trying to get into Moodle 2.3 is for every CORE theme, so all the themes listed above in this issue are all commits in their own right but Nadav has put them all togeter in the one branch.

          Is this what you are asking...or are you just talking about the Base theme?

          Now I am getting confused.

          Show
          Mary Evans added a comment - - edited @Aparup I have just closed MDL-32479 as I think it is confusing matters, if you think otherwise then reopen it. The COMMITS Nadav is trying to get into Moodle 2.3 is for every CORE theme, so all the themes listed above in this issue are all commits in their own right but Nadav has put them all togeter in the one branch. Is this what you are asking...or are you just talking about the Base theme? Now I am getting confused.
          Hide
          Aparup Banerjee added a comment -

          lol this would have been so much easier in chat.

          ok i've tried just using the last 4 commits from Nadav's branch but i've hit a ton of conflicts which will have to be resolved (theme/base/style/filemanager.css), i'll sort that out soon.

          also noting that we will need some tests here to go about testing the changes.

          Show
          Aparup Banerjee added a comment - lol this would have been so much easier in chat. ok i've tried just using the last 4 commits from Nadav's branch but i've hit a ton of conflicts which will have to be resolved (theme/base/style/filemanager.css), i'll sort that out soon. also noting that we will need some tests here to go about testing the changes.
          Hide
          Mary Evans added a comment -

          I did wonder if it would be easier to do each theme in turn under it's own MDL as Nadav as them in the above list? Providing BASE theme is done first, then each theme could be added in turn afterwards.

          In fact it might be better if I added those four other commits for BASE theme to MDL-32479 and then that would see BASE theme safe in Moodle 2.3 then we could follow it with CANVAS theme and then the rest of the other themes. That way there would be less chance of conficts.

          Show
          Mary Evans added a comment - I did wonder if it would be easier to do each theme in turn under it's own MDL as Nadav as them in the above list? Providing BASE theme is done first, then each theme could be added in turn afterwards. In fact it might be better if I added those four other commits for BASE theme to MDL-32479 and then that would see BASE theme safe in Moodle 2.3 then we could follow it with CANVAS theme and then the rest of the other themes. That way there would be less chance of conficts.
          Hide
          Aparup Banerjee added a comment -

          i've just added Barbara and Marina here as they've been working on the filemanager recently.

          Show
          Aparup Banerjee added a comment - i've just added Barbara and Marina here as they've been working on the filemanager recently.
          Hide
          Aparup Banerjee added a comment -

          just to be clear these are the 4 commits, Nadav mentioned, that we need for core:

          1) https://github.com/nadavkav/moodle/commit/7558d6954f74f0c8567475897a4402be26027b50 - this cherry-picks cleanly.

          2) https://github.com/nadavkav/moodle/commit/b7ffb75c924f22b925f9f66dd94cbe3fae48fe33 - this cherry-picks cleanly.

          3) https://github.com/nadavkav/moodle/commit/3a3314998043e45014496ab728afc067a095beb2 - attempting to cherry-pick this is currently conflicting with lots of filemanager css changes.

          Marina, Barbara, if you could look at the conflicts here, you might be able to sort them out faster and better than me.

          git-repo : git://github.com/nebgor/moodle.git
          branch : MDL-30337-picky

          4) https://github.com/nadavkav/moodle/commit/274b52359d9ef3036de33d11aa75eb5cc4deef7a - yet to be picked.

          Show
          Aparup Banerjee added a comment - just to be clear these are the 4 commits, Nadav mentioned, that we need for core: 1) https://github.com/nadavkav/moodle/commit/7558d6954f74f0c8567475897a4402be26027b50 - this cherry-picks cleanly. 2) https://github.com/nadavkav/moodle/commit/b7ffb75c924f22b925f9f66dd94cbe3fae48fe33 - this cherry-picks cleanly. 3) https://github.com/nadavkav/moodle/commit/3a3314998043e45014496ab728afc067a095beb2 - attempting to cherry-pick this is currently conflicting with lots of filemanager css changes. Marina, Barbara, if you could look at the conflicts here, you might be able to sort them out faster and better than me. git-repo : git://github.com/nebgor/moodle.git branch : MDL-30337 -picky 4) https://github.com/nadavkav/moodle/commit/274b52359d9ef3036de33d11aa75eb5cc4deef7a - yet to be picked.
          Hide
          Aparup Banerjee added a comment -

          just working with Barbara now on this.

          Show
          Aparup Banerjee added a comment - just working with Barbara now on this.
          Hide
          Martin Dougiamas added a comment -

          Regarding 2.3, and the very very short timeframe we have, my +1 if people here are sure that all new CSS is restricted to ONLY RTL (ie there is no chance of regressions in LTR).

          Otherwise from what I was told people can't use our standard themes in RTL at all, so surely this can only improve things.

          Show
          Martin Dougiamas added a comment - Regarding 2.3, and the very very short timeframe we have, my +1 if people here are sure that all new CSS is restricted to ONLY RTL (ie there is no chance of regressions in LTR). Otherwise from what I was told people can't use our standard themes in RTL at all, so surely this can only improve things.
          Hide
          Aparup Banerjee added a comment -

          moving this into review while working out some conflicts.
          also adding some commits more commits along the way to spruce up the RTL filepicker and manager

          Show
          Aparup Banerjee added a comment - moving this into review while working out some conflicts. also adding some commits more commits along the way to spruce up the RTL filepicker and manager
          Aparup Banerjee made changes -
          Status Reopened [ 4 ] Waiting for integration review [ 10010 ]
          Aparup Banerjee made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Currently in integration Yes [ 10041 ]
          Hide
          Mary Evans added a comment -

          I tried to rebase MDL-32479, but also got conflicts with filmanager.css.

          Anyway, the changes I made to filemanager.css where just cosmetic, and can be done as a separate commit unless Barbara wants to make the same changes while she is still working on that file?

          Show
          Mary Evans added a comment - I tried to rebase MDL-32479 , but also got conflicts with filmanager.css. Anyway, the changes I made to filemanager.css where just cosmetic, and can be done as a separate commit unless Barbara wants to make the same changes while she is still working on that file?
          Hide
          Aparup Banerjee added a comment -

          ok i've got
          git-repo : git://github.com/nebgor/moodle.git
          branch : MDL-30337
          diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337

          only .dir-rtl changes are up for more review

          i've added a commit that fixes a number of things to the RTL ontop of Nadav's fixes. it seems to be usable at this point. there is still the one nagging things about the filepicker' fp-pathbar in rtl that i didn't fix (with lots of folder it wraps but touches the above paths just a bit , fixes welcome) but i figured its very usable now.

          i'd done work on this so reassigning to another integrator.

          Show
          Aparup Banerjee added a comment - ok i've got git-repo : git://github.com/nebgor/moodle.git branch : MDL-30337 diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337 only .dir-rtl changes are up for more review i've added a commit that fixes a number of things to the RTL ontop of Nadav's fixes. it seems to be usable at this point. there is still the one nagging things about the filepicker' fp-pathbar in rtl that i didn't fix (with lots of folder it wraps but touches the above paths just a bit , fixes welcome) but i figured its very usable now. i'd done work on this so reassigning to another integrator.
          Nadav Kavalerchik made changes -
          Hide
          Nadav Kavalerchik added a comment -

          just noticed the "git pull diff url" was pointing to a messed up branch. and changed it back to the original theme_rtl branch.

          @Aparup, Please see if you can add all the other commits (https://github.com/nadavkav/moodle/commits/theme_rtl) which are available now from github. Even, cherry picking them could be very (very) helpful

          Thanks you all for the help. (Sorry I am too busy to jump in and help, but i promise to fix all the leftover RTL issues after 2.3 is out)

          Show
          Nadav Kavalerchik added a comment - just noticed the "git pull diff url" was pointing to a messed up branch. and changed it back to the original theme_rtl branch. @Aparup, Please see if you can add all the other commits ( https://github.com/nadavkav/moodle/commits/theme_rtl ) which are available now from github. Even, cherry picking them could be very (very) helpful Thanks you all for the help. (Sorry I am too busy to jump in and help, but i promise to fix all the leftover RTL issues after 2.3 is out)
          Aparup Banerjee made changes -
          Status Integration review in progress [ 10004 ] Waiting for integration review [ 10010 ]
          Dan Poltawski made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator nebgor poltawski
          Hide
          Dan Poltawski added a comment -

          Hi,

          I'm going to integrate the things from Apus branch.

          Nadav, i'm afraid its just too close to release so just need to make the first step which has been reviewed first. Else we'll miss the boat for everything.

          Show
          Dan Poltawski added a comment - Hi, I'm going to integrate the things from Apus branch. Nadav, i'm afraid its just too close to release so just need to make the first step which has been reviewed first. Else we'll miss the boat for everything.
          Hide
          Nadav Kavalerchik added a comment -

          Dan, sure. no problem. (i knew that) just wanted the fix the bad git pull diff url.

          Show
          Nadav Kavalerchik added a comment - Dan, sure. no problem. (i knew that) just wanted the fix the bad git pull diff url.
          Hide
          Aparup Banerjee added a comment -

          alrighty, looking at the new (to me) theme_rtl branch and picking

          Show
          Aparup Banerjee added a comment - alrighty, looking at the new (to me) theme_rtl branch and picking
          Hide
          Mary Evans added a comment -

          That branch is new to me too!

          I really am wondering if it would be simpler to split this up so that each theme has it's own branch, rather than one branch with all those commits, which I suspet has a greater chance of conflicting with something. At least if they were separate it would be easier to contain.

          I think I am talking myself into a job.

          By the way Aparup I'am logged into developer chat.

          Show
          Mary Evans added a comment - That branch is new to me too! I really am wondering if it would be simpler to split this up so that each theme has it's own branch, rather than one branch with all those commits, which I suspet has a greater chance of conflicting with something. At least if they were separate it would be easier to contain. I think I am talking myself into a job. By the way Aparup I'am logged into developer chat.
          Dan Poltawski made changes -
          Integrator poltawski nebgor
          Hide
          Aparup Banerjee added a comment -

          ok i've looked through all those commits.

          all the custom menu's needed for rtl , really i think that RTL support is part of core and shouldn't require themes to have to implement it themselves.
          There must be a way to let themes handle RTL more easily but at this point i don't know . The custom menu's seem too standardized to be implemented everywhere RTL needs tweaks.

          the custom menu's will have to be tested throughly in all themes LTR and RTL just to be extra cautious at this time (especially for themes with renderers already - Anomaly). i had tested some and saw some quirks with normal LTR and don't think they should go in when custom menu can break like that. Feel free to fix that up :

          so due to quirks seen with custom menu i'm not integrating this :
          git-repo : git://github.com/nebgor/moodle.git
          branch : MDL-30337_custom_menus_risk_taken
          diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337_custom_menus_risk_taken

          instead i'm taking ths safer route and integrating this (only RTL changes - & not affecting LTR) :
          git-repo : git://github.com/nebgor/moodle.git
          branch : MDL-30337_no_risk
          diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337_no_risk

          Show
          Aparup Banerjee added a comment - ok i've looked through all those commits. all the custom menu's needed for rtl , really i think that RTL support is part of core and shouldn't require themes to have to implement it themselves. There must be a way to let themes handle RTL more easily but at this point i don't know . The custom menu's seem too standardized to be implemented everywhere RTL needs tweaks. the custom menu's will have to be tested throughly in all themes LTR and RTL just to be extra cautious at this time (especially for themes with renderers already - Anomaly). i had tested some and saw some quirks with normal LTR and don't think they should go in when custom menu can break like that. Feel free to fix that up : so due to quirks seen with custom menu i'm not integrating this : git-repo : git://github.com/nebgor/moodle.git branch : MDL-30337 _custom_menus_risk_taken diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337_custom_menus_risk_taken instead i'm taking ths safer route and integrating this (only RTL changes - & not affecting LTR) : git-repo : git://github.com/nebgor/moodle.git branch : MDL-30337 _no_risk diff : https://github.com/nebgor/moodle/compare/mistress...MDL-30337_no_risk
          Aparup Banerjee made changes -
          Testing Instructions use filepicker in LTR and RTL (append & lang=he after installthe hebrew lang pack)

          use tinymce in RTL mode too.

          generally test themes in RTL mode and (besides custom menus) report here for further future action.
          Hide
          Aparup Banerjee added a comment -

          ok, I've integrated that into master and it seems to be working fine for me. much better at least!

          thanks for all the effort here.

          I agree with Mary in that the rest of the commits should be handled seperately . Please lets try to group those (remaining) commits according to the issues created for it.

          ps: really don't know why we're resorting to custom menus for RTL needs. I'll drop Sam Hemelryk a line here about this.

          Show
          Aparup Banerjee added a comment - ok, I've integrated that into master and it seems to be working fine for me. much better at least! thanks for all the effort here. I agree with Mary in that the rest of the commits should be handled seperately . Please lets try to group those (remaining) commits according to the issues created for it. ps: really don't know why we're resorting to custom menus for RTL needs. I'll drop Sam Hemelryk a line here about this.
          Aparup Banerjee made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.3 [ 10657 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s MUST FIX FOR 2.3 [ 12158 ]
          Aparup Banerjee made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester nebgor
          Hide
          Aparup Banerjee added a comment -

          passing - this works for me.

          noting: there are RTL issues with the other themes which have issues for them already.

          Show
          Aparup Banerjee added a comment - passing - this works for me. noting: there are RTL issues with the other themes which have issues for them already.
          Aparup Banerjee made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been spread to every git and cvs repository out there, just in time to roll Moodle 2.3beta!

          Thanks! Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been spread to every git and cvs repository out there, just in time to roll Moodle 2.3beta! Thanks! Closing, ciao
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 18/Jun/12
          Hide
          Mary Evans added a comment - - edited

          Thanks Aparup,

          Your comments about the Custom Menu for RTL, the reason Nadav did all these changes was because Martin was not prepared to introduce a new theme as a parent to deal with RTL languages. His comments were on the lines of, "...if Base is not right then fix it..." And so here we are with the fixes and there are TOO many.

          One theme could have done all of this and been better all round for Moodle, IE7 & RTL.

          I feel so utterly sorry for Nadav as he has worked so hard on this.

          Show
          Mary Evans added a comment - - edited Thanks Aparup, Your comments about the Custom Menu for RTL, the reason Nadav did all these changes was because Martin was not prepared to introduce a new theme as a parent to deal with RTL languages. His comments were on the lines of, "...if Base is not right then fix it..." And so here we are with the fixes and there are TOO many. One theme could have done all of this and been better all round for Moodle, IE7 & RTL. I feel so utterly sorry for Nadav as he has worked so hard on this.
          Hide
          Aparup Banerjee added a comment -

          Hi Mary,
          I'll speak to SamH soon as he knows this area more.
          I can appreciate that base needs to be fixed. Actually I'm thinking an even deeper layer at the renderers need to support rtl switching to reduces regressions and redefining layouts entirely. But that's surely a project for later, Nadav's commits may yet get into master, but there are quirks that need to be worked out first.

          Hence my agreement to work on the custom menus stuff within the theme's issue.

          • I've seen issues with the shadow moving out away from the menu bar and small stuff like that that will need to be refined for each theme.
          Show
          Aparup Banerjee added a comment - Hi Mary, I'll speak to SamH soon as he knows this area more. I can appreciate that base needs to be fixed. Actually I'm thinking an even deeper layer at the renderers need to support rtl switching to reduces regressions and redefining layouts entirely. But that's surely a project for later, Nadav's commits may yet get into master, but there are quirks that need to be worked out first. Hence my agreement to work on the custom menus stuff within the theme's issue. I've seen issues with the shadow moving out away from the menu bar and small stuff like that that will need to be refined for each theme.
          Hide
          Mary Evans added a comment -

          Thanks for all your help with this project Aparup, at least some of the fixes are getting into master.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Thanks for all your help with this project Aparup, at least some of the fixes are getting into master. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Although it is nice to see something positive coming out of all this work...
          I feel that if somebody can fix the RTL support on a much lower level (like Mary suggested), that would be great.
          I imagine i would be much more elegant.

          It seems to me that the block column switch should be handled on a much lower api level
          and that the YUI3 lack of RTL support should be addressed too.

          With a personal note for the future development:
          I know that you all (Moodle HQ) have probably other important issues on your schedule, but, I think you should try to make some room for RTL support issues too. At earlier stages of the development of each major release. These issues are on the tracker for a very long time. and they are not minor issues to the RTL community.

          Thank you very very much (Mary, Aparup, Eloy, Dan) for helping these issues get into Moodle 2.3

          Show
          Nadav Kavalerchik added a comment - Although it is nice to see something positive coming out of all this work... I feel that if somebody can fix the RTL support on a much lower level (like Mary suggested), that would be great. I imagine i would be much more elegant. It seems to me that the block column switch should be handled on a much lower api level and that the YUI3 lack of RTL support should be addressed too. With a personal note for the future development: I know that you all (Moodle HQ) have probably other important issues on your schedule, but, I think you should try to make some room for RTL support issues too. At earlier stages of the development of each major release. These issues are on the tracker for a very long time. and they are not minor issues to the RTL community. Thank you very very much (Mary, Aparup, Eloy, Dan) for helping these issues get into Moodle 2.3
          Hide
          Mary Evans added a comment -

          Nadav,

          I am just about to release the RTL theme we were working on, as a Moodle 2.3 theme in the plugins database and also on my github. I have added custom menu renderer, some custom settings which will allow Admins to customise the whole of the header and footer, and also be able to add some custom CSS, as well as define the custommenu in the theme itself. The latter being a new feature in Moodle 2.3 added by Dan Marsden.

          We are getting there...slowly, slowly...

          We have another week!

          I'll try and fix Afterburner, at least we know the menu works in that theme in RTL.
          Cheers,
          Mary

          Show
          Mary Evans added a comment - Nadav, I am just about to release the RTL theme we were working on, as a Moodle 2.3 theme in the plugins database and also on my github. I have added custom menu renderer, some custom settings which will allow Admins to customise the whole of the header and footer, and also be able to add some custom CSS, as well as define the custommenu in the theme itself. The latter being a new feature in Moodle 2.3 added by Dan Marsden. We are getting there...slowly, slowly... We have another week! I'll try and fix Afterburner, at least we know the menu works in that theme in RTL. Cheers, Mary
          Hide
          Aparup Banerjee added a comment -

          Nadav,
          i totally hear you on 'RTL support on a lower level', its exactly what i was thinking when looking through your commits.
          This is new to me but i feel i get the pressing need here and I've spoken to Sam who has been feeling these issues for awhile.
          I'll be raising this to MD to try and get more support here so there is a proper and more structured way to do implement RTL support in future.

          Show
          Aparup Banerjee added a comment - Nadav, i totally hear you on 'RTL support on a lower level', its exactly what i was thinking when looking through your commits. This is new to me but i feel i get the pressing need here and I've spoken to Sam who has been feeling these issues for awhile. I'll be raising this to MD to try and get more support here so there is a proper and more structured way to do implement RTL support in future.
          Hide
          Aparup Banerjee added a comment - - edited

          note: added commit removing css affecting LTR (missed that totally) - good catch by Rajesh in MDL-33830.

          Show
          Aparup Banerjee added a comment - - edited note: added commit removing css affecting LTR (missed that totally) - good catch by Rajesh in MDL-33830 .

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: