Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30354

LTI 2.2 beta - B27 - locallib changes

    Details

      Description

      From Eloy

      1. get_string('no_' . $id, 'lti') ??
      2. lti_get_url_thumbprint(): Why is doing that with "www" part of the hostname?
      3. review lti_filter_get_types() uses, missing $course param
      4. lti_filter_print_types() unused? Also it included old output code (harcoded paths to icons, echos...) would be great to update as much as possible to current output stuff.
      5. $type needs use of new stdClass(), cannot be constructed implicitly.
      lti_post_launch_html() cannot it build that form in another way. Are all the inserted values (endpoint/params...) safe/encoded enough?

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            scriby Chris Scribner added a comment -

            1. That's how it works. The localization token is no_lti_configured, no_lti_pending, etc.
            2. It takes off the www to match user entered URLS with tool providers. For example, www.tool.com/resource=1500 will match a tool provider configured for tool.com.
            3. I couldn't find any such calls (maybe you fixed it already)?
            4. Not used. I removed it.
            5. I think I found the line of code you were referring to and added $type = new stdClass()
            6. I'm not aware of any problems here.

            Show
            scriby Chris Scribner added a comment - 1. That's how it works. The localization token is no_lti_configured, no_lti_pending, etc. 2. It takes off the www to match user entered URLS with tool providers. For example, www.tool.com/resource=1500 will match a tool provider configured for tool.com. 3. I couldn't find any such calls (maybe you fixed it already)? 4. Not used. I removed it. 5. I think I found the line of code you were referring to and added $type = new stdClass() 6. I'm not aware of any problems here.
            Hide
            scriby Chris Scribner added a comment -
            Show
            scriby Chris Scribner added a comment - Code is in branch: https://github.com/scriby/moodle/tree/MDL-30354
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I've tested basic edition of activity and tool and launch and seems to be working ok.

            PS: Be careful with incorrect whitespace here and there.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I've tested basic edition of activity and tool and launch and seems to be working ok. PS: Be careful with incorrect whitespace here and there.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Closing as fixed, many thanks for your effort!

            Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Closing as fixed, many thanks for your effort! Note that the changes related to master (2.2beta) have been already sent upstream. But the stable ones will be part of next weeklies (Wed/Thu) as usual. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11