Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Testing Instructions

      For all checks, you will need to be in RTL mode. getting into RTL mode is possible after installing an RTL language pack. for example Hebrew. Now, you can set RTL mode system wide or just inside the course you are checking. (use course's setting menu for that)

      1. As Administrator, enable Activity Completion feature and as a Student, open up a course with several activities and make sure the Activity Completion boxes are displayed on the right side of the activities, adjacent to the activities' names.

      2. As a Teacher go through the setting of several (one or more, since it is all the same) Activities to make sure the fitemtitle (right form's div) and the felement (left form's div) are justified to the right and are proportionally aligned to the right. in each Form.

      3. As a Teacher, open course grade overview report and check that the grade category title(s) (on the top of the table) are justified to the right.

      4. As a Teacher, click the grades link inside the course' setting menu. now, when in grade overview report, click the Scales link on the settings' menu. Now, make sure the Scales table is centred on the screen. (btw, i think it should be the same for LTR mode)

      5. As a Teacher, click into a Glossary activity, now, click Categories. now, click Edit Categories. now, check that the categories table is centred. (btw, i think it should be the same for LTR mode) and all table's cells are right aligned. (add some categories, if necessary )

      6. As any user, click on the user's name to view its profile page. check to "fullprofile" link is right justified

      7. As a Teacher, click into an Assignment. now, click into assignment's submissions. check that the submissions table is right aligned.

      Show
      Testing Instructions For all checks, you will need to be in RTL mode. getting into RTL mode is possible after installing an RTL language pack. for example Hebrew. Now, you can set RTL mode system wide or just inside the course you are checking. (use course's setting menu for that) 1. As Administrator, enable Activity Completion feature and as a Student, open up a course with several activities and make sure the Activity Completion boxes are displayed on the right side of the activities, adjacent to the activities' names. 2. As a Teacher go through the setting of several (one or more, since it is all the same) Activities to make sure the fitemtitle (right form's div) and the felement (left form's div) are justified to the right and are proportionally aligned to the right. in each Form. 3. As a Teacher, open course grade overview report and check that the grade category title(s) (on the top of the table) are justified to the right. 4. As a Teacher, click the grades link inside the course' setting menu. now, when in grade overview report, click the Scales link on the settings' menu. Now, make sure the Scales table is centred on the screen. (btw, i think it should be the same for LTR mode) 5. As a Teacher, click into a Glossary activity, now, click Categories. now, click Edit Categories. now, check that the categories table is centred. (btw, i think it should be the same for LTR mode) and all table's cells are right aligned. (add some categories, if necessary ) 6. As any user, click on the user's name to view its profile page. check to "fullprofile" link is right justified 7. As a Teacher, click into an Assignment. now, click into assignment's submissions. check that the submissions table is right aligned.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30361-master-rtlpatches
    • Rank:
      32969

      Description

      More, RTL patches. mostly to CSS files.
      With some exceptions, for Modules that uses hard coded alignment styles
      (which need to be fixed, probably)

      URL, currently points to a temporary branch on my github account.
      It will be renamed to reflect this MDL issue. (soon)

        Activity

        Nadav Kavalerchik created issue -
        Nadav Kavalerchik made changes -
        Field Original Value New Value
        Fix Version/s STABLE backlog [ 10463 ]
        Mary Evans made changes -
        Assignee Patrick Malley [ ptrkmkl ] Mary Evans [ lazydaisy ]
        Mary Evans made changes -
        Status Open [ 1 ] Waiting for integration review [ 10010 ]
        Fix Version/s 2.2 [ 10656 ]
        Fix Version/s STABLE backlog [ 10463 ]
        Sam Hemelryk made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Integrator samhemelryk
        Currently in integration Yes [ 10041 ]
        Sam Hemelryk made changes -
        Sam Hemelryk made changes -
        Status Integration review in progress [ 10004 ] Reopened [ 4 ]
        Mary Evans made changes -
        Testing Instructions TESTING INSCRUCTIONS
        1.
        2.
        3.
        4.
        5.
        6.
        Mary Evans made changes -
        Testing Instructions TESTING INSCRUCTIONS
        1.
        2.
        3.
        4.
        5.
        6.
        Testing Instructions

        1.
        2.
        3.
        4.
        5.
        6.
        Michael de Raadt made changes -
        Labels triaged
        Eloy Lafuente (stronk7) made changes -
        Currently in integration Yes [ 10041 ]
        Mary Evans made changes -
        Parent MDL-30337 [ 49135 ]
        Issue Type Sub-task [ 5 ] Bug [ 1 ]
        Mary Evans made changes -
        Parent MDL-30337 [ 49135 ]
        Issue Type Bug [ 1 ] Sub-task [ 5 ]
        Nadav Kavalerchik made changes -
        Testing Instructions Testing Instructions

        1.
        2.
        3.
        4.
        5.
        6.
        Testing Instructions

        For all checks, you will need to be in RTL mode. getting into RTL mode is possible after installing an RTL language pack. for example Hebrew. Now, you can set RTL mode system wide or just inside the course you are checking. (use course's setting menu for that)

        1. As Administrator, enable Activity Completion feature and as a Student, open up a course with several activities and make sure the Activity Completion boxes are displayed on the right side of the activities, adjacent to the activities' names.

        2. As a Teacher go through the setting of several (one or more, since it is all the same) Activities to make sure the fitemtitle (right form's div) and the felement (left form's div) are justified to the right and are proportionally aligned to the right. in each Form.

        3. As a Teacher, open course grade overview report and check that the grade category title(s) (on the top of the table) are justified to the right.

        4. As a Teacher, click the grades link inside the course' setting menu. now, when in grade overview report, click the Scales link on the settings' menu. Now, make sure the Scales table is centred on the screen. (btw, i think it should be the same for LTR mode)

        5. As a Teacher, click into a Glossary activity, now, click Categories. now, click Edit Categories. now, check that the categories table is centred. (btw, i think it should be the same for LTR mode) and all table's cells are right aligned. (add some categories, if necessary )

        6. As any user, click on the user's name to view its profile page. check to "fullprofile" link is right justified

        7. As a Teacher, click into an Assignment. now, click into assignment's submissions. check that the submissions table is right aligned.
        Mary Evans made changes -
        Status Reopened [ 4 ] Development in progress [ 3 ]
        Mary Evans made changes -
        Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
        Sam Hemelryk made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Currently in integration Yes [ 10041 ]
        Sam Hemelryk made changes -
        Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
        Affects Version/s DEV backlog [ 10464 ]
        Sam Hemelryk made changes -
        Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
        Tester samhemelryk
        Sam Hemelryk made changes -
        Status Testing in progress [ 10011 ] Tested [ 10006 ]
        Eloy Lafuente (stronk7) made changes -
        Status Tested [ 10006 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Currently in integration Yes [ 10041 ]
        Integration date 29/Nov/11

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: