Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30377

RSS feed picks up expired (hidden) forum posts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.2.6, 2.3.3
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Forum, RSS
    • Labels:
    • Environment:
      XP
    • Testing Instructions:
      Hide
      1. Visit <yoursite>/admin/settings.php?section=optionalsubsystems and check 'enable RSS feeds'.
      2. Visit <yoursite>/admin/settings.php?section=modsettingforum and set 'Enable RSS feeds' to 'yes' and check 'Timed posts'.
      3. Add a forum activity to a course and set 'RSS feed for this activity' to 'Posts' and 'Number of RSS recent articles' to 10.
      4. Click on the forum activity and create a forum discussion called 'Past' and set it to expire some time in the past.
      5. Create another forum discussion called 'Future' and set it to start some time in the future.
      6. Create a bunch of other forum discussions that do not expire.
      7. Copy the links of the forum discussions that have expired (they may be in the student's browser history so it's possible they know the link)
      8. Log in as student on a separate browser and visit the links you copied, you should get a message saying they can't see them.
      9. Under 'Forum administration' click on 'RSS feed of posts'.
      10. Ensure you can only see the posts that have not expired.
      11. Do this for all the forums, ensure you can not see the 'Past' and 'Future' discussion but the others.
      12. As the administrator turn off the 'Timed posts' setting in Moodle.
      13. As a student ensure you can now see the forum posts you could not previously, also checking that the RSS feeds display correctly.*
      14. Turn it back on, and edit each discussion so that the time is now available and as a student check you can now view them and their corresponding RSS feed.

      *NOTE: The RSS feed gets cached by the browser for a default of 1 hour and in Moodle's cache until the cache is purged. In order for the RSS feed to be updated you need to purge your browser cache AND Moodle's cache since the Moodle cache is only updated if the discussion has been updated with another post.

      Show
      Visit <yoursite>/admin/settings.php?section=optionalsubsystems and check 'enable RSS feeds'. Visit <yoursite>/admin/settings.php?section=modsettingforum and set 'Enable RSS feeds' to 'yes' and check 'Timed posts'. Add a forum activity to a course and set 'RSS feed for this activity' to 'Posts' and 'Number of RSS recent articles' to 10. Click on the forum activity and create a forum discussion called 'Past' and set it to expire some time in the past. Create another forum discussion called 'Future' and set it to start some time in the future. Create a bunch of other forum discussions that do not expire. Copy the links of the forum discussions that have expired (they may be in the student's browser history so it's possible they know the link) Log in as student on a separate browser and visit the links you copied, you should get a message saying they can't see them. Under 'Forum administration' click on 'RSS feed of posts'. Ensure you can only see the posts that have not expired. Do this for all the forums, ensure you can not see the 'Past' and 'Future' discussion but the others. As the administrator turn off the 'Timed posts' setting in Moodle. As a student ensure you can now see the forum posts you could not previously, also checking that the RSS feeds display correctly.* Turn it back on, and edit each discussion so that the time is now available and as a student check you can now view them and their corresponding RSS feed. *NOTE: The RSS feed gets cached by the browser for a default of 1 hour and in Moodle's cache until the cache is purged. In order for the RSS feed to be updated you need to purge your browser cache AND Moodle's cache since the Moodle cache is only updated if the discussion has been updated with another post.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30377_master

      Description

      The RSS feed is picking up on forum posts that have been set to expire (hidden to non-admin etc) using the timed posts option. When clicking on the RSS link for the expired post you are given an error (unless you have the rights to view hidden posts).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Jan/13