Moodle
  1. Moodle
  2. MDL-30378

Site page links missing from Navigation blocks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Navigation
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      See comment below
    • Rank:
      32987

      Description

      1. Login as a student, go to My home and follow the link to one of the activities listed.
      2. Check that the nodes in the navigation block are correctly expanded and the navigation trail shows My home > My courses > Features Demo > Course section > Activity.
      3. Expand nodes in the navigation block and navigate to My courses > Features Demo > Participants > Student name.
      4. Check that View profile, Forum posts, Blogs are shown.
      5. Expand Forum posts and click on Posts.
      6. Check that any posts in the course are displayed and that the navigation trail matches the expanded nodes in the navigation block.
      7. Login as a teacher, expand nodes in the navigation block and navigate to the participants page in a course.
      8. Check that Blogs, Notes, Teacher name are shown.
      9. Select a participant then expand nodes in the navigation block and navigate to Activity reports > Outline report.
      10. Check that the outline report for the student is displayed and that the navigation trail matches the expanded nodes in the navigation block.
      11. Login as a manager, expand nodes in the navigation block and navigate to Site pages > Tags.
      12. Check that the Participants, Blogs, Notes, Tags, Reports, Site news are shown in the navigation block under Site pages.

      On step 12 "site news" link is missing from the navigation block as seen in attached pic (nav1)
      But on site homepage all links are present as seen in attached pic (nav2)

      1. nav1.PNG
        28 kB
      2. nav2.PNG
        35 kB

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Hi,

          I've just had initial look at this now, this problem is encountered because the some site pages initialise with front page course context, and others initialise with the site context.
          If the front page context is used then all front page activities are included in the navigation, otherwise with the system context they are left out.

          I will look at this now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi, I've just had initial look at this now, this problem is encountered because the some site pages initialise with front page course context, and others initialise with the site context. If the front page context is used then all front page activities are included in the navigation, otherwise with the system context they are left out. I will look at this now. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Putting this up for peer-review now

          Show
          Sam Hemelryk added a comment - Putting this up for peer-review now
          Hide
          Sam Hemelryk added a comment -

          Hello Peer-reviewer and integrator.

          I have produced two sets of patches for this issue. One that is stand alone, and one that is built upon MDL-28967, a navigation issue I currently have integrated.
          Both changes are made in the same area AND will cause conflicts.
          What I ask is that MDL-28967 is reviewed and hopefully integrated first, and then this issue. That way if MDL-28967 has been integrated the special branches I have below can be used and we can avoid nasty ugly collisions.

          Repo: git://github.com/samhemelryk/moodle.git

          Branches based upon MDL-28967:
          20 Branch : wip-MDL-30378-m20-builtupon-28967
          20 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m20...wip-MDL-30378-m20-builtupon-28967
          21 Branch : wip-MDL-30378-m21-builtupon-28967
          21 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m21...wip-MDL-30378-m21-builtupon-28967
          22 Branch : wip-MDL-30378-m22-builtupon-28967
          22 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m22...wip-MDL-30378-m22-builtupon-28967

          If MDL-28967 doesn't get integrated then use these branches:
          20 Branch : wip-MDL-30378-m20
          20 Diff : https://github.com/samhemelryk/moodle/compare/MOODLE_20_STABLE...wip-MDL-30378-m20
          21 Branch : wip-MDL-30378-m21
          21 Diff : https://github.com/samhemelryk/moodle/compare/MOODLE_21_STABLE...wip-MDL-30378-m21
          22 Branch : wip-MDL-30378-m22
          22 Diff : https://github.com/samhemelryk/moodle/compare/master...wip-MDL-30378-m22

          Thanks
          Sam

          Show
          Sam Hemelryk added a comment - Hello Peer-reviewer and integrator. I have produced two sets of patches for this issue. One that is stand alone, and one that is built upon MDL-28967 , a navigation issue I currently have integrated. Both changes are made in the same area AND will cause conflicts. What I ask is that MDL-28967 is reviewed and hopefully integrated first, and then this issue. That way if MDL-28967 has been integrated the special branches I have below can be used and we can avoid nasty ugly collisions. Repo: git://github.com/samhemelryk/moodle.git Branches based upon MDL-28967 : 20 Branch : wip- MDL-30378 -m20-builtupon-28967 20 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m20...wip-MDL-30378-m20-builtupon-28967 21 Branch : wip- MDL-30378 -m21-builtupon-28967 21 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m21...wip-MDL-30378-m21-builtupon-28967 22 Branch : wip- MDL-30378 -m22-builtupon-28967 22 Diff : https://github.com/samhemelryk/moodle/compare/wip-MDL-28967-m22...wip-MDL-30378-m22-builtupon-28967 If MDL-28967 doesn't get integrated then use these branches: 20 Branch : wip- MDL-30378 -m20 20 Diff : https://github.com/samhemelryk/moodle/compare/MOODLE_20_STABLE...wip-MDL-30378-m20 21 Branch : wip- MDL-30378 -m21 21 Diff : https://github.com/samhemelryk/moodle/compare/MOODLE_21_STABLE...wip-MDL-30378-m21 22 Branch : wip- MDL-30378 -m22 22 Diff : https://github.com/samhemelryk/moodle/compare/master...wip-MDL-30378-m22 Thanks Sam
          Hide
          Sam Hemelryk added a comment -

          Linking to a navigation issue currently up for integration that I would like to be integrated before this issue.

          Show
          Sam Hemelryk added a comment - Linking to a navigation issue currently up for integration that I would like to be integrated before this issue.
          Hide
          Sam Hemelryk added a comment -

          One more comment for the peer-review/integrator, the diff is USELESS, apply the changes and soft reset and you'll see what I mean, in reality I have only modified about 8 lines!

          Show
          Sam Hemelryk added a comment - One more comment for the peer-review/integrator, the diff is USELESS, apply the changes and soft reset and you'll see what I mean, in reality I have only modified about 8 lines!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          As far as MDL-28967 has been delayed to after release... I'm integrating this independently. Looks nice, specially using the --ignore-all-space switch, crazy git!

          Show
          Eloy Lafuente (stronk7) added a comment - As far as MDL-28967 has been delayed to after release... I'm integrating this independently. Looks nice, specially using the --ignore-all-space switch, crazy git!
          Hide
          Rajesh Taneja added a comment -

          Thanks for providing the fix Sam,
          Eloy asked me to push it for integration, hence doing so.

          FYI:
          Overall code looks good, but haven't analyzed it

          Show
          Rajesh Taneja added a comment - Thanks for providing the fix Sam, Eloy asked me to push it for integration, hence doing so. FYI: Overall code looks good, but haven't analyzed it
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Nobody tested this. MDLQA-1406 will.

          Show
          Eloy Lafuente (stronk7) added a comment - Nobody tested this. MDLQA-1406 will.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days.

          Thanks for the hard work! Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days. Thanks for the hard work! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: