Moodle
  1. Moodle
  2. MDL-30379

error on viewing survey responses or download the data

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Survey
    • Labels:
    • Testing Instructions:
      Hide

      This test requires a survey activity which has been completed by two or more students.

      1. Login as a teacher, access the survey and follow the 'View xx survey responses' link.
      2. Check that the responses listed per question are displayed correctly.
      3. Click the students link then select a student.
      4. Check that the student's responses are displayed correctly.
      5. Click the download link then select a format to download the data.
      6. Download the file, open it, and check that it contains all the required data.

      Show
      This test requires a survey activity which has been completed by two or more students. 1. Login as a teacher, access the survey and follow the 'View xx survey responses' link. 2. Check that the responses listed per question are displayed correctly. 3. Click the students link then select a student. 4. Check that the student's responses are displayed correctly. 5. Click the download link then select a format to download the data. 6. Download the file, open it, and check that it contains all the required data.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      32989

      Description

      Clicked 'View xx survey responses' link and received:

      Coding error detected, it must be fixed by a programmer: clean_param() can not process arrays, please use clean_param_array() instead.

      More information about this error

      Stack trace:
      line 717 of /lib/moodlelib.php: coding_exception thrown
      line 38 of /mod/survey/report.php: call to clean_param()

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Looks Good
          Thanks

          Show
          Ankit Agarwal added a comment - Looks Good Thanks
          Hide
          Rossiani Wijaya added a comment -

          Thanks Ankit,

          submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Ankit, submitting for integration review.
          Hide
          Aparup Banerjee added a comment -

          integrated, thanks!

          Show
          Aparup Banerjee added a comment - integrated, thanks!
          Hide
          Aparup Banerjee added a comment -

          passing, now for testing on QA

          Show
          Aparup Banerjee added a comment - passing, now for testing on QA
          Hide
          Aparup Banerjee added a comment - - edited

          this looks like it needs to be back ported too? please create a backport issue if needed. (note, couldn't find clean_param_array() in stables, but please check just in case)

          Show
          Aparup Banerjee added a comment - - edited this looks like it needs to be back ported too? please create a backport issue if needed. (note, couldn't find clean_param_array() in stables, but please check just in case)
          Hide
          Rossiani Wijaya added a comment -

          Apu,

          This issue doesn't need to be backported to 2.1 and 2.0, since clean_param_array() is only exist in 2.2 (MDL-26796).

          Show
          Rossiani Wijaya added a comment - Apu, This issue doesn't need to be backported to 2.1 and 2.0, since clean_param_array() is only exist in 2.2 ( MDL-26796 ).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days.

          Thanks for the hard work! Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days. Thanks for the hard work! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: