Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30392

Unable to uninstall section_links block

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.5, 2.1.2, 2.2
    • 2.0.6, 2.1.3
    • Blocks
    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • Easy
    • Hide
      • Go to Admin->Plugins->Manage blocks
      • Delete (uninstall) the section_links block
      • TEST: No error happen and you get the message saying that it has been deleted and now needs to be deleted from disk.
      Show
      Go to Admin->Plugins->Manage blocks Delete (uninstall) the section_links block TEST: No error happen and you get the message saying that it has been deleted and now needs to be deleted from disk.

    Description

      Apart from any other consideration (I could make a bunch related to that block, grrr), I was testing MDL-30327, and when uninstalling the block I got:

      Debug info: Argument 2 passed to moodle_database::delete_records()
      		 
      must be an array, string given, called in blocks/section_links/block_section_links.php
      		 
      on line 158 and defined
      		 
      Stack trace:
      		 
      line 365 of /lib/setuplib.php: coding_exception thrown
      		 
      line 1609 of /lib/dml/moodle_database.php: call to default_error_handler()
      		 
      line 158 of /blocks/section_links/block_section_links.php: call to moodle_database->delete_records()
      		 
      line 255 of /lib/adminlib.php: call to block_section_links->before_delete()
      		 
      line 101 of /admin/blocks.php: call to uninstall_plugin()

      Going to fix it now, it's only a matter of M2 API not being used.

      Attachments

        Issue Links

          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-30327 Block removal should have automatically remove 'config_plugins' settings

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Sam Hemelryk Sam Hemelryk
              Sam Hemelryk Sam Hemelryk
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                28/Nov/11