Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30394

Popup warning is too much information when attempting to restore.

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.1.2, 2.2
          • Fix Version/s: 2.1.3
          • Component/s: Backup
          • Labels:
          • Testing Instructions:
            Hide
            1. Log in as admin
            2. Select an existing course or create new course.
            3. Backup an existing/new course (settings -> backup)
            4. Restore this course as new course
              • Start restore process (settings -> restore -> click on restore link)
              • Confirm details (Press continue)
              • Restore as a new course (In top section "Restore as a new course" select a category and click continue),
            5. Make sure it should not show any popup notification.
            Show
            Log in as admin Select an existing course or create new course. Backup an existing/new course (settings -> backup) Restore this course as new course Start restore process (settings -> restore -> click on restore link) Confirm details (Press continue) Restore as a new course (In top section "Restore as a new course" select a category and click continue), Make sure it should not show any popup notification.
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-mdl-30394
          • Pull Master Diff URL:

            Description

            We should probably tone the popup message down to a simple note somewhere.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  has been marked as being related by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27790 Temporary course remains after restore

                  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    In my opinion, this information should be be explained in moodle docs.

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - In my opinion, this information should be be explained in moodle docs.
                    Hide
                    Permalink
                    mudrd8mz David Mudrák added a comment -

                    So, if I read the patch correctly, it reverts the original dialogue addition. If so, my +1 for it. Let's remove it and let us describe this more in doc.

                    Show
                    mudrd8mz David Mudrák added a comment - So, if I read the patch correctly, it reverts the original dialogue addition. If so, my +1 for it. Let's remove it and let us describe this more in doc.
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Yes David,
                    It just reverts the original dialogue addition

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Yes David, It just reverts the original dialogue addition
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    bringing this in...

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - bringing this in...
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated, thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    Tested. No more pop up. Thanks Rajesh.

                    Show
                    abgreeve Adrian Greeve added a comment - Tested. No more pop up. Thanks Rajesh.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

                    Ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        0 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          28/Nov/11