Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30395

Search using community finder block: many warning displayed if the course contain a third party plugin

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Hub
    • Labels:
    • Testing Instructions:
      Hide

      1. Login as a teacher (with the capability moodle/community:add allowed), turn editing on in the course and add a community block.
      2. Follow the search link in the community block.
      3. Search for a community course, selecting Mooch as the hub and 'courses I can enrol in'. ('courses I can enrol in' choice only appear if the teacher also have the moodle/community:download capability)
      4. no php warnings should be displayed

      Show
      1. Login as a teacher (with the capability moodle/community:add allowed), turn editing on in the course and add a community block. 2. Follow the search link in the community block. 3. Search for a community course, selecting Mooch as the hub and 'courses I can enrol in'. ('courses I can enrol in' choice only appear if the teacher also have the moodle/community:download capability) 4. no php warnings should be displayed
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:

      Description

      http://tracker.moodle.org/browse/MDLQA-1367?focusedCommentId=131127&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-131127

      Invalid get_string() identifier: 'pluginname' or component 'block_notify_changes'
       
          line 6214 of \lib\moodlelib.php: call to debugging()
          line 6806 of \lib\moodlelib.php: call to core_string_manager->get_string()
          line 205 of \blocks\community\renderer.php: call to get_string()
          line 233 of \blocks\community\communitycourse.php: call to block_community_renderer->course_list()
       
      Invalid get_string() identifier: 'pluginname' or component 'block_notify_changes'
       
          line 6214 of \lib\moodlelib.php: call to debugging()
          line 6806 of \lib\moodlelib.php: call to core_string_manager->get_string()
          line 205 of \blocks\community\renderer.php: call to get_string()
          line 233 of \blocks\community\communitycourse.php: call to block_community_renderer->course_list()
       
      Invalid get_string() identifier: 'pluginname' or component 'block_notify_changes'
       
          line 6214 of \lib\moodlelib.php: call to debugging()
          line 6806 of \lib\moodlelib.php: call to core_string_manager->get_string()
          line 205 of \blocks\community\renderer.php: call to get_string()
          line 233 of \blocks\community\communitycourse.php: call to block_community_renderer->course_list()
       
      Invalid get_string() identifier: 'modulename' or component 'flashcard'

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            jerome Jérôme Mouneyrac added a comment -

            I'm decreasing the error level. The error is an access control exception. Knowing it's qa.moodle.net I would suspect that the registration info has been broken again Unregister qa.moodle.net from mooch and register again before testing. I'll check this later. Please file another issue for the warning (I'll file it when I'll come back to it if you don't have time). Thank you.

            Show
            jerome Jérôme Mouneyrac added a comment - I'm decreasing the error level. The error is an access control exception. Knowing it's qa.moodle.net I would suspect that the registration info has been broken again Unregister qa.moodle.net from mooch and register again before testing. I'll check this later. Please file another issue for the warning (I'll file it when I'll come back to it if you don't have time). Thank you.
            Hide
            jerome Jérôme Mouneyrac added a comment - - edited

            Edited the description, I prefer to have the full description in the MDL issue than in the QA test (update: where is the smiley with the tongue )

            Show
            jerome Jérôme Mouneyrac added a comment - - edited Edited the description, I prefer to have the full description in the MDL issue than in the QA test (update: where is the smiley with the tongue )
            Hide
            jerome Jérôme Mouneyrac added a comment -

            I unregistered the hub and retested I confirm it works. However the warning I still there.

            Show
            jerome Jérôme Mouneyrac added a comment - I unregistered the hub and retested I confirm it works. However the warning I still there.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Decreasing priority a new time

            Show
            jerome Jérôme Mouneyrac added a comment - Decreasing priority a new time
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sorry, I'm reopening this.

            We should be using get_plugin_list() to detect if one plugin (module) is available or no instead of own file_exists() and friends.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sorry, I'm reopening this. We should be using get_plugin_list() to detect if one plugin (module) is available or no instead of own file_exists() and friends. Ciao
            Hide
            jerome Jérôme Mouneyrac added a comment -

            fixed

            Show
            jerome Jérôme Mouneyrac added a comment - fixed
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Tested on 2.2, 2.1 and 2.0

            Show
            jerome Jérôme Mouneyrac added a comment - Tested on 2.2, 2.1 and 2.0
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks this has been integrated to 2.x stable branches and what is still currently master.

            Please test!

            Show
            nebgor Aparup Banerjee added a comment - Thanks this has been integrated to 2.x stable branches and what is still currently master. Please test!
            Hide
            nebgor Aparup Banerjee added a comment -

            seems fine to me : up for QA testing

            Show
            nebgor Aparup Banerjee added a comment - seems fine to me : up for QA testing
            Hide
            salvetore Michael de Raadt added a comment -

            The related QA test has now been passed.

            Show
            salvetore Michael de Raadt added a comment - The related QA test has now been passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay!

            Closing and big thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay! Closing and big thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/12