Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide

      Note: Plz, test this under 20 and 21 too (has been backported there)

      1. Login as a teacher, update a lesson, set 'Password protected lesson' to yes and try to save the form.
      2. the form should not be saved since no password is entered
      3. Now enter a password and make sure the form is saved
      4. Now login as a student and make sure you can access the lesson with the above password
      5. Login as teacher again and set "password protected lesson" to No.
      6. Make sure you can access the lesson now without any password as a student.
      Show
      Note: Plz, test this under 20 and 21 too (has been backported there) Login as a teacher, update a lesson, set 'Password protected lesson' to yes and try to save the form. the form should not be saved since no password is entered Now enter a password and make sure the form is saved Now login as a student and make sure you can access the lesson with the above password Login as teacher again and set "password protected lesson" to No. Make sure you can access the lesson now without any password as a student.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-30398-master

      Description

      • Login as a teacher, update a lesson, set 'Password protected lesson' to yes and try to save the form.
        ideally
        the form should not be saved since no password is entered
        actually result
        The form is saved without any error.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Rossiani Wijaya added a comment -

            This looks good Ankit.

            Thanks for fixing this.

            Show
            Rossiani Wijaya added a comment - This looks good Ankit. Thanks for fixing this.
            Hide
            Rossiani Wijaya added a comment -

            submitting this for integration review.

            Show
            Rossiani Wijaya added a comment - submitting this for integration review.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            This fix has been backported to 20 and 21, please test it specially under those version.

            Surely MDLQA-1269 will do the testing for master (2.2).

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks! This fix has been backported to 20 and 21, please test it specially under those version. Surely MDLQA-1269 will do the testing for master (2.2). Ciao
            Hide
            Rajesh Taneja added a comment -

            Works Great
            Thanks for fixing this Ankit.

            FYI:
            Not sure if this a major issue, but observed following:
            If Password protection lesson is set to No, password field is disabled. Although unmask checkbox is enabled, and checking that enables password field. As password is enabled, any value in that actually gets saved as well.

            Show
            Rajesh Taneja added a comment - Works Great Thanks for fixing this Ankit. FYI: Not sure if this a major issue, but observed following: If Password protection lesson is set to No , password field is disabled. Although unmask checkbox is enabled, and checking that enables password field. As password is enabled, any value in that actually gets saved as well.
            Hide
            Ankit Agarwal added a comment -

            Hi Rajesh,
            I have created MDL-30438 to deal with the issue you mentioned.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi Rajesh, I have created MDL-30438 to deal with the issue you mentioned. Thanks
            Hide
            Rajesh Taneja added a comment -

            Thanks Ankit

            Show
            Rajesh Taneja added a comment - Thanks Ankit
            Hide
            Eloy Lafuente (stronk7) added a comment -

            And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: