Details

    • Rank:
      33022

      Description

      I was running the MDLQA-1419 test on qa.moodle.net and I got this feedback (it works but note the notice at the top):

      Service Url:
      http://qa.moodle.net/mod/lti/service.php

      ------------ POST RETURNS ------------
      <br />
      <b>Notice</b>: Undefined index: Content-type in <b>/html/mod/lti/OAuthBody.php</b> on line <b>86</b>
      <br />
      <?xml version="1.0" encoding="UTF-8"?>
      <imsx_POXEnvelopeResponse xmlns="http://www.imsglobal.org/lis/oms1p0/pox">
      <imsx_POXHeader>
      <imsx_POXResponseHeaderInfo>
      <imsx_version>V1.0</imsx_version>
      <imsx_messageIdentifier>95279161</imsx_messageIdentifier>
      <imsx_statusInfo>
      <imsx_codeMajor>success</imsx_codeMajor>
      <imsx_severity>status</imsx_severity>
      <imsx_description>Grade replace response</imsx_description>
      <imsx_messageRefIdentifier>4ecb53495e8a0</imsx_messageRefIdentifier>
      </imsx_statusInfo>
      </imsx_POXResponseHeaderInfo>
      </imsx_POXHeader>
      <imsx_POXBody>
      <replaceResultResponse/>
      </imsx_POXBody>
      </imsx_POXEnvelopeResponse>

      ------------ WE SENT ------------
      <?xml version = "1.0" encoding = "UTF-8"?>
      <imsx_POXEnvelopeRequest xmlns = "http://www.imsglobal.org/lis/oms1p0/pox">
      <imsx_POXHeader>
      <imsx_POXRequestHeaderInfo>
      <imsx_version>V1.0</imsx_version>
      <imsx_messageIdentifier>4ecb53495e8a0</imsx_messageIdentifier>
      </imsx_POXRequestHeaderInfo>
      </imsx_POXHeader>
      <imsx_POXBody>
      <replaceResultRequest>
      <resultRecord>
      <sourcedGUID>
      <sourcedId>{"data":

      {"instanceid":"1","userid":"6","launchid":1891615058}

      ,"hash":"fd4233b731b878e1c30e7e40df47372e68a31198703257b2577d9972d2a0c6a5"}</sourcedId>
      </sourcedGUID>
      <result>
      <resultScore>
      <language>en-us</language>
      <textString>0.4</textString>
      </resultScore>
      </result>
      </resultRecord>
      </replaceResultRequest>
      </imsx_POXBody>
      </imsx_POXEnvelopeRequest>

        Issue Links

          Activity

          Hide
          Chris Scribner added a comment -

          This should be fixed now. It would only have occurred if the content-type header wasn't sent, which I'm not sure is valid to begin with.

          Code is at https://github.com/scriby/moodle/tree/MDL-30400

          Show
          Chris Scribner added a comment - This should be fixed now. It would only have occurred if the content-type header wasn't sent, which I'm not sure is valid to begin with. Code is at https://github.com/scriby/moodle/tree/MDL-30400
          Hide
          Martin Dougiamas added a comment -

          Looks OK to me, thanks Chris. Can you fill out the git fields for the bug in future? Cheers thanks

          Show
          Martin Dougiamas added a comment - Looks OK to me, thanks Chris. Can you fill out the git fields for the bug in future? Cheers thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          (by cherry-picking and minor-amending)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (by cherry-picking and minor-amending)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Nobody tested this. MDLQA-1419 will.

          Show
          Eloy Lafuente (stronk7) added a comment - Nobody tested this. MDLQA-1419 will.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days.

          Thanks for the hard work! Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days. Thanks for the hard work! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: