Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30402

Hardcoded English string in admin/cli/install.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      Run the CLI installer in the interactive mode. The second step should be titled as "Data directories permission".

      Anyway, this will fail probably and [[datarootpermission]] will be displayed if you test this in integration.git. AMOS needs to see this patch in moodle.git first so it includes the new string in the install pack. So it will start working correctly after the next weekly build, with a temporary expected regression.

      Show
      Run the CLI installer in the interactive mode. The second step should be titled as "Data directories permission". Anyway, this will fail probably and [ [datarootpermission] ] will be displayed if you test this in integration.git. AMOS needs to see this patch in moodle.git first so it includes the new string in the install pack. So it will start working correctly after the next weekly build, with a temporary expected regression.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30402-install-string

      Description

      cli_heading('Data directories permission'); // todo localize

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            mudrd8mz David Mudrák added a comment -

            Submitting for integration.

            Show
            mudrd8mz David Mudrák added a comment - Submitting for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            As mentioned by David, it is showing [[datarootpermission]] currently. Passing this for now, as this is expected to work fine in next weekly build.
            Thanks David for fixing this

            Show
            rajeshtaneja Rajesh Taneja added a comment - As mentioned by David, it is showing [ [datarootpermission] ] currently. Passing this for now, as this is expected to work fine in next weekly build. Thanks David for fixing this
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11