Moodle
  1. Moodle
  2. MDL-30415

Serve non-minified YUI2 in developer debug mode

    Details

    • Rank:
      33046

      Description

      Using js_init_call() and a custom js module that has several yui2-libs in the requires array, I get the minified versions of all of them. JS set to not be minified, all caches purged, debugging set to developer level, etc.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog.

          In the meantime adding more information, such as screenshots, replication instructions, fix test instructions, a workaround or even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog. In the meantime adding more information, such as screenshots, replication instructions, fix test instructions, a workaround or even a code solution, will help us and other users. If you are able to provide a patch, please add a patch label so we will spot it.
          Hide
          Petr Škoda added a comment -

          Hello, I have created a patch that prevents rollups when loading yui2 libs. This should help with debugging of yui2 scripts. please note that since 2.0 we load non-minimised yui libs only, the debug was too verbose in majority of cases. If you need yui debug mode please edit your lib/outputrequirementslib.php

          $this->yui3loader->filter = YUI_RAW; // for more detailed logging info use YUI_DEBUG here
          $this->yui2loader->filter = YUI_RAW; // for more detailed logging info use YUI_DEBUG here
          

          Thanks a lot for the report, I am going to tweak the subject a bit to reflect the proposed change in patch.

          Petr

          To integrators: please cherry pick to 2.1 and 2.2 and integrate after the linked issue.

          Show
          Petr Škoda added a comment - Hello, I have created a patch that prevents rollups when loading yui2 libs. This should help with debugging of yui2 scripts. please note that since 2.0 we load non-minimised yui libs only, the debug was too verbose in majority of cases. If you need yui debug mode please edit your lib/outputrequirementslib.php $ this ->yui3loader->filter = YUI_RAW; // for more detailed logging info use YUI_DEBUG here $ this ->yui2loader->filter = YUI_RAW; // for more detailed logging info use YUI_DEBUG here Thanks a lot for the report, I am going to tweak the subject a bit to reflect the proposed change in patch. Petr To integrators: please cherry pick to 2.1 and 2.2 and integrate after the linked issue.
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now.
          Hide
          Jason Fowler added a comment -

          Test passed in 2.1 and 2.2

          Show
          Jason Fowler added a comment - Test passed in 2.1 and 2.2
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: