Moodle
  1. Moodle
  2. MDL-30419

IMS package content missing when using Blackboard packages

    Details

    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      Please use my provided IMS package for testing. Without the patch you would expect the package to import but there is no content in the right hand side if you click on each item of the TOC. My patch fixes the import process to associated with html content within the IMS package.

      This IMS package that has resources without href under the resource element and has file sub-item like :-

      <resource identifier="URN_X-WEBCT-VISTA-V0_8ac7292a-0ae5-0404-0056-337e7a93e0ff.16546238650011" type="webct.manifest" webct:coType="webct.page" xsi:type="webct:ResourceType">
      <file href="GAssignments.htm"/>
      </resource>

      If you import in 2.0.5 or 2.1.2 the file href isn't recorded and no content assigned to this item in the TOC.

      Show
      Please use my provided IMS package for testing. Without the patch you would expect the package to import but there is no content in the right hand side if you click on each item of the TOC. My patch fixes the import process to associated with html content within the IMS package. This IMS package that has resources without href under the resource element and has file sub-item like :- <resource identifier="URN_X-WEBCT-VISTA-V0_8ac7292a-0ae5-0404-0056-337e7a93e0ff.16546238650011" type="webct.manifest" webct:coType="webct.page" xsi:type="webct:ResourceType"> <file href="GAssignments.htm"/> </resource> If you import in 2.0.5 or 2.1.2 the file href isn't recorded and no content assigned to this item in the TOC.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Rank:
      33052

      Description

      When importing IMS packages from Blackboard the file content is skipped because it assumes the content is from a href url not local files.

        Activity

        Hide
        Tim Lock added a comment -

        Added Pull 2.0 Diff URL

        Show
        Tim Lock added a comment - Added Pull 2.0 Diff URL
        Hide
        Michael de Raadt added a comment -

        Hi, Tim.

        There are two ways we could go about this, seeing that you have provided a Git patch.

        1. We could treat this as a bug and integrate this down the track
        2. We could push this to peer review and on to integration

        Which way would you prefer to go?

        Show
        Michael de Raadt added a comment - Hi, Tim. There are two ways we could go about this, seeing that you have provided a Git patch. We could treat this as a bug and integrate this down the track We could push this to peer review and on to integration Which way would you prefer to go?
        Hide
        Tim Lock added a comment -

        Hi Michael,

        I suggest 2.

        If you need anything from me, let me know.

        Show
        Tim Lock added a comment - Hi Michael, I suggest 2. If you need anything from me, let me know.
        Hide
        Michael de Raadt added a comment -

        Hi, Tim.

        If you click the button labelled "Request peer review" it will move into the workflow.

        Thanks.

        Show
        Michael de Raadt added a comment - Hi, Tim. If you click the button labelled "Request peer review" it will move into the workflow. Thanks.
        Hide
        Tim Lock added a comment -

        Hi Michael,

        Only get the option "Start peer review"?

        Show
        Tim Lock added a comment - Hi Michael, Only get the option "Start peer review"?
        Hide
        Tim Lock added a comment -

        Demo IMS Package

        Show
        Tim Lock added a comment - Demo IMS Package
        Hide
        Tim Lock added a comment -

        Hi Michael,

        Can you please request the peer review for me?

        Regards,
        Tim

        Show
        Tim Lock added a comment - Hi Michael, Can you please request the peer review for me? Regards, Tim
        Hide
        Michael de Raadt added a comment -

        Sorry, I didn't check the assignee. You are now the assignee and should see the request button.

        Show
        Michael de Raadt added a comment - Sorry, I didn't check the assignee. You are now the assignee and should see the request button.
        Hide
        Tim Lock added a comment -

        Thanks Michael

        Show
        Tim Lock added a comment - Thanks Michael
        Hide
        Dan Marsden added a comment -

        was looking at a few other IMS things today and saw this - code looks good to me but you will need to be more specific with your test instructions before you submit for integration - test instructions state "find a package" - but you've uploaded one here. you will also need to state what the tester should be looking for on success!

        Show
        Dan Marsden added a comment - was looking at a few other IMS things today and saw this - code looks good to me but you will need to be more specific with your test instructions before you submit for integration - test instructions state "find a package" - but you've uploaded one here. you will also need to state what the tester should be looking for on success!
        Hide
        Tim Lock added a comment -

        Please use my provided IMS package for testing. Without the patch you would expect the package to import but there is no content in the right hand side if you click on each item of the TOC. My patch fixes the import process to associated with html content within the IMS package.

        Show
        Tim Lock added a comment - Please use my provided IMS package for testing. Without the patch you would expect the package to import but there is no content in the right hand side if you click on each item of the TOC. My patch fixes the import process to associated with html content within the IMS package.
        Hide
        Dan Marsden added a comment -

        heh - there's a special place up the top that lists "testing instructions" - this is where the testers will look - can you please update it there?

        Show
        Dan Marsden added a comment - heh - there's a special place up the top that lists "testing instructions" - this is where the testers will look - can you please update it there?
        Hide
        Tim Lock added a comment -

        done

        Show
        Tim Lock added a comment - done
        Hide
        Dan Marsden added a comment -

        Looks good - my +1 to integrate

        Show
        Dan Marsden added a comment - Looks good - my +1 to integrate
        Hide
        Tim Lock added a comment -

        What happens next?

        Show
        Tim Lock added a comment - What happens next?
        Hide
        Dan Marsden added a comment -

        You press the magic button - submit for integration

        Show
        Dan Marsden added a comment - You press the magic button - submit for integration
        Hide
        Tim Lock added a comment - - edited

        Hi Dan,

        I don't get that button, so can you please start it for me?

        Only "Stop Development" or "Request Peer Review" buttons were available.

        Show
        Tim Lock added a comment - - edited Hi Dan, I don't get that button, so can you please start it for me? Only "Stop Development" or "Request Peer Review" buttons were available.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yeah, it sounds to me a lot that under 1.x we had that BB exception covered (or perhaps it was another one). Surely, with the complete refactor of all the resource modules we missed that at some point.

        Show
        Eloy Lafuente (stronk7) added a comment - Yeah, it sounds to me a lot that under 1.x we had that BB exception covered (or perhaps it was another one). Surely, with the complete refactor of all the resource modules we missed that at some point.
        Hide
        Tim Lock added a comment -

        Hi Eloy,

        Works perfectly in 1.9.12 and 1.9.15, so just got overlooked.

        Show
        Tim Lock added a comment - Hi Eloy, Works perfectly in 1.9.12 and 1.9.15, so just got overlooked.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Picked the commit (7a0e6f42961fe6b087887daf5b384d9b30c90a48) and applied to all 2.x branches (master included).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Picked the commit (7a0e6f42961fe6b087887daf5b384d9b30c90a48) and applied to all 2.x branches (master included). Thanks!
        Hide
        Rossiani Wijaya added a comment -

        This is working fine.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This is working fine. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

        Now... disconnect, relax and enjoy the next days, yay!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

          People

          • Votes:
            7 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: