Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30422

scorm interactions report uses old var

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. upload a scorm package
      2. Make sure debugging is set to developer
      3. Submit a few attempts by loging in as a student
      4. visit the scorm interactions reports page (scorm>report>interactions)
      5. make sure there is no "undefined property" warning
      6. Make sure you see the same profile fields (image,email etc) in basic report and interactions report
      Show
      upload a scorm package Make sure debugging is set to developer Submit a few attempts by loging in as a student visit the scorm interactions reports page (scorm>report>interactions) make sure there is no "undefined property" warning Make sure you see the same profile fields (image,email etc) in basic report and interactions report
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30422-master

      Description

      Notice: Undefined property: stdClass::$grade_report_showuseridnumber in /home/dan/www/scormtest/mod/scorm/report/interactions/report.php on line 131

      should be changed to use get_extra_user_fields instead

        Gliffy Diagrams

          Activity

          Hide
          danmarsden Dan Marsden added a comment -

          Hi Ankit - if you're too busy for this one, bounce it back and I'll take care of it! - thanks!

          Show
          danmarsden Dan Marsden added a comment - Hi Ankit - if you're too busy for this one, bounce it back and I'll take care of it! - thanks!
          Hide
          danmarsden Dan Marsden added a comment -

          (or let me know if the bug doesn't make enough sense!)

          Show
          danmarsden Dan Marsden added a comment - (or let me know if the bug doesn't make enough sense!)
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Hi Dan,
          Thanks for noticing this.up for review!

          Show
          ankit_frenz Ankit Agarwal added a comment - Hi Dan, Thanks for noticing this.up for review!
          Hide
          danmarsden Dan Marsden added a comment -

          looks a bit different to how it was implemented in report/basic/report.php - I guess we should use the same method - iterate over the extrafields and show each field listed?

          Show
          danmarsden Dan Marsden added a comment - looks a bit different to how it was implemented in report/basic/report.php - I guess we should use the same method - iterate over the extrafields and show each field listed?
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Hi Dan,
          Patch updated
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Hi Dan, Patch updated Thanks
          Hide
          danmarsden Dan Marsden added a comment -

          looks good

          Show
          danmarsden Dan Marsden added a comment - looks good
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks guys this has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks guys this has been integrated now
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Tested during integration

          Show
          samhemelryk Sam Hemelryk added a comment - Tested during integration
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11