Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30428

Missing line break before "Export to portfolio" link when reviewing chat transcripts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Chat, Portfolio
    • Labels:
    • Testing Instructions:
      Hide
      • Check the enableportfolios box in Settings > Site administration > Advanced features
      • Enable selected portfolio plugins in Settings > Site administration > Plugins > Portfolios > Manage portfolios
      • Create a new chat
      • Join the chat and make a post or two
      • Leave the chat
      • View the chat activity
      • Select 'View past chat sessions'
      • Choose 'List all session'
      Show
      Check the enableportfolios box in Settings > Site administration > Advanced features Enable selected portfolio plugins in Settings > Site administration > Plugins > Portfolios > Manage portfolios Create a new chat Join the chat and make a post or two Leave the chat View the chat activity Select 'View past chat sessions' Choose 'List all session'
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30428-master-1

      Description

      With portfolios enabled, viewing previous chat logs there's a <br/> missing between 'See this session' and 'Export to portfolio' (see screenshot)

      The 'See this session' is produced with an echo at mod/chat/report.php line 231
      The 'Export to portfolio' link is produced by a render function which only outputs if any portfolio plugins are actually enabled.

      As a result, it's not just a case of adding an

      echo html_writer::empty_tag('br');

      as if portfolios are enabled, but no portfolio plugins are, the newline would still be present.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/11