Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30428

Missing line break before "Export to portfolio" link when reviewing chat transcripts

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2
    • 2.2
    • Chat, Portfolio
    • MOODLE_22_STABLE
    • MOODLE_22_STABLE
    • MDL-30428-master-1
    • Hide
      • Check the enableportfolios box in Settings > Site administration > Advanced features
      • Enable selected portfolio plugins in Settings > Site administration > Plugins > Portfolios > Manage portfolios
      • Create a new chat
      • Join the chat and make a post or two
      • Leave the chat
      • View the chat activity
      • Select 'View past chat sessions'
      • Choose 'List all session'
      Show
      Check the enableportfolios box in Settings > Site administration > Advanced features Enable selected portfolio plugins in Settings > Site administration > Plugins > Portfolios > Manage portfolios Create a new chat Join the chat and make a post or two Leave the chat View the chat activity Select 'View past chat sessions' Choose 'List all session'

    Description

      With portfolios enabled, viewing previous chat logs there's a <br/> missing between 'See this session' and 'Export to portfolio' (see screenshot)

      The 'See this session' is produced with an echo at mod/chat/report.php line 231
      The 'Export to portfolio' link is produced by a render function which only outputs if any portfolio plugins are actually enabled.

      As a result, it's not just a case of adding an

      echo html_writer::empty_tag('br');

      as if portfolios are enabled, but no portfolio plugins are, the newline would still be present.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Rajesh Taneja Rajesh Taneja
              Aparup Banerjee Aparup Banerjee
              Aparup Banerjee Aparup Banerjee
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona), David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                5/Dec/11