Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Wiki (2.x)
    • Labels:
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      You could start by following the replication steps in the description and ensure that you don't get the same problem.

      • Make sure that you have at lease two groups for this course.
      • Create a collaborative wiki activity with visible groups.
      • As the admin create the first page for all participants - put content like 'all participants' in the body so that you can recognise which group you are in.
      • Now change over to another group. Make the first page for them (make sure that you can also identify this page).
      • Continue to switch between groups. Create new pages.
      • log in as students in the course and create new pages.

      [What to look out for]
      Ensure that the group drop down box is the same as the page that you are viewing.
      Make sure that even if you are view a page in a different group, that when you create a new page it's for your group.
      Try creating a wiki with separate groups and check that there are no problems there either.

      Show
      You could start by following the replication steps in the description and ensure that you don't get the same problem. Make sure that you have at lease two groups for this course. Create a collaborative wiki activity with visible groups. As the admin create the first page for all participants - put content like 'all participants' in the body so that you can recognise which group you are in. Now change over to another group. Make the first page for them (make sure that you can also identify this page). Continue to switch between groups. Create new pages. log in as students in the course and create new pages. [What to look out for] Ensure that the group drop down box is the same as the page that you are viewing. Make sure that even if you are view a page in a different group, that when you create a new page it's for your group. Try creating a wiki with separate groups and check that there are no problems there either.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30478-master
    • Rank:
      33150

      Description

      When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

      The investigation identified the following issues:

      1. The current activity group in wiki view page is not updated to selected
      group in most cases, making dropdown menu displaying the wrong group. Having
      said that, the displayed page may also belong to the the wrong group, I have seen a
      situation that after selecting group, both dropdown menu and page do not match
      neither each other nor the requested page.

      2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
      'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

      3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).

      Replication steps:
      (all steps are done as admin)

      1. Create collaborative wiki activity with 'Visible groups' and leave page name default ('First page name')
      2. You will be prompted to create the first page, write 'first page' in the content.
      3. Create two course groups, Group 1 and Group 2.
      4. Go to the wiki activity and select Group 1
      5. You will be prompted to create a new page 'First+page+name', write 'Group 1' in the page content.
      6. (observation 1) You are now on the main wiki view page, the page content belongs to group 1, but selector reads 'All participants'.
      7. Select 'Group 1' in dropdown selector.
      8. (observation 2) The content now switched to the 'first page' and the selector reads 'All participants' - 'Group 1' selection failed.
      9. Select 'Group 1' in dropdown selector again. Now display seems correct - Group 1 page is displayed and selector reads 'Group 1'
      10. Select 'All participants' in dropdown selector.
      11. (observation 3) Chrome browser reports 'This web page has a redirect loop'
      12. Get back to moodle from error page (just open the url and the course page), click on wiki activity we created.
      13. (observation 4) Wiki prompts you to create the new page 'First page name'
      14. Proceed creating it, the surprising thing is that it will belong to 'Group 1' as well under different name, so name it 'Group 1 new'.
      15. Now try switching between 'Group 1' and 'All participants' several time, you will be able to spot all three pages one after other, but in most cases the displayed page and selector will not be reflecting the one you have chosen.

      If you like to observe even more weirdness, you may introduce a second page by selecting 'Group 2' in the menu, and play switching between them.

        Issue Links

          Activity

          Ruslan Kabalin created issue -
          Ruslan Kabalin made changes -
          Field Original Value New Value
          Description When wiki page group mode is set to either 'Visible groups' or separate groups. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The short investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).
          When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The short investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).
          Ruslan Kabalin made changes -
          Description When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The short investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).
          When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).
          Andrew Nicols made changes -
          Labels wiki
          Ruslan Kabalin made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Testing Instructions (all steps are done as admin)
          # Create collaborative wiki activity with 'Visible groups' and leave page name default ('First page name')
          # You will be prompted to create the first page, write 'first page' in the content.
          # Create two course groups, Group 1 and Group 2.
          # Go to the wiki activity and select Group 1
          # You will be prompted to create a new page 'First+page+name', write 'Group 1' in the page content.
          # *(observation 1)* You are now on the main wiki view page, the page content belongs to group 1, but selector reads 'All participants'.
          # Select 'Group 1' in dropdown selector.
          # *(observation 2)* The content now switched to the 'first page' and the selector reads 'All participants' - 'Group 1' selection failed.
          # Select 'Group 1' in dropdown selector again. Now display seems correct - Group 1 page is displayed and selector reads 'Group 1'
          # Select 'All participants' in dropdown selector.
          # *(observation 3)* Chrome browser reports 'This web page has a redirect loop'
          # Get back to moodle from error page (just open the url and the course page), click on wiki activity we created.
          # *(observation 4)* Wiki prompts you to create the new page 'First page name'
          # Proceed creating it, the surprising thing is that it will belong to 'Group 1' as well under different name, so name it 'Group 1 new'.
          # Now try switching between 'Group 1' and 'All participants' several time, you will be able to spot all three pages one after other, but in most cases the displayed page and selector will not be reflecting the one you have chosen.

          If you like to observe even more weirdness, you may introduce a second page by selecting 'Group 2' in the menu, and play switching between them.
          Description When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).
          When wiki page group mode is set to either 'Visible groups' or 'Separate groups'. The groups selector displayed on wiki/view.php page (a) does not reflect the current group (b) changing the groups does not bring you to correct group page.

          The investigation identified the following issues:

          1. The current activity group in wiki view page is not updated to selected
          group in most cases, making dropdown menu displaying the wrong group. Having
          said that, the displayed page may also belong to the the wrong group, I have seen a
          situation that after selecting group, both dropdown menu and page do not match
          neither each other nor the requested page.

          2. I guess the wiki title is sometimes malformed for groups (spaces in the original title are replaced with +), which makes it redirecting to the
          'first page', and even causes 'redirect loop' or prompting for group page creation (while it has been created already).

          3. The title used as hidden parameter in group dropdown always reflect the title of the previously selected page, so the attempt to switch group ends up with non-existing page and redirect user to 'first page' (which might even be not the main page either).

          *Replication steps:*
          (all steps are done as admin)
          # Create collaborative wiki activity with 'Visible groups' and leave page name default ('First page name')
          # You will be prompted to create the first page, write 'first page' in the content.
          # Create two course groups, Group 1 and Group 2.
          # Go to the wiki activity and select Group 1
          # You will be prompted to create a new page 'First+page+name', write 'Group 1' in the page content.
          # *(observation 1)* You are now on the main wiki view page, the page content belongs to group 1, but selector reads 'All participants'.
          # Select 'Group 1' in dropdown selector.
          # *(observation 2)* The content now switched to the 'first page' and the selector reads 'All participants' - 'Group 1' selection failed.
          # Select 'Group 1' in dropdown selector again. Now display seems correct - Group 1 page is displayed and selector reads 'Group 1'
          # Select 'All participants' in dropdown selector.
          # *(observation 3)* Chrome browser reports 'This web page has a redirect loop'
          # Get back to moodle from error page (just open the url and the course page), click on wiki activity we created.
          # *(observation 4)* Wiki prompts you to create the new page 'First page name'
          # Proceed creating it, the surprising thing is that it will belong to 'Group 1' as well under different name, so name it 'Group 1 new'.
          # Now try switching between 'Group 1' and 'All participants' several time, you will be able to spot all three pages one after other, but in most cases the displayed page and selector will not be reflecting the one you have chosen.

          If you like to observe even more weirdness, you may introduce a second page by selecting 'Group 2' in the menu, and play switching between them.
          Labels wiki triaged
          Affects Version/s 2.1.2 [ 10851 ]
          Michael de Raadt made changes -
          Link This issue has a non-specific relationship to MDL-27037 [ MDL-27037 ]
          Matt Kolb made changes -
          Attachment renderer.patch [ 26198 ]
          Michael de Raadt made changes -
          Labels triaged patch triaged
          Michael de Raadt made changes -
          Link This issue has been marked as being related by MDL-31188 [ MDL-31188 ]
          Adrian Greeve made changes -
          Link This issue blocks MDL-31708 [ MDL-31708 ]
          Dan Poltawski made changes -
          Link This issue has been marked as being related by MDL-29909 [ MDL-29909 ]
          Adrian Greeve made changes -
          Assignee moodle.com [ moodle.com ] Adrian Greeve [ abgreeve ]
          Adrian Greeve made changes -
          Fix Version/s STABLE Sprint 19 [ 11951 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Adrian Greeve made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Pull Master Diff URL https://github.com/abgreeve/moodle/compare/wip-MDL-30478-master
          Pull Master Branch wip-MDL-30478-master
          Pull from Repository git://github.com/abgreeve/moodle.git
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer poltawski
          Dan Poltawski made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Dan Poltawski made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Dan Poltawski made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Dan Poltawski made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Michael de Raadt made changes -
          Fix Version/s STABLE Sprint 20 [ 12152 ]
          Fix Version/s STABLE Sprint 19 [ 11951 ]
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Dan Poltawski made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Testing Instructions You could start by following the replication steps in the description and ensure that you don't get the same problem.

          * Make sure that you have at lease two groups for this course.
          * Create a collaborative wiki activity with visible groups.
          * As the admin create the first page for all participants - put content like 'all participants' in the body so that you can recognise which group you are in.
          * Now change over to another group. Make the first page for them (make sure that you can also identify this page).
          * Continue to switch between groups. Create new pages.
          * log in as students in the course and create new pages.

          [What to look out for]
          Ensure that the group drop down box is the same as the page that you are viewing.
          Make sure that even if you are view a page in a different group, that when you create a new page it's for your group.
          Try creating a wiki with separate groups and check that there are no problems there either.
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2.2 [ 11552 ]
          Affects Version/s 2.3 [ 10657 ]
          Fix Version/s 2.1.6 [ 12052 ]
          Fix Version/s 2.2.3 [ 12053 ]
          Michael de Raadt made changes -
          Tester andyjdavis
          Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Andrew Davis made changes -
          Link This issue testing discovered MDL-32647 [ MDL-32647 ]
          Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 27/Apr/12
          Dan Poltawski made changes -
          Link This issue caused a regression MDL-33607 [ MDL-33607 ]
          Michael de Raadt made changes -
          Link This issue caused a regression MDL-35653 [ MDL-35653 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s STABLE Sprint 20 [ 12152 ]

            People

            • Votes:
              12 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: