Moodle
  1. Moodle
  2. MDL-30481

Advanced upload of files displays confusing message before available from date

    Details

    • Testing Instructions:
      Hide
      1. Create an advanced upload assignment with an available from date in the future
      2. Set 'Prevent late submissions' to 'yes'
      3. It should display the following message "This assignment is not yet available."
      4. Edit the setting and change the due date to the past
      5. It should display the following message "The submission date for this assignment has been closed."
      Show
      Create an advanced upload assignment with an available from date in the future Set 'Prevent late submissions' to 'yes' It should display the following message "This assignment is not yet available." Edit the setting and change the due date to the past It should display the following message "The submission date for this assignment has been closed."
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_21_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
      MDL-30481_m24
    • Pull Master Branch:
    • Rank:
      33153

      Description

      If the assignment is available from a date in the future, then the assignment page still says 'No further submissions are allowed.'

      This is confusing. We have written a small patch to display an alternative message:

      https://github.com/frogprincess/moodle/tree/CMDL-1531

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for pointing that out and providing a solution.

          Show
          Michael de Raadt added a comment - Thanks for pointing that out and providing a solution.
          Hide
          Rossiani Wijaya added a comment -

          The patch for this issue is no longer available.

          I'm creating alternative patch for this issue.

          Show
          Rossiani Wijaya added a comment - The patch for this issue is no longer available. I'm creating alternative patch for this issue.
          Hide
          Adrian Greeve added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [Y] Language
          [-] Databases
          [*] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Hello Rossie,

          The patch works nicely. I just have a couple of comments:

          1. It is really minor, but perhaps you could put in the testing instructions that you need to select 'prevent late submissions' to get the message to display.
          2. I notice that the online text submission and I'm guessing the other types don't have these messages when either too early or too late with submissions. This seems like the right time to display the same message there as well.

          Thanks.

          Show
          Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [*] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hello Rossie, The patch works nicely. I just have a couple of comments: It is really minor, but perhaps you could put in the testing instructions that you need to select 'prevent late submissions' to get the message to display. I notice that the online text submission and I'm guessing the other types don't have these messages when either too early or too late with submissions. This seems like the right time to display the same message there as well. Thanks.
          Hide
          Rossiani Wijaya added a comment -

          Hi Adrian,

          Thank you for reviewing.

          Yes, the rest of assignment types don't have the message for too early or too late submissions.

          I will create a new issue to add the message for the rest of assignment types.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Hi Adrian, Thank you for reviewing. Yes, the rest of assignment types don't have the message for too early or too late submissions. I will create a new issue to add the message for the rest of assignment types. Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          Thanks that's been integrated into 23, 24 and master.

          ps: maybe we should have scrums that skim through issues and point out other possible areas to look at .. before a sprint?

          Show
          Aparup Banerjee added a comment - Thanks that's been integrated into 23, 24 and master. ps: maybe we should have scrums that skim through issues and point out other possible areas to look at .. before a sprint?
          Hide
          Jason Fowler added a comment -

          All Good!

          Show
          Jason Fowler added a comment - All Good!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

          Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

          Thanks, closing as fixed!

          Show
          Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: