Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30484

Regrading quiz causes essay attachments to disappear

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Questions
    • Labels:
    • Environment:
      Linux, PHP 5.3
    • Database:
      Any
    • Testing Instructions:
      Hide

      This is a fairly fundamental change, so it would be good to subject it to careful testing:

      A. Test the reported problem is fixed.
      1. Create a quiz using essay questions that are set to allow attachments, or the use of the filepicker in the HTML editor. (Ideally make a quiz with questions that test all possibilities.)
      2. Attempt the quiz one or more times as a student - perhaps leave some of the attempts un-submitted.
      3. As teacher, grade some, but not all of the responses.
      4. Review the attempts and note what you see.
      5. In the quiz Grades report, do Regrade all.
      6. Then review all the attempts again, and make sure nothing has changed during the regrade. In particular, make sure the embedded files and attachments are still there.

      B. Run all the unit tests in /question and /mod/quiz.

      C. Next we need to check that these fundamental changes have not broken anything.
      1. Create a few questions of different types in the question bank. Try to include at least one question with some hints.
      2. Preview each of these questions in the question-bank preview pop-up. Preview each question using all the different behaviours. Well, at least preview one question with each behaviour, trying a good mixture in total.
      3. Make sure everything works as expected, and in particular that there are no database or other errors, and that no data is lost ever.

      D. Similar to C. but put the new questions in one or more quizzes, using a few different behaviours, and both preview the quiz as a teacher, and attempt it as a student. Make sure nothing appears to be broken.

      Show
      This is a fairly fundamental change, so it would be good to subject it to careful testing: A. Test the reported problem is fixed. 1. Create a quiz using essay questions that are set to allow attachments, or the use of the filepicker in the HTML editor. (Ideally make a quiz with questions that test all possibilities.) 2. Attempt the quiz one or more times as a student - perhaps leave some of the attempts un-submitted. 3. As teacher, grade some, but not all of the responses. 4. Review the attempts and note what you see. 5. In the quiz Grades report, do Regrade all. 6. Then review all the attempts again, and make sure nothing has changed during the regrade. In particular, make sure the embedded files and attachments are still there. B. Run all the unit tests in /question and /mod/quiz. C. Next we need to check that these fundamental changes have not broken anything. 1. Create a few questions of different types in the question bank. Try to include at least one question with some hints. 2. Preview each of these questions in the question-bank preview pop-up. Preview each question using all the different behaviours. Well, at least preview one question with each behaviour, trying a good mixture in total. 3. Make sure everything works as expected, and in particular that there are no database or other errors, and that no data is lost ever. D. Similar to C. but put the new questions in one or more quizzes, using a few different behaviours, and both preview the quiz as a teacher, and attempt it as a student. Make sure nothing appears to be broken.
    • Workaround:
      Hide

      Don't regrade any quiz involving essays with attachments until this has been fixed.

      Show
      Don't regrade any quiz involving essays with attachments until this has been fixed.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Regrading a quiz that contains an essay question with attachments causes those attachments to disappear.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Mar/12