Moodle
  1. Moodle
  2. MDL-30502

Problem with string lookup in enrol/ldap/settings.php

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Enrolments
    • Labels:
    • Environment:
      Windows 7
    • Rank:
      33195

      Description

      Someplace around line 59 has the following

      $settings->add(new admin_setting_ldap_rolemapping('enrol_ldap/role_mapping', get_string ('role_mapping_key', 'enrol_ldap', $role->name), get_string ('role_mapping', 'enrol_ldap'), ''));

      The third argument to the second get_string() call is not used, and generates a warning. Apparently it turns out to be a string rather than an object. In any case the string does not require a $a param.

      Replication steps:
      1. Login as administrator
      2. Turn on DEVELOPER debug messages
      3. Go to "Site administration->Plugins->Enrolments->Manage enrol plugin".

      Now you will see an error message like

      Notice: Trying to get property of non-object in C:\Users\mlitzkow\Zend\workspaces\ApacheWorkspace\Moodle_2\enrol\ldap\settings.php on line 59
      

        Activity

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: