Moodle
  1. Moodle
  2. MDL-30505

Cannot nest an unordered list inside an ordered list in a section description or label

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a page resource
      2. Click the HTML button to enter HTML source
      3. Enter the code in the description of this bug as the Page content
      4. Click Update
      5. Click Save and display
      6. Check that the numbered list displays with a bulleted list nested inside.
      Show
      Create a page resource Click the HTML button to enter HTML source Enter the code in the description of this bug as the Page content Click Update Click Save and display Check that the numbered list displays with a bulleted list nested inside.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      33198

      Description

      Edit a section and create a label and for both make the HTML source the following:

      <p>Some text</p>
      <ol>
      <li>Bli</li>
      <li>Bla</li>
      <ul>
      <li>Ha</li>
      <li>Ho</li>
      </ul>
      <li>Blu</li>
      </ol>
      <p>More text.</p>
      <ul>
      <li>Bli</li>
      <li>Bla</li>
      <ol>
      <li>Ha</li>
      <li>Ho</li>
      </ol>
      <li>Blu</li>
      </ul>
      <p>More text.</p>
      

      Save and check the results. You'll get what is described in MDL-30471

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          Hi Sam,

          I have just spied something in theme/base/style/core.css which must have gone un-noticed for a long time...

          .unlist,
          .unlist li,
          .inline-list,
          .inline-list li,
          .block .list,
          .block .list li,
          .sitetopic .section li,
          .course-content .section li.activity,
          .tabtree li { list-style: none; margin: 0; padding: 0;}
          

          if you remove

          .sitetopic .section li,
          .course-content .section li.activity,
          

          everything works great!

          Show
          Mary Evans added a comment - Hi Sam, I have just spied something in theme/base/style/core.css which must have gone un-noticed for a long time... .unlist, .unlist li, .inline-list, .inline-list li, .block .list, .block .list li, .sitetopic .section li, .course-content .section li.activity, .tabtree li { list-style: none; margin: 0; padding: 0;} if you remove .sitetopic .section li, .course-content .section li.activity, everything works great!
          Hide
          Mary Evans added a comment -

          Well that worked for the TEST list in topic section but added a bullet to an icon in a course section...
          However, putting them back, but add activity class to .sitetopic .section li seems to cure both views.
          So the list would look like this...

          .unlist,
          .unlist li,
          .inline-list,
          .inline-list li,
          .block .list,
          .block .list li,
          .sitetopic .section li.activity,
          .course-content .section li.activity,
          .tabtree li { list-style: none; margin: 0; padding: 0;}
          

          What do you think?

          M

          Show
          Mary Evans added a comment - Well that worked for the TEST list in topic section but added a bullet to an icon in a course section... However, putting them back, but add activity class to .sitetopic .section li seems to cure both views. So the list would look like this... .unlist, .unlist li, .inline-list, .inline-list li, .block .list, .block .list li, .sitetopic .section li.activity, .course-content .section li.activity, .tabtree li { list-style: none; margin: 0; padding: 0;} What do you think? M
          Hide
          Mary Evans added a comment -

          Hi Sam,
          I have just pushed a potential fix for this BUG to Master only if it tests OK can you cherry-pick to Moodle 2.x.x stable branches>
          Thanks
          Mary

          Show
          Mary Evans added a comment - Hi Sam, I have just pushed a potential fix for this BUG to Master only if it tests OK can you cherry-pick to Moodle 2.x.x stable branches> Thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks for getting onto that so promptly Mary - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks for getting onto that so promptly Mary - this has been integrated now
          Hide
          Rajesh Taneja added a comment -

          Works Great
          Thanks for fixing this Mary.

          Show
          Rajesh Taneja added a comment - Works Great Thanks for fixing this Mary.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay!

          Closing and big thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay! Closing and big thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: