Moodle
  1. Moodle
  2. MDL-30526

Choice module does not validate that the responses limit in numeric in the form

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Choice
    • Labels:
      None
    • Rank:
      33237

      Description

      As per subject, choice module form does not validate that the choice responses limit variable is numeric. It is validated by expected type though later on, but there is no feedback in the form.

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          Can be cleanly cherry-picked to earlier version branches.

          Also replaces depricated PARAM_CLEAN with PARAM_CLEANHTML since I am there.

          Show
          Ruslan Kabalin added a comment - Can be cleanly cherry-picked to earlier version branches. Also replaces depricated PARAM_CLEAN with PARAM_CLEANHTML since I am there.
          Hide
          Dan Marsden added a comment -

          Thanks Ruslan - submitting for Integration - I'm guessing it will sit in the integration queue for a couple of weeks until the 2.2 stuff settles in.

          NOTE TO INTEGRATORS - please cherry pick this onto all supported 2.x branches. - thanks!

          Show
          Dan Marsden added a comment - Thanks Ruslan - submitting for Integration - I'm guessing it will sit in the integration queue for a couple of weeks until the 2.2 stuff settles in. NOTE TO INTEGRATORS - please cherry pick this onto all supported 2.x branches. - thanks!
          Hide
          Sam Hemelryk added a comment -

          This has been integrated now thanks guys

          Show
          Sam Hemelryk added a comment - This has been integrated now thanks guys
          Hide
          Rossiani Wijaya added a comment -

          Hi guys,

          The patch is working great. However, while testing this with disabling javascript, the issue still remains.

          I created MDL-30536 to fix the validation when javascript is disabled.

          I'm passing this test because it works with javascript enable.

          Show
          Rossiani Wijaya added a comment - Hi guys, The patch is working great. However, while testing this with disabling javascript, the issue still remains. I created MDL-30536 to fix the validation when javascript is disabled. I'm passing this test because it works with javascript enable.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay!

          Closing and big thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay! Closing and big thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: